| Message ID | 20230306211646.3717-1-vincent.stehle@laposte.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [next] package/openfpgaloader: fix typos | expand |
On Mon, 6 Mar 2023 22:16:46 +0100 Vincent Stehlé via buildroot <buildroot@buildroot.org> wrote: > Fix a typo in the name of two configuration options. > This repairs the selection of libgpiod support. > > Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> > Cc: Jean Burgat <jeanburgat33@gmail.com> > --- > > > Hi, > > The fix for the BR2_PACKAGE_OPENFPGALOADER_LIBGPIOD has a functional change > and is applicable to the next branch only. > > The fix for the BR2_PACKAGE_OPENFPGALOADER_CMSIS is also applicable to the > master branch if desired, but as it has no functional effect I think it is not > that urgent. > > Best regards, > Vincent. > > > package/openfpgaloader/Config.in | 2 +- > package/openfpgaloader/openfpgaloader.mk | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/package/openfpgaloader/Config.in > b/package/openfpgaloader/Config.in index 4ba01d12d3..bd83ad415b 100644 > --- a/package/openfpgaloader/Config.in > +++ b/package/openfpgaloader/Config.in > @@ -12,7 +12,7 @@ config BR2_PACKAGE_OPENFPGALOADER > > if BR2_PACKAGE_OPENFPGALOADER > > -config BR2_PACAKGE_OPENFPGALOADER_CMSIS > +config BR2_PACKAGE_OPENFPGALOADER_CMSIS > bool "CMSIS-DAP support" > depends on BR2_PACKAGE_HAS_UDEV # hidapi > depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # hidapi > diff --git a/package/openfpgaloader/openfpgaloader.mk > b/package/openfpgaloader/openfpgaloader.mk index 042b16612e..6d7fbd9850 100644 > --- a/package/openfpgaloader/openfpgaloader.mk > +++ b/package/openfpgaloader/openfpgaloader.mk > @@ -17,14 +17,14 @@ else > OPENFPGALOADER_CONF_OPTS += -DENABLE_UDEV=OFF > endif > > -ifeq ($(BR2_PACAKGE_OPENFPGALOADER_CMSIS),y) > +ifeq ($(BR2_PACKAGE_OPENFPGALOADER_CMSIS),y) > OPENFPGALOADER_DEPENDENCIES += hidapi > OPENFPGALOADER_CONF_OPTS += -DENABLE_CMSISDAP=ON > else > OPENFPGALOADER_CONF_OPTS += -DENABLE_CMSISDAP=OFF > endif > > -ifeq ($(BR2_PACAKGE_OPENFPGALOADER_LIBGPIOD),y) > +ifeq ($(BR2_PACKAGE_OPENFPGALOADER_LIBGPIOD),y) > OPENFPGALOADER_DEPENDENCIES += libgpiod > OPENFPGALOADER_CONF_OPTS += -DENABLE_LIBGPIOD=ON > else > -- Acked-by: Gwenhael Goavec-merou <gwenhael.goavec-merou@trabucayre.com> Thanks! Regards Gwen
On Mon, 6 Mar 2023 22:16:46 +0100 Vincent Stehlé via buildroot <buildroot@buildroot.org> wrote: > Fix a typo in the name of two configuration options. > This repairs the selection of libgpiod support. > > Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> > Cc: Jean Burgat <jeanburgat33@gmail.com> > --- Applied to next, after adding Config.in.legacy handling for BR2_PACAKGE_OPENFPGALOADER_CMSIS. Indeed this option was already there, and we don't want to break silently existing configurations. Best regards, Thomas
diff --git a/package/openfpgaloader/Config.in b/package/openfpgaloader/Config.in index 4ba01d12d3..bd83ad415b 100644 --- a/package/openfpgaloader/Config.in +++ b/package/openfpgaloader/Config.in @@ -12,7 +12,7 @@ config BR2_PACKAGE_OPENFPGALOADER if BR2_PACKAGE_OPENFPGALOADER -config BR2_PACAKGE_OPENFPGALOADER_CMSIS +config BR2_PACKAGE_OPENFPGALOADER_CMSIS bool "CMSIS-DAP support" depends on BR2_PACKAGE_HAS_UDEV # hidapi depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # hidapi diff --git a/package/openfpgaloader/openfpgaloader.mk b/package/openfpgaloader/openfpgaloader.mk index 042b16612e..6d7fbd9850 100644 --- a/package/openfpgaloader/openfpgaloader.mk +++ b/package/openfpgaloader/openfpgaloader.mk @@ -17,14 +17,14 @@ else OPENFPGALOADER_CONF_OPTS += -DENABLE_UDEV=OFF endif -ifeq ($(BR2_PACAKGE_OPENFPGALOADER_CMSIS),y) +ifeq ($(BR2_PACKAGE_OPENFPGALOADER_CMSIS),y) OPENFPGALOADER_DEPENDENCIES += hidapi OPENFPGALOADER_CONF_OPTS += -DENABLE_CMSISDAP=ON else OPENFPGALOADER_CONF_OPTS += -DENABLE_CMSISDAP=OFF endif -ifeq ($(BR2_PACAKGE_OPENFPGALOADER_LIBGPIOD),y) +ifeq ($(BR2_PACKAGE_OPENFPGALOADER_LIBGPIOD),y) OPENFPGALOADER_DEPENDENCIES += libgpiod OPENFPGALOADER_CONF_OPTS += -DENABLE_LIBGPIOD=ON else
Fix a typo in the name of two configuration options. This repairs the selection of libgpiod support. Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> Cc: Jean Burgat <jeanburgat33@gmail.com> --- Hi, The fix for the BR2_PACKAGE_OPENFPGALOADER_LIBGPIOD has a functional change and is applicable to the next branch only. The fix for the BR2_PACKAGE_OPENFPGALOADER_CMSIS is also applicable to the master branch if desired, but as it has no functional effect I think it is not that urgent. Best regards, Vincent. package/openfpgaloader/Config.in | 2 +- package/openfpgaloader/openfpgaloader.mk | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)