| Message ID | 20230210150456.4535-1-peter@korsgaard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | support/dependencies/dependencies.sh: require diagnostics perl package for mosh | expand |
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes: > Fixes: > http://autobuild.buildroot.net/results/820/820e98b1c126469b1f180f078d102ded43b9c40e/ > scripts/Makefile.am of mosh-1.4.0 needs the perl diagnostics module on the host: > make[3]: Entering directory '/home/buildroot/autobuild/instance-2/output-1/build/mosh-1.4.0/scripts' > perl -Mdiagnostics -c ./mosh.pl > Can't locate diagnostics.pm in @INC (you may need to install the > diagnostics module) (@INC contains: > /home/buildroot/autobuild/instance-2/output-1/host/lib/perl > /usr/local/lib64/perl5/5.36 /usr/local/share/perl5/5.36 > /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl > /usr/lib64/perl5 /usr/share/perl5). > BEGIN failed--compilation aborted. > So add a check for it in dependencies.sh similar to the other perl modules. > Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Committed, thanks.
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes: > Fixes: > http://autobuild.buildroot.net/results/820/820e98b1c126469b1f180f078d102ded43b9c40e/ > scripts/Makefile.am of mosh-1.4.0 needs the perl diagnostics module on the host: > make[3]: Entering directory > '/home/buildroot/autobuild/instance-2/output-1/build/mosh-1.4.0/scripts' > perl -Mdiagnostics -c ./mosh.pl > Can't locate diagnostics.pm in @INC (you may need to install the > diagnostics module) (@INC contains: > /home/buildroot/autobuild/instance-2/output-1/host/lib/perl > /usr/local/lib64/perl5/5.36 /usr/local/share/perl5/5.36 > /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl > /usr/lib64/perl5 /usr/share/perl5). > BEGIN failed--compilation aborted. > So add a check for it in dependencies.sh similar to the other perl modules. > Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Committed to 2022.11.x and 2022.02.x, thanks.
diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh index cf6635bff6..4353e9585e 100755 --- a/support/dependencies/dependencies.sh +++ b/support/dependencies/dependencies.sh @@ -281,6 +281,10 @@ required_perl_modules="$required_perl_modules ExtUtils::MakeMaker" # Used by hos required_perl_modules="$required_perl_modules Thread::Queue" # Used by host-automake required_perl_modules="$required_perl_modules FindBin" # Used by (host-)libopenssl +if grep -q ^BR2_PACKAGE_MOSH=y $BR2_CONFIG ; then + required_perl_modules="$required_perl_modules diagnostics" +fi + if grep -q ^BR2_PACKAGE_MPV=y $BR2_CONFIG ; then required_perl_modules="$required_perl_modules Math::BigInt" required_perl_modules="$required_perl_modules Math::BigRat"
Fixes: http://autobuild.buildroot.net/results/820/820e98b1c126469b1f180f078d102ded43b9c40e/ scripts/Makefile.am of mosh-1.4.0 needs the perl diagnostics module on the host: make[3]: Entering directory '/home/buildroot/autobuild/instance-2/output-1/build/mosh-1.4.0/scripts' perl -Mdiagnostics -c ./mosh.pl Can't locate diagnostics.pm in @INC (you may need to install the diagnostics module) (@INC contains: /home/buildroot/autobuild/instance-2/output-1/host/lib/perl /usr/local/lib64/perl5/5.36 /usr/local/share/perl5/5.36 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5). BEGIN failed--compilation aborted. So add a check for it in dependencies.sh similar to the other perl modules. Signed-off-by: Peter Korsgaard <peter@korsgaard.com> --- support/dependencies/dependencies.sh | 4 ++++ 1 file changed, 4 insertions(+)