diff mbox series

[1/1] package/netopeer2: fix sysv init script, does not start

Message ID 20230131142003.1354787-1-troglobit@gmail.com
State Accepted
Headers show
Series [1/1] package/netopeer2: fix sysv init script, does not start | expand

Commit Message

Joachim Wiberg Jan. 31, 2023, 2:20 p.m. UTC
- The netopeer server forks to background by default, no need for '-b'
 - The path to the daemon is /usr/sbin, not /usr/bin

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
---
 package/netopeer2/S52netopeer2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Thiery Feb. 6, 2023, 10:35 a.m. UTC | #1
Hi Joachim,

Am Di., 31. Jan. 2023 um 15:20 Uhr schrieb Joachim Wiberg <troglobit@gmail.com>:
>
>  - The netopeer server forks to background by default, no need for '-b'
>  - The path to the daemon is /usr/sbin, not /usr/bin
>
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>

Acked-by: Heiko Thiery <heiko.thiery@gmail.com>

> ---
>  package/netopeer2/S52netopeer2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/netopeer2/S52netopeer2 b/package/netopeer2/S52netopeer2
> index cf53a8f109..cadd6b9feb 100644
> --- a/package/netopeer2/S52netopeer2
> +++ b/package/netopeer2/S52netopeer2
> @@ -8,7 +8,7 @@ NETOPEER2_SERVER_ARGS=""
>  start() {
>         printf 'Starting %s: ' "$DAEMON"
>
> -       start-stop-daemon -S -b -q -p $PIDFILE -x "/usr/bin/$DAEMON" \
> +       start-stop-daemon -S -q -p $PIDFILE -x "/usr/sbin/$DAEMON" \
>                 -- $NETOPEER2_SERVER_ARGS
>         status=$?
>         if [ "$status" -eq 0 ]; then
> --
> 2.34.1
>
Yann E. MORIN Feb. 6, 2023, 11:35 a.m. UTC | #2
Joachim, All,

On 2023-01-31 15:20 +0100, Joachim Wiberg spake thusly:
>  - The netopeer server forks to background by default, no need for '-b'
>  - The path to the daemon is /usr/sbin, not /usr/bin
> 
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/netopeer2/S52netopeer2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/netopeer2/S52netopeer2 b/package/netopeer2/S52netopeer2
> index cf53a8f109..cadd6b9feb 100644
> --- a/package/netopeer2/S52netopeer2
> +++ b/package/netopeer2/S52netopeer2
> @@ -8,7 +8,7 @@ NETOPEER2_SERVER_ARGS=""
>  start() {
>  	printf 'Starting %s: ' "$DAEMON"
>  
> -	start-stop-daemon -S -b -q -p $PIDFILE -x "/usr/bin/$DAEMON" \
> +	start-stop-daemon -S -q -p $PIDFILE -x "/usr/sbin/$DAEMON" \
>  		-- $NETOPEER2_SERVER_ARGS
>  	status=$?
>  	if [ "$status" -eq 0 ]; then
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Peter Korsgaard Feb. 22, 2023, 4:30 p.m. UTC | #3
>>>>> "Joachim" == Joachim Wiberg <troglobit@gmail.com> writes:

 >  - The netopeer server forks to background by default, no need for '-b'
 >  - The path to the daemon is /usr/sbin, not /usr/bin

 > Signed-off-by: Joachim Wiberg <troglobit@gmail.com>

Committed to 2022.11.x and 2022.02.x, thanks.
diff mbox series

Patch

diff --git a/package/netopeer2/S52netopeer2 b/package/netopeer2/S52netopeer2
index cf53a8f109..cadd6b9feb 100644
--- a/package/netopeer2/S52netopeer2
+++ b/package/netopeer2/S52netopeer2
@@ -8,7 +8,7 @@  NETOPEER2_SERVER_ARGS=""
 start() {
 	printf 'Starting %s: ' "$DAEMON"
 
-	start-stop-daemon -S -b -q -p $PIDFILE -x "/usr/bin/$DAEMON" \
+	start-stop-daemon -S -q -p $PIDFILE -x "/usr/sbin/$DAEMON" \
 		-- $NETOPEER2_SERVER_ARGS
 	status=$?
 	if [ "$status" -eq 0 ]; then