| Message ID | 20230101233653.487175-21-ricardo.martincoski@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | check-package: warn about symbols not recognized by a package infra | expand |
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes: > Commit "cb328f77f8 policycoreutils: new package" added a define that is > never called: POLICYCOREUTILS_INSTALL_TARGET_LINUX_PAM_CONFS. > The build system from the package already install these files to target. > So just drop the bogus define. > Cc: Clayton Shotwell <clayton.shotwell@collins.com> > Cc: Matt Weber <matthew.weber@collins.com> > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Committed, thanks.
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes: > Commit "cb328f77f8 policycoreutils: new package" added a define that is > never called: POLICYCOREUTILS_INSTALL_TARGET_LINUX_PAM_CONFS. > The build system from the package already install these files to target. > So just drop the bogus define. > Cc: Clayton Shotwell <clayton.shotwell@collins.com> > Cc: Matt Weber <matthew.weber@collins.com> > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Committed to 2022.11.x and 2022.02.x, thanks.
diff --git a/package/policycoreutils/policycoreutils.mk b/package/policycoreutils/policycoreutils.mk index 60575ac644..8505dbca3f 100644 --- a/package/policycoreutils/policycoreutils.mk +++ b/package/policycoreutils/policycoreutils.mk @@ -16,10 +16,6 @@ POLICYCOREUTILS_MAKE_OPTS = LDLIBS=$(TARGET_NLS_LIBS) ifeq ($(BR2_PACKAGE_LINUX_PAM),y) POLICYCOREUTILS_DEPENDENCIES += linux-pam POLICYCOREUTILS_MAKE_OPTS += NAMESPACE_PRIV=y -define POLICYCOREUTILS_INSTALL_TARGET_LINUX_PAM_CONFS - $(INSTALL) -D -m 0644 $(@D)/newrole/newrole-lspp.pamd $(TARGET_DIR)/etc/pam.d/newrole - $(INSTALL) -D -m 0644 $(@D)/run_init/run_init.pamd $(TARGET_DIR)/etc/pam.d/run_init -endef endif ifeq ($(BR2_PACKAGE_AUDIT),y)
Commit "cb328f77f8 policycoreutils: new package" added a define that is never called: POLICYCOREUTILS_INSTALL_TARGET_LINUX_PAM_CONFS. The build system from the package already install these files to target. So just drop the bogus define. Cc: Clayton Shotwell <clayton.shotwell@collins.com> Cc: Matt Weber <matthew.weber@collins.com> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> --- Using this defconfig: BR2_x86_i686=y BR2_TOOLCHAIN_EXTERNAL=y BR2_PACKAGE_LINUX_PAM=y BR2_PACKAGE_POLICYCOREUTILS=y and performing a build before and after this patch, the content in target/etc/pam.d/ is exactly the same. $ md5sum output.*/target/etc/pam.d/* |sort 8448253cd52778260856591208cbf09a output.after/target/etc/pam.d/run_init 8448253cd52778260856591208cbf09a output.before/target/etc/pam.d/run_init 912cb497b06401def2991346787cfff3 output.after/target/etc/pam.d/other 912cb497b06401def2991346787cfff3 output.before/target/etc/pam.d/other eac337ec241afe0ef2f4e5039be26cea output.after/target/etc/pam.d/login eac337ec241afe0ef2f4e5039be26cea output.before/target/etc/pam.d/login f4a2547443ac34fb30b7d06719328570 output.after/target/etc/pam.d/newrole f4a2547443ac34fb30b7d06719328570 output.before/target/etc/pam.d/newrole --- package/policycoreutils/policycoreutils.mk | 4 ---- 1 file changed, 4 deletions(-)