| Message ID | 20230101233653.487175-2-ricardo.martincoski@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | check-package: warn about symbols not recognized by a package infra | expand |
On Sun, 1 Jan 2023 20:36:25 -0300 Ricardo Martincoski <ricardo.martincoski@gmail.com> wrote: > Commit "f6fe8932df pkg-generic: add checks on deprecated variables > FOO_BAR_OPT" introduced checks for deprecated variables, and warns the > user to use _INSTALL_HOST_OPTS instead of _INSTALL_HOST_OPT. > > Commit "6a25cec33d package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> > _INSTALL_OPTS" removed the usage of _INSTALL_HOST_OPTS but didn't add a > check for the deprecated variable. > > Add a warning to change _INSTALL_HOST_OPTS to _INSTALL_OPTS. > And change the warning for _INSTALL_HOST_OPT to also suggest > _INSTALL_OPTS. > > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> > --- > package/pkg-generic.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Not sure why we didn't apply this earlier: applied to next. Thanks! Thomas
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index f24e03a325..9db86eccea 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -1200,7 +1200,8 @@ $(eval $(call check-deprecated-variable,$(2)_MAKE_OPT,$(2)_MAKE_OPTS)) $(eval $(call check-deprecated-variable,$(2)_INSTALL_OPT,$(2)_INSTALL_OPTS)) $(eval $(call check-deprecated-variable,$(2)_INSTALL_TARGET_OPT,$(2)_INSTALL_TARGET_OPTS)) $(eval $(call check-deprecated-variable,$(2)_INSTALL_STAGING_OPT,$(2)_INSTALL_STAGING_OPTS)) -$(eval $(call check-deprecated-variable,$(2)_INSTALL_HOST_OPT,$(2)_INSTALL_HOST_OPTS)) +$(eval $(call check-deprecated-variable,$(2)_INSTALL_HOST_OPT,$(2)_INSTALL_OPTS)) +$(eval $(call check-deprecated-variable,$(2)_INSTALL_HOST_OPTS,$(2)_INSTALL_OPTS)) $(eval $(call check-deprecated-variable,$(2)_AUTORECONF_OPT,$(2)_AUTORECONF_OPTS)) $(eval $(call check-deprecated-variable,$(2)_CONF_OPT,$(2)_CONF_OPTS)) $(eval $(call check-deprecated-variable,$(2)_BUILD_OPT,$(2)_BUILD_OPTS))
Commit "f6fe8932df pkg-generic: add checks on deprecated variables FOO_BAR_OPT" introduced checks for deprecated variables, and warns the user to use _INSTALL_HOST_OPTS instead of _INSTALL_HOST_OPT. Commit "6a25cec33d package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS" removed the usage of _INSTALL_HOST_OPTS but didn't add a check for the deprecated variable. Add a warning to change _INSTALL_HOST_OPTS to _INSTALL_OPTS. And change the warning for _INSTALL_HOST_OPT to also suggest _INSTALL_OPTS. Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> --- package/pkg-generic.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)