| Message ID | 20230101233653.487175-19-ricardo.martincoski@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | check-package: warn about symbols not recognized by a package infra | expand |
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes: > Commit "f0d37e275a package/libtalloc: new package" added these symbols > but they are not used in the package and also not recognized by the waf > package infra. > So drop the ignored symbols. > Cc: David GOUARIN <dgouarin@gmail.com> > Cc: Matt Weber <matthew.weber@collins.com> > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> > --- > build test: > 44 builds, 4 skipped, 0 build failed, 0 legal-info failed, 0 show-info failed > https://gitlab.com/RicardoMartincoski/buildroot/-/pipelines/731863771 > test-pkg config: > BR2_PACKAGE_LIBTIRPC=y > BR2_PACKAGE_LIBTALLOC=y > --- > package/libtalloc/libtalloc.mk | 2 -- > 1 file changed, 2 deletions(-) > diff --git a/package/libtalloc/libtalloc.mk b/package/libtalloc/libtalloc.mk > index 75d3da263b..ca15180d22 100644 > --- a/package/libtalloc/libtalloc.mk > +++ b/package/libtalloc/libtalloc.mk > @@ -31,8 +31,6 @@ LIBTALLOC_CONF_OPTS += --cross-compile \ > --with-libiconv=$(STAGING_DIR)/usr > ifeq ($(BR2_PACKAGE_LIBTIRPC),y) > -LIBTALLOC_CFLAGS += `$(PKG_CONFIG_HOST_BINARY) --cflags libtirpc` > -LIBTALLOC_LDFLAGS += `$(PKG_CONFIG_HOST_BINARY) --libs libtirpc` > LIBTALLOC_DEPENDENCIES += libtirpc host-pkgconf I wonder if host-pkgconf is then needed? Committed, thanks.
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes: > Commit "f0d37e275a package/libtalloc: new package" added these symbols > but they are not used in the package and also not recognized by the waf > package infra. > So drop the ignored symbols. > Cc: David GOUARIN <dgouarin@gmail.com> > Cc: Matt Weber <matthew.weber@collins.com> > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Committed to 2022.11.x and 2022.02.x, thanks.
diff --git a/package/libtalloc/libtalloc.mk b/package/libtalloc/libtalloc.mk index 75d3da263b..ca15180d22 100644 --- a/package/libtalloc/libtalloc.mk +++ b/package/libtalloc/libtalloc.mk @@ -31,8 +31,6 @@ LIBTALLOC_CONF_OPTS += --cross-compile \ --with-libiconv=$(STAGING_DIR)/usr ifeq ($(BR2_PACKAGE_LIBTIRPC),y) -LIBTALLOC_CFLAGS += `$(PKG_CONFIG_HOST_BINARY) --cflags libtirpc` -LIBTALLOC_LDFLAGS += `$(PKG_CONFIG_HOST_BINARY) --libs libtirpc` LIBTALLOC_DEPENDENCIES += libtirpc host-pkgconf endif
Commit "f0d37e275a package/libtalloc: new package" added these symbols but they are not used in the package and also not recognized by the waf package infra. So drop the ignored symbols. Cc: David GOUARIN <dgouarin@gmail.com> Cc: Matt Weber <matthew.weber@collins.com> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> --- build test: 44 builds, 4 skipped, 0 build failed, 0 legal-info failed, 0 show-info failed https://gitlab.com/RicardoMartincoski/buildroot/-/pipelines/731863771 test-pkg config: BR2_PACKAGE_LIBTIRPC=y BR2_PACKAGE_LIBTALLOC=y --- package/libtalloc/libtalloc.mk | 2 -- 1 file changed, 2 deletions(-)