| Message ID | 20221218005546.1793522-1-christian@paral.in |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v4,1/1] package/rtl8821cu: new package | expand |
Hi Christian, On 18/12/22 01:55, Christian Stewart via buildroot wrote: > Adds support for USB rtl8821cu wifi cards. > > Similar to rtl8821au and rtl8812au-aircrack-ng packages. > > https://github.com/morrownr/8821cu-20210118 > > Signed-off-by: Christian Stewart <christian@paral.in> > > --- > > v1 -> v2: > > - add myself to DEVELOPERS > - bump to latest commit 615995 > - fixes build failure against the odroid xu4 kernel > - simplify -Werror=date-time fix-patch > - simplify makefile patches > > v2 -> v3: > > - remove platform-specific checks > > v3 -> v4: > > - fix setting USER_EXTRA_CFLAGS > - unset PLATFORM_GENERIC > - thanks for the suggestion from Giulio Benetti > - https://patchwork.ozlabs.org/project/buildroot/patch/20221213203236.171656-1-giulio.benetti@benettiengineering.com/ > > Signed-off-by: Christian Stewart <christian@paral.in> > --- > DEVELOPERS | 1 + > package/Config.in | 1 + > package/rtl8821cu/Config.in | 10 ++++++++++ > package/rtl8821cu/rtl8821cu.hash | 3 +++ > package/rtl8821cu/rtl8821cu.mk | 25 +++++++++++++++++++++++++ > 5 files changed, 40 insertions(+) > create mode 100644 package/rtl8821cu/Config.in > create mode 100644 package/rtl8821cu/rtl8821cu.hash > create mode 100644 package/rtl8821cu/rtl8821cu.mk > > diff --git a/DEVELOPERS b/DEVELOPERS > index 3a0e3c14ab..9152b3321b 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -560,6 +560,7 @@ F: package/mosh/ > F: package/nerdctl/ > F: package/pkg-golang.mk > F: package/rtl8821au/ > +F: package/rtl8821cu/ > F: package/runc/ > F: package/tini/ > F: support/testing/tests/package/test_docker_compose.py > diff --git a/package/Config.in b/package/Config.in > index 914c3584e9..0ffb1654ec 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -587,6 +587,7 @@ endmenu > source "package/rtl8723ds/Config.in" > source "package/rtl8812au-aircrack-ng/Config.in" > source "package/rtl8821au/Config.in" > + source "package/rtl8821cu/Config.in" > source "package/sane-backends/Config.in" > source "package/sdparm/Config.in" > source "package/sedutil/Config.in" > diff --git a/package/rtl8821cu/Config.in b/package/rtl8821cu/Config.in > new file mode 100644 > index 0000000000..a5a7b9d255 > --- /dev/null > +++ b/package/rtl8821cu/Config.in > @@ -0,0 +1,10 @@ > +comment "rtl8821cu needs a Linux kernel to be built" > + depends on !BR2_LINUX_KERNEL > + > +config BR2_PACKAGE_RTL8821CU > + bool "rtl8821cu" > + depends on BR2_LINUX_KERNEL > + help > + rtl8821cu wifi driver > + > + https://github.com/brektrou/rtl8821CU > diff --git a/package/rtl8821cu/rtl8821cu.hash b/package/rtl8821cu/rtl8821cu.hash > new file mode 100644 > index 0000000000..efb9871472 > --- /dev/null > +++ b/package/rtl8821cu/rtl8821cu.hash > @@ -0,0 +1,3 @@ > +# Locally calculated > +sha256 09b9fb4160003502d564d0d0d85d6f19b8b6d1627d1a339b3ddfca6a948d84fb rtl8821cu-86cc5ceb7c28b9b997838e1c796847f6c395c382.tar.gz > +sha256 af54d00efc57cfce664171ac8be2a20c0f290b1b5c1a67bb2eba7b6380276c4e LICENSE > diff --git a/package/rtl8821cu/rtl8821cu.mk b/package/rtl8821cu/rtl8821cu.mk > new file mode 100644 > index 0000000000..18222e0014 > --- /dev/null > +++ b/package/rtl8821cu/rtl8821cu.mk > @@ -0,0 +1,25 @@ > +################################################################################ > +# > +# rtl8821cu > +# > +################################################################################ > + > +RTL8821CU_VERSION = 86cc5ceb7c28b9b997838e1c796847f6c395c382 > +RTL8821CU_SITE = $(call github,morrownr,8821cu-20210118,$(RTL8821CU_VERSION)) > +RTL8821CU_LICENSE = GPL-2.0 > +RTL8821CU_LICENSE_FILES = LICENSE > + > +RTL8821CU_USER_EXTRA_CFLAGS = \ > + -DCONFIG_$(call qstrip,$(BR2_ENDIAN))_ENDIAN \ > + -DCONFIG_IOCTL_CFG80211 \ > + -DRTW_USE_CFG80211_STA_EVENT \ > + -Wno-error > + > +RTL8821CU_MODULE_MAKE_OPTS = \ > + CONFIG_PLATFORM_GENERIC=n \ > + CONFIG_RTL8821CU=m \ > + KVER=$(LINUX_VERSION_PROBED) \ > + USER_EXTRA_CFLAGS="$(RTL8821CU_USER_EXTRA_CFLAGS)" > + > +$(eval $(kernel-module)) > +$(eval $(generic-package)) I've just built successfully for a Big Endian architecture and everything looks good me so: Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Best regards
Hi Christian, I apologize if I've missed something, but the package config description (and your email intro) don't match the github source repo. On Sat, Dec 17, 2022 at 4:56 PM Christian Stewart via buildroot < buildroot@buildroot.org> wrote: > +config BR2_PACKAGE_RTL8821CU > + bool "rtl8821cu" > + depends on BR2_LINUX_KERNEL > + help > + rtl8821cu wifi driver > + > + https://github.com/brektrou/rtl8821CU > ... > +RTL8821CU_VERSION = 86cc5ceb7c28b9b997838e1c796847f6c395c382 > +RTL8821CU_SITE = $(call > github,morrownr,8821cu-20210118,$(RTL8821CU_VERSION)) > Maybe there's a reason for this that I'm missing? Thanks, <>< <>< <>< Bryce Schober
Bryce, On Wed, Dec 21, 2022, 10:26 AM <bryce.schober@gmail.com> wrote: > Hi Christian, > > I apologize if I've missed something, but the package config description > (and your email intro) don't match the github source repo. > Good catch, thanks, yes the link in Config.in is incorrect and should be this instead: https://github.com/morrownr/8821cu-20210118 Thanks, Christian
>>>>> "Christian" == Christian Stewart <christian@paral.in> writes: > Adds support for USB rtl8821cu wifi cards. > Similar to rtl8821au and rtl8812au-aircrack-ng packages. > https://github.com/morrownr/8821cu-20210118 > Signed-off-by: Christian Stewart <christian@paral.in> Committed, thanks.
diff --git a/DEVELOPERS b/DEVELOPERS index 3a0e3c14ab..9152b3321b 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -560,6 +560,7 @@ F: package/mosh/ F: package/nerdctl/ F: package/pkg-golang.mk F: package/rtl8821au/ +F: package/rtl8821cu/ F: package/runc/ F: package/tini/ F: support/testing/tests/package/test_docker_compose.py diff --git a/package/Config.in b/package/Config.in index 914c3584e9..0ffb1654ec 100644 --- a/package/Config.in +++ b/package/Config.in @@ -587,6 +587,7 @@ endmenu source "package/rtl8723ds/Config.in" source "package/rtl8812au-aircrack-ng/Config.in" source "package/rtl8821au/Config.in" + source "package/rtl8821cu/Config.in" source "package/sane-backends/Config.in" source "package/sdparm/Config.in" source "package/sedutil/Config.in" diff --git a/package/rtl8821cu/Config.in b/package/rtl8821cu/Config.in new file mode 100644 index 0000000000..a5a7b9d255 --- /dev/null +++ b/package/rtl8821cu/Config.in @@ -0,0 +1,10 @@ +comment "rtl8821cu needs a Linux kernel to be built" + depends on !BR2_LINUX_KERNEL + +config BR2_PACKAGE_RTL8821CU + bool "rtl8821cu" + depends on BR2_LINUX_KERNEL + help + rtl8821cu wifi driver + + https://github.com/brektrou/rtl8821CU diff --git a/package/rtl8821cu/rtl8821cu.hash b/package/rtl8821cu/rtl8821cu.hash new file mode 100644 index 0000000000..efb9871472 --- /dev/null +++ b/package/rtl8821cu/rtl8821cu.hash @@ -0,0 +1,3 @@ +# Locally calculated +sha256 09b9fb4160003502d564d0d0d85d6f19b8b6d1627d1a339b3ddfca6a948d84fb rtl8821cu-86cc5ceb7c28b9b997838e1c796847f6c395c382.tar.gz +sha256 af54d00efc57cfce664171ac8be2a20c0f290b1b5c1a67bb2eba7b6380276c4e LICENSE diff --git a/package/rtl8821cu/rtl8821cu.mk b/package/rtl8821cu/rtl8821cu.mk new file mode 100644 index 0000000000..18222e0014 --- /dev/null +++ b/package/rtl8821cu/rtl8821cu.mk @@ -0,0 +1,25 @@ +################################################################################ +# +# rtl8821cu +# +################################################################################ + +RTL8821CU_VERSION = 86cc5ceb7c28b9b997838e1c796847f6c395c382 +RTL8821CU_SITE = $(call github,morrownr,8821cu-20210118,$(RTL8821CU_VERSION)) +RTL8821CU_LICENSE = GPL-2.0 +RTL8821CU_LICENSE_FILES = LICENSE + +RTL8821CU_USER_EXTRA_CFLAGS = \ + -DCONFIG_$(call qstrip,$(BR2_ENDIAN))_ENDIAN \ + -DCONFIG_IOCTL_CFG80211 \ + -DRTW_USE_CFG80211_STA_EVENT \ + -Wno-error + +RTL8821CU_MODULE_MAKE_OPTS = \ + CONFIG_PLATFORM_GENERIC=n \ + CONFIG_RTL8821CU=m \ + KVER=$(LINUX_VERSION_PROBED) \ + USER_EXTRA_CFLAGS="$(RTL8821CU_USER_EXTRA_CFLAGS)" + +$(eval $(kernel-module)) +$(eval $(generic-package))