diff mbox series

[1/1] package/sscep: requires blowfish support in openssl

Message ID 20221206220311.1350707-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/sscep: requires blowfish support in openssl | expand

Commit Message

Fabrice Fontaine Dec. 6, 2022, 10:03 p.m. UTC
Enable blowfish in openssl to fix the following build failure raised
since the addition of the package in commit
72fa60dc102679f51b228336ec38f5af78ff7646:

src/sscep.c: In function 'get_cipher_alg':
src/sscep.c:123:24: warning: implicit declaration of function 'EVP_bf_cbc'; did you mean 'EVP_sm4_cbc'? [-Wimplicit-function-declaration]
  123 |                 return EVP_bf_cbc();
      |                        ^~~~~~~~~~
      |                        EVP_sm4_cbc

Fixes:
 - http://autobuild.buildroot.org/results/55d2c481d8c148fb3bb61c1331340bcd71274553

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/sscep/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Dario Binacchi Dec. 11, 2022, 2:08 p.m. UTC | #1
Hi Fabrice,,

On Tue, Dec 6, 2022 at 11:03 PM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Enable blowfish in openssl to fix the following build failure raised
> since the addition of the package in commit
> 72fa60dc102679f51b228336ec38f5af78ff7646:
>
> src/sscep.c: In function 'get_cipher_alg':
> src/sscep.c:123:24: warning: implicit declaration of function 'EVP_bf_cbc'; did you mean 'EVP_sm4_cbc'? [-Wimplicit-function-declaration]
>   123 |                 return EVP_bf_cbc();
>       |                        ^~~~~~~~~~
>       |                        EVP_sm4_cbc
>
> Fixes:
>  - http://autobuild.buildroot.org/results/55d2c481d8c148fb3bb61c1331340bcd71274553
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/sscep/Config.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/sscep/Config.in b/package/sscep/Config.in
> index 4b9039c9b2..2e5e29f7c8 100644
> --- a/package/sscep/Config.in
> +++ b/package/sscep/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_SSCEP
>         bool "sscep"
> +       select BR2_PACKAGE_LIBOPENSSL_ENABLE_BLOWFISH if BR2_PACKAGE_LIBOPENSSL
>         select BR2_PACKAGE_OPENSSL
>         help
>           SSCEP is a client-only implementation of the SCEP
> --
> 2.35.1
>
Reviewed-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Thanks and regards,
Dario
Thomas Petazzoni Dec. 11, 2022, 4:51 p.m. UTC | #2
On Tue,  6 Dec 2022 23:03:11 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Enable blowfish in openssl to fix the following build failure raised
> since the addition of the package in commit
> 72fa60dc102679f51b228336ec38f5af78ff7646:
> 
> src/sscep.c: In function 'get_cipher_alg':
> src/sscep.c:123:24: warning: implicit declaration of function 'EVP_bf_cbc'; did you mean 'EVP_sm4_cbc'? [-Wimplicit-function-declaration]
>   123 |                 return EVP_bf_cbc();
>       |                        ^~~~~~~~~~
>       |                        EVP_sm4_cbc
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/55d2c481d8c148fb3bb61c1331340bcd71274553
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/sscep/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
diff mbox series

Patch

diff --git a/package/sscep/Config.in b/package/sscep/Config.in
index 4b9039c9b2..2e5e29f7c8 100644
--- a/package/sscep/Config.in
+++ b/package/sscep/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_SSCEP
 	bool "sscep"
+	select BR2_PACKAGE_LIBOPENSSL_ENABLE_BLOWFISH if BR2_PACKAGE_LIBOPENSSL
 	select BR2_PACKAGE_OPENSSL
 	help
 	  SSCEP is a client-only implementation of the SCEP