| Message ID | 20221018131506.123350-1-giulio.benetti@benettiengineering.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | package/rtl8188eu: remove wrong description in Config.in | expand |
Hi Giulio, On Tue, 18 Oct 2022 15:15:06 +0200 Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > This rtl8188eu driver is not the same as the one in mainline Linux that > still has pending work to be done that in this driver is done, check: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/r8188eu/TODO > specifically: > * Switch to use LIB80211. > * Switch to use MAC80211. > * Switch to use CFG80211. > So let's remove the description that is not valid anymore. A lot of this text would be useful in the help text below. The help text is visible in any moment in later releases, the commit log needs to be searched. > Suggested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/rtl8188eu/Config.in | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/package/rtl8188eu/Config.in b/package/rtl8188eu/Config.in > index 76d9085297..8d68d104c8 100644 > --- a/package/rtl8188eu/Config.in > +++ b/package/rtl8188eu/Config.in > @@ -4,9 +4,6 @@ config BR2_PACKAGE_RTL8188EU > depends on BR2_LINUX_KERNEL > help > A standalone driver for the RTL8188EU USB Wi-Fi adapter. > - This is needed only for Linux kernels before 3.12. > - Since 3.12, there is a (staging) driver in mainline, with a > - similar codebase. For the above reasons, I'd add here: This rtl8188eu driver is not the same as the one in mainline Linux that still has pending work to be done that in this driver is done, check: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/r8188eu/TODO I'd not add the todo list, as it will (hopefully) change in the future in the kernel and we don't want to keep updating our own copy.
Hi Luca, On 19/10/22 09:15, Luca Ceresoli via buildroot wrote: > Hi Giulio, > > On Tue, 18 Oct 2022 15:15:06 +0200 > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > >> This rtl8188eu driver is not the same as the one in mainline Linux that >> still has pending work to be done that in this driver is done, check: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/r8188eu/TODO >> specifically: >> * Switch to use LIB80211. >> * Switch to use MAC80211. >> * Switch to use CFG80211. >> So let's remove the description that is not valid anymore. > > A lot of this text would be useful in the help text below. The help > text is visible in any moment in later releases, the commit log needs > to be searched. > >> Suggested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- >> package/rtl8188eu/Config.in | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/package/rtl8188eu/Config.in b/package/rtl8188eu/Config.in >> index 76d9085297..8d68d104c8 100644 >> --- a/package/rtl8188eu/Config.in >> +++ b/package/rtl8188eu/Config.in >> @@ -4,9 +4,6 @@ config BR2_PACKAGE_RTL8188EU >> depends on BR2_LINUX_KERNEL >> help >> A standalone driver for the RTL8188EU USB Wi-Fi adapter. >> - This is needed only for Linux kernels before 3.12. >> - Since 3.12, there is a (staging) driver in mainline, with a >> - similar codebase. > > For the above reasons, I'd add here: > > This rtl8188eu driver is not the same as the one in mainline Linux that > still has pending work to be done that in this driver is done, check: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/r8188eu/TODO > > I'd not add the todo list, as it will (hopefully) change in the future > in the kernel and we don't want to keep updating our own copy. Good idea. Thank you for taking care. I've just sent v2 patch: https://patchwork.ozlabs.org/project/buildroot/patch/20221019134823.12594-1-giulio.benetti@benettiengineering.com/ Kind regards
diff --git a/package/rtl8188eu/Config.in b/package/rtl8188eu/Config.in index 76d9085297..8d68d104c8 100644 --- a/package/rtl8188eu/Config.in +++ b/package/rtl8188eu/Config.in @@ -4,9 +4,6 @@ config BR2_PACKAGE_RTL8188EU depends on BR2_LINUX_KERNEL help A standalone driver for the RTL8188EU USB Wi-Fi adapter. - This is needed only for Linux kernels before 3.12. - Since 3.12, there is a (staging) driver in mainline, with a - similar codebase. Make sure your target kernel has the CONFIG_WIRELESS_EXT config option enabled.
This rtl8188eu driver is not the same as the one in mainline Linux that still has pending work to be done that in this driver is done, check: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/r8188eu/TODO specifically: * Switch to use LIB80211. * Switch to use MAC80211. * Switch to use CFG80211. So let's remove the description that is not valid anymore. Suggested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/rtl8188eu/Config.in | 3 --- 1 file changed, 3 deletions(-)