| Message ID | 20221004110421.137795-5-angelo@amarulasolutions.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Configure default wifi through kconfig | expand |
On 04/10/2022 13:04, Angelo Compagnucci wrote: > Add a proper wpa-conf line to the interfaces files to let the system > bring up the wifi interface and the related wpa supplicant. > > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> > --- > Changes: > v3: > * add "|| true" lo let the command exit without error when > BR2_SYSTEM_CONNECT_WIFI is empty (me) > > package/ifupdown-scripts/ifupdown-scripts.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/ifupdown-scripts/ifupdown-scripts.mk b/package/ifupdown-scripts/ifupdown-scripts.mk > index 5ef032142c..ebaf234143 100644 > --- a/package/ifupdown-scripts/ifupdown-scripts.mk > +++ b/package/ifupdown-scripts/ifupdown-scripts.mk > @@ -28,6 +28,8 @@ define IFUPDOWN_SCRIPTS_DHCP > echo " pre-up /etc/network/nfs_check"; \ > echo " wait-delay 15"; \ > echo " hostname \$$(hostname)"; \ > + test -n "$(BR2_SYSTEM_CONNECT_WIFI)" && \ > + echo " wpa-conf /etc/wpa_supplicant.conf" || true; \ You can write this as $(if $(BR2_SYSTEM_CONNECT_WIFI),echo " wpa-conf /etc/wpa_supplicant.conf") (but as I said, I think it's better to have a separate BR2_SYSTEM_WLAN section.) Regards, Arnout > ) >> $(TARGET_DIR)/etc/network/interfaces > endef > define IFUPDOWN_SCRIPTS_DHCP_OPENRC
diff --git a/package/ifupdown-scripts/ifupdown-scripts.mk b/package/ifupdown-scripts/ifupdown-scripts.mk index 5ef032142c..ebaf234143 100644 --- a/package/ifupdown-scripts/ifupdown-scripts.mk +++ b/package/ifupdown-scripts/ifupdown-scripts.mk @@ -28,6 +28,8 @@ define IFUPDOWN_SCRIPTS_DHCP echo " pre-up /etc/network/nfs_check"; \ echo " wait-delay 15"; \ echo " hostname \$$(hostname)"; \ + test -n "$(BR2_SYSTEM_CONNECT_WIFI)" && \ + echo " wpa-conf /etc/wpa_supplicant.conf" || true; \ ) >> $(TARGET_DIR)/etc/network/interfaces endef define IFUPDOWN_SCRIPTS_DHCP_OPENRC
Add a proper wpa-conf line to the interfaces files to let the system bring up the wifi interface and the related wpa supplicant. Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> --- Changes: v3: * add "|| true" lo let the command exit without error when BR2_SYSTEM_CONNECT_WIFI is empty (me) package/ifupdown-scripts/ifupdown-scripts.mk | 2 ++ 1 file changed, 2 insertions(+)