diff mbox series

[v2] package/dcron: fix /etc/cron.d/system cron jobs

Message ID 20220926160849.1046939-1-mario.haustein@hrz.tu-chemnitz.de
State Accepted
Headers show
Series [v2] package/dcron: fix /etc/cron.d/system cron jobs | expand

Commit Message

Mario Haustein Sept. 26, 2022, 4:08 p.m. UTC
Jobs with the syntax @hourly, @daily, ... were not executed since the
version bump from `v4.5` to commit `1ba33c3325df48de46263276a43ed76cf9d81518`.
This patch fixes the bug downstream.

Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
---
Changes v1 -> v2:
  - Use `git format-patch` to export the patch
  - Specify the version bump which broke dcron in the commit message

Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
---
 package/dcron/0002-system-crontab.patch | 28 +++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 package/dcron/0002-system-crontab.patch

Comments

Yann E. MORIN April 17, 2023, 6:48 a.m. UTC | #1
Mario, All,

Sorry, for the long delay...

> Jobs with the syntax @hourly, @daily, ... were not executed since the
> version bump from `v4.5` to commit `1ba33c3325df48de46263276a43ed76cf9d81518`.
> This patch fixes the bug downstream.
> 
> Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>

Without any feedback from upstream, which has been inactive for more
than a year now: applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2:
>   - Use `git format-patch` to export the patch
>   - Specify the version bump which broke dcron in the commit message
> 
> Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> ---
>  package/dcron/0002-system-crontab.patch | 28 +++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 package/dcron/0002-system-crontab.patch
> 
> diff --git a/package/dcron/0002-system-crontab.patch b/package/dcron/0002-system-crontab.patch
> new file mode 100644
> index 0000000000..95d9606b7a
> --- /dev/null
> +++ b/package/dcron/0002-system-crontab.patch
> @@ -0,0 +1,28 @@
> +From 1fd99b71b063b1573beaf9f6b801ec5be2fbe24f Mon Sep 17 00:00:00 2001
> +From: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> +Date: Fri, 2 Sep 2022 23:20:14 +0200
> +Subject: [PATCH] Make @hourly, @daily, ... work again
> +
> +closes #15
> +
> +Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> +[Upstream status: https://github.com/dubiousjim/dcron/pull/35]
> +---
> + database.c | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/database.c b/database.c
> +index 37cf17a..6ec720e 100644
> +--- a/database.c
> ++++ b/database.c
> +@@ -455,6 +455,8 @@ SynchronizeFile(const char *dpath, const char *fileName, const char *userName)
> + 							line.cl_Days[j] = 1;
> + 						for (j=0; j<12; ++j)
> + 							line.cl_Mons[j] = 1;
> ++						for (j=0; j<7; ++j)
> ++							line.cl_Dow[j] = ALL_DOW;
> + 					}
> + 
> + 					while (*ptr == ' ' || *ptr == '\t')
> +-- 
> +2.35.1
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Peter Korsgaard April 23, 2023, 10:37 a.m. UTC | #2
>>>>> "Mario" == Mario Haustein <mario.haustein@hrz.tu-chemnitz.de> writes:

 > Jobs with the syntax @hourly, @daily, ... were not executed since the
 > version bump from `v4.5` to commit `1ba33c3325df48de46263276a43ed76cf9d81518`.
 > This patch fixes the bug downstream.

 > Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
 > ---
 > Changes v1 -> v2:
 >   - Use `git format-patch` to export the patch
 >   - Specify the version bump which broke dcron in the commit message

 > Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>

Committed to 2023.02.x and 2022.02.x, thanks.
diff mbox series

Patch

diff --git a/package/dcron/0002-system-crontab.patch b/package/dcron/0002-system-crontab.patch
new file mode 100644
index 0000000000..95d9606b7a
--- /dev/null
+++ b/package/dcron/0002-system-crontab.patch
@@ -0,0 +1,28 @@ 
+From 1fd99b71b063b1573beaf9f6b801ec5be2fbe24f Mon Sep 17 00:00:00 2001
+From: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
+Date: Fri, 2 Sep 2022 23:20:14 +0200
+Subject: [PATCH] Make @hourly, @daily, ... work again
+
+closes #15
+
+Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
+[Upstream status: https://github.com/dubiousjim/dcron/pull/35]
+---
+ database.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/database.c b/database.c
+index 37cf17a..6ec720e 100644
+--- a/database.c
++++ b/database.c
+@@ -455,6 +455,8 @@ SynchronizeFile(const char *dpath, const char *fileName, const char *userName)
+ 							line.cl_Days[j] = 1;
+ 						for (j=0; j<12; ++j)
+ 							line.cl_Mons[j] = 1;
++						for (j=0; j<7; ++j)
++							line.cl_Dow[j] = ALL_DOW;
+ 					}
+ 
+ 					while (*ptr == ' ' || *ptr == '\t')
+-- 
+2.35.1