| Message ID | 20220826155934.12677-1-tianyuanhao3@163.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/network-manager: needs host-libxslt | expand |
On Fri, Aug 26, 2022 at 10:01 AM TIAN Yuanhao <tianyuanhao3@163.com> wrote: > > Besides, order depends alphabetically. > > Fixes: > output/build/network-manager-1.36.4/meson.build:89:0: ERROR: Program 'xsltproc' not found or not executable > > See: > http://cgit.openembedded.org/meta-openembedded/tree/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.36.2.bb?h=kirkstone#n13 > > Cc: James Hilliard <james.hilliard1@gmail.com> Reviewed-by: James Hilliard <james.hilliard1@gmail.com> > Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com> > --- > package/network-manager/network-manager.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk > index d782370082..391baaafde 100644 > --- a/package/network-manager/network-manager.mk > +++ b/package/network-manager/network-manager.mk > @@ -9,8 +9,8 @@ NETWORK_MANAGER_VERSION = $(NETWORK_MANAGER_VERSION_MAJOR).4 > NETWORK_MANAGER_SOURCE = NetworkManager-$(NETWORK_MANAGER_VERSION).tar.xz > NETWORK_MANAGER_SITE = https://download.gnome.org/sources/NetworkManager/$(NETWORK_MANAGER_VERSION_MAJOR) > NETWORK_MANAGER_INSTALL_STAGING = YES > -NETWORK_MANAGER_DEPENDENCIES = host-pkgconf dbus udev gnutls libglib2 \ > - host-intltool libndp util-linux > +NETWORK_MANAGER_DEPENDENCIES = host-intltool host-libxslt host-pkgconf \ > + dbus gnutls libglib2 libndp udev util-linux > NETWORK_MANAGER_LICENSE = GPL-2.0+ (app), LGPL-2.1+ (libnm) > NETWORK_MANAGER_LICENSE_FILES = COPYING COPYING.LGPL CONTRIBUTING.md > NETWORK_MANAGER_CPE_ID_VENDOR = gnome > -- > 2.25.1 >
Yuanhao, All, On 2022-08-26 08:59 -0700, TIAN Yuanhao spake thusly: > Besides, order depends alphabetically. > > Fixes: > output/build/network-manager-1.36.4/meson.build:89:0: ERROR: Program 'xsltproc' not found or not executable > > See: > http://cgit.openembedded.org/meta-openembedded/tree/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.36.2.bb?h=kirkstone#n13 > > Cc: James Hilliard <james.hilliard1@gmail.com> > Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com> Applied to next (as this is with the meson build system), thanks. It is however a bit sad that we have to unconditionally need it, as it should only be needed, as far as I can see, for goi or manpages. Regards, Yann E. MORIN. > --- > package/network-manager/network-manager.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk > index d782370082..391baaafde 100644 > --- a/package/network-manager/network-manager.mk > +++ b/package/network-manager/network-manager.mk > @@ -9,8 +9,8 @@ NETWORK_MANAGER_VERSION = $(NETWORK_MANAGER_VERSION_MAJOR).4 > NETWORK_MANAGER_SOURCE = NetworkManager-$(NETWORK_MANAGER_VERSION).tar.xz > NETWORK_MANAGER_SITE = https://download.gnome.org/sources/NetworkManager/$(NETWORK_MANAGER_VERSION_MAJOR) > NETWORK_MANAGER_INSTALL_STAGING = YES > -NETWORK_MANAGER_DEPENDENCIES = host-pkgconf dbus udev gnutls libglib2 \ > - host-intltool libndp util-linux > +NETWORK_MANAGER_DEPENDENCIES = host-intltool host-libxslt host-pkgconf \ > + dbus gnutls libglib2 libndp udev util-linux > NETWORK_MANAGER_LICENSE = GPL-2.0+ (app), LGPL-2.1+ (libnm) > NETWORK_MANAGER_LICENSE_FILES = COPYING COPYING.LGPL CONTRIBUTING.md > NETWORK_MANAGER_CPE_ID_VENDOR = gnome > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk index d782370082..391baaafde 100644 --- a/package/network-manager/network-manager.mk +++ b/package/network-manager/network-manager.mk @@ -9,8 +9,8 @@ NETWORK_MANAGER_VERSION = $(NETWORK_MANAGER_VERSION_MAJOR).4 NETWORK_MANAGER_SOURCE = NetworkManager-$(NETWORK_MANAGER_VERSION).tar.xz NETWORK_MANAGER_SITE = https://download.gnome.org/sources/NetworkManager/$(NETWORK_MANAGER_VERSION_MAJOR) NETWORK_MANAGER_INSTALL_STAGING = YES -NETWORK_MANAGER_DEPENDENCIES = host-pkgconf dbus udev gnutls libglib2 \ - host-intltool libndp util-linux +NETWORK_MANAGER_DEPENDENCIES = host-intltool host-libxslt host-pkgconf \ + dbus gnutls libglib2 libndp udev util-linux NETWORK_MANAGER_LICENSE = GPL-2.0+ (app), LGPL-2.1+ (libnm) NETWORK_MANAGER_LICENSE_FILES = COPYING COPYING.LGPL CONTRIBUTING.md NETWORK_MANAGER_CPE_ID_VENDOR = gnome
Besides, order depends alphabetically. Fixes: output/build/network-manager-1.36.4/meson.build:89:0: ERROR: Program 'xsltproc' not found or not executable See: http://cgit.openembedded.org/meta-openembedded/tree/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.36.2.bb?h=kirkstone#n13 Cc: James Hilliard <james.hilliard1@gmail.com> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com> --- package/network-manager/network-manager.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)