| Message ID | 20220809083325.1906594-2-fontaine.fabrice@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/2] Revert "utils/genrandconfig: add refpolicy custom git handling" | expand |
Hello Fabrice, On Tue, 9 Aug 2022 10:33:25 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > Set default values for custom repo to make sure that a random > configuration with an empty repo location or version for refpolicy > doesn't fail. > > Fixes: > - http://autobuild.buildroot.org/results/98da07a1f9b88e2e8a028a55c8cf76c6ebc28304 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> I don't think that's the right way of solving this, because it would be inconsistent with what we do for Linux, U-Boot, Barebox, TF-A and all those projects that have a configurable version/repository option. So I have instead applied your patch fixing the indentation in genrandconfig. Best regards, Thomas
diff --git a/package/refpolicy/Config.in b/package/refpolicy/Config.in index 0e72b895df..223f0f5a08 100644 --- a/package/refpolicy/Config.in +++ b/package/refpolicy/Config.in @@ -56,9 +56,11 @@ if BR2_PACKAGE_REFPOLICY_CUSTOM_GIT config BR2_PACKAGE_REFPOLICY_CUSTOM_REPO_URL string "URL of custom repository" + default "https://github.com/SELinuxProject/refpolicy" config BR2_PACKAGE_REFPOLICY_CUSTOM_REPO_VERSION string "Custom repository version" + default "RELEASE_2_20220106" help Revision to use in the typical format used by Git. E.g. a sha id, tag, branch...
Set default values for custom repo to make sure that a random configuration with an empty repo location or version for refpolicy doesn't fail. Fixes: - http://autobuild.buildroot.org/results/98da07a1f9b88e2e8a028a55c8cf76c6ebc28304 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/refpolicy/Config.in | 2 ++ 1 file changed, 2 insertions(+)