| Message ID | 20220729000904.1295295-5-joel@jms.id.au |
|---|---|
| State | Accepted |
| Headers | show |
| Series | powerpc: Fix ppc64le configurations | expand |
On 7/29/22 02:08, Joel Stanley wrote: > With "arch/powerpc: Enable powerpc64le only on CPUs that support it" > we can use this symbol to indicate the CPU is supported by glibc. > > Signed-off-by: Joel Stanley <joel@jms.id.au> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > package/glibc/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/glibc/Config.in b/package/glibc/Config.in > index 23cbfcd9aa4f..e0ce46968278 100644 > --- a/package/glibc/Config.in > +++ b/package/glibc/Config.in > @@ -12,7 +12,7 @@ config BR2_PACKAGE_GLIBC_ARCH_SUPPORTS > default y if BR2_or1k > default y if BR2_powerpc > default y if BR2_powerpc64 > - default y if BR2_powerpc_power8 > + default y if BR2_powerpc64le > default y if BR2_riscv > default y if BR2_s390x > default y if BR2_sh
Joel, All, On 2022-07-29 09:38 +0930, Joel Stanley spake thusly: > With "arch/powerpc: Enable powerpc64le only on CPUs that support it" > we can use this symbol to indicate the CPU is supported by glibc. > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > package/glibc/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/glibc/Config.in b/package/glibc/Config.in > index 23cbfcd9aa4f..e0ce46968278 100644 > --- a/package/glibc/Config.in > +++ b/package/glibc/Config.in > @@ -12,7 +12,7 @@ config BR2_PACKAGE_GLIBC_ARCH_SUPPORTS > default y if BR2_or1k > default y if BR2_powerpc > default y if BR2_powerpc64 > - default y if BR2_powerpc_power8 > + default y if BR2_powerpc64le This is indeed good, because it aligns it to the dependency to kernel headers version, line 35. You could probably add that info to the commit log when you respin the series. Acked-by: Yann E. MORIN <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > default y if BR2_riscv > default y if BR2_s390x > default y if BR2_sh > -- > 2.35.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
On 29/07/2022 02:08, Joel Stanley wrote: > With "arch/powerpc: Enable powerpc64le only on CPUs that support it" > we can use this symbol to indicate the CPU is supported by glibc. > > Signed-off-by: Joel Stanley <joel@jms.id.au> Applied to master, after extending commit log as indicated by Yann, thanks. Regards, Arnout > --- > package/glibc/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/glibc/Config.in b/package/glibc/Config.in > index 23cbfcd9aa4f..e0ce46968278 100644 > --- a/package/glibc/Config.in > +++ b/package/glibc/Config.in > @@ -12,7 +12,7 @@ config BR2_PACKAGE_GLIBC_ARCH_SUPPORTS > default y if BR2_or1k > default y if BR2_powerpc > default y if BR2_powerpc64 > - default y if BR2_powerpc_power8 > + default y if BR2_powerpc64le > default y if BR2_riscv > default y if BR2_s390x > default y if BR2_sh
diff --git a/package/glibc/Config.in b/package/glibc/Config.in index 23cbfcd9aa4f..e0ce46968278 100644 --- a/package/glibc/Config.in +++ b/package/glibc/Config.in @@ -12,7 +12,7 @@ config BR2_PACKAGE_GLIBC_ARCH_SUPPORTS default y if BR2_or1k default y if BR2_powerpc default y if BR2_powerpc64 - default y if BR2_powerpc_power8 + default y if BR2_powerpc64le default y if BR2_riscv default y if BR2_s390x default y if BR2_sh
With "arch/powerpc: Enable powerpc64le only on CPUs that support it" we can use this symbol to indicate the CPU is supported by glibc. Signed-off-by: Joel Stanley <joel@jms.id.au> --- package/glibc/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)