| Message ID | 20220704053911.2840122-1-kelvin.zhang@amlogic.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] configs/meson-g12a-u212: new board | expand |
Hi Kelvin, On 04/07/22 07:39, Kelvin Zhang wrote: > This commit adds a new defconfig for the Amlogic U212 board. > > U212 is a reference board manufactured by Amlogic > with the following specifications: > > - Amlogic S905X2 Quad-Core ARM Cortex-A53 SoC > - 2GB DDR3 SDRAM > - 16GB eMMC > - 10/100/1000 Ethernet MAC (10/100 Internal PHY) > - 1x USB2 + 1x USB3 > - SDcard > - Audio HAT Connector / SPDIF > - HDMI 2.1 > - Infrared receiver > - SDIO WiFi Module > > Amlogic S905X2 SoC is designed for smart OTT/IP STB, > which belongs to Amlogic G12A SoC family. > > More info about this chip: > https://www.amlogic.com/#Products/396/index.html This is a good commit log, but you should provide a readme.txt file describing how to build and program the sd-card(I presume). > Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com> > --- > configs/meson-g12a-u212_defconfig | 10 ++++++++++ > 1 file changed, 10 insertions(+) > create mode 100644 configs/meson-g12a-u212_defconfig > > > base-commit: 23e1e04d5448e17da7ec0a65199740dodad1cf923a0 > > diff --git a/configs/meson-g12a-u212_defconfig b/configs/meson-g12a-u212_defconfig > new file mode 100644 > index 0000000000..a933b1f8f3 > --- /dev/null > +++ b/configs/meson-g12a-u212_defconfig > @@ -0,0 +1,10 @@ > +BR2_aarch64=y > +BR2_TOOLCHAIN_BUILDROOT_CXX=y Why is this ^^^ option needed? > +BR2_GCC_ENABLE_LTO=y I would let the user to decide if using LTO or not, so please remove it. > +BR2_LINUX_KERNEL=y Here you should specify the Linux version, otherwise every time Buildroot changes the latest Linux version it will be used, but this way the board won't be stable at all. So add: BR2_LINUX_KERNEL_CUSTOM_VERSION=y BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.57" (for example) > +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y > +BR2_LINUX_KERNEL_XZ=y > +BR2_LINUX_KERNEL_DTS_SUPPORT=y > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="amlogic/meson-g12a-u200" > +BR2_TARGET_ROOTFS_INITRAMFS=y Is initramfs mandatory for the system? If not I would let the user to decide if building the initramfs or not. > +BR2_TARGET_ROOTFS_TAR_XZ=y I see u-boot or other bootloader is missing, so please explain how boot process works in readme.txt file I've requested you above, or even better you could provide u-boot support too. It would be good also to have a final sd-card .img file that here is missing. Otherwise, if this defconfig is only meant for building Linux and the rootfs then please specify it in the commit log. I've tried to build this defconfig with Buildroot's utils/docker-run and you're missing: BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y that lead to linux build failure with latest Linux 5.17.15, so please, when specifying the custom linux version, check with utils/docker-run that all host dependencies are satisfied. After enabling BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL it built fine. Wait for V2 patch then. Thank you! Best regards
diff --git a/configs/meson-g12a-u212_defconfig b/configs/meson-g12a-u212_defconfig new file mode 100644 index 0000000000..a933b1f8f3 --- /dev/null +++ b/configs/meson-g12a-u212_defconfig @@ -0,0 +1,10 @@ +BR2_aarch64=y +BR2_TOOLCHAIN_BUILDROOT_CXX=y +BR2_GCC_ENABLE_LTO=y +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y +BR2_LINUX_KERNEL_XZ=y +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="amlogic/meson-g12a-u200" +BR2_TARGET_ROOTFS_INITRAMFS=y +BR2_TARGET_ROOTFS_TAR_XZ=y
This commit adds a new defconfig for the Amlogic U212 board. U212 is a reference board manufactured by Amlogic with the following specifications: - Amlogic S905X2 Quad-Core ARM Cortex-A53 SoC - 2GB DDR3 SDRAM - 16GB eMMC - 10/100/1000 Ethernet MAC (10/100 Internal PHY) - 1x USB2 + 1x USB3 - SDcard - Audio HAT Connector / SPDIF - HDMI 2.1 - Infrared receiver - SDIO WiFi Module Amlogic S905X2 SoC is designed for smart OTT/IP STB, which belongs to Amlogic G12A SoC family. More info about this chip: https://www.amlogic.com/#Products/396/index.html Signed-off-by: Kelvin Zhang <kelvin.zhang@amlogic.com> --- configs/meson-g12a-u212_defconfig | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 configs/meson-g12a-u212_defconfig base-commit: 23e1e04d5448e17da7ec0a65199740ad1cf923a0