| Message ID | 20220628183213.2838372-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] package/libsamplerate: use --{dis, en}able-alsa | expand |
On Tue, 28 Jun 2022 20:32:11 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > Commit 5b679d7806767206f2c7bd7ff69b412bebb504f8 forgot to set > --{dis,en}able-alsa > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/libsamplerate/libsamplerate.mk | 3 +++ > 1 file changed, 3 insertions(+) Series applied to master. On PATCH 2/3, I've added a comment in libsamplerate.mk to explain why we're passing --disable-sndfile, so that someone is not tempted to re-add an optional dependency to sndfile. Thanks a lot! Thomas
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > Commit 5b679d7806767206f2c7bd7ff69b412bebb504f8 forgot to set > --{dis,en}able-alsa > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Committed to 2022.05.x and 2022.02.x, thanks.
diff --git a/package/libsamplerate/libsamplerate.mk b/package/libsamplerate/libsamplerate.mk index 146d57d15e..9d6b6a5ca5 100644 --- a/package/libsamplerate/libsamplerate.mk +++ b/package/libsamplerate/libsamplerate.mk @@ -15,6 +15,9 @@ LIBSAMPLERATE_CPE_ID_VENDOR = libsamplerate_project ifeq ($(BR2_PACKAGE_ALSA_LIB),y) LIBSAMPLERATE_DEPENDENCIES += alsa-lib +LIBSAMPLERATE_CONF_OPTS += --enable-alsa +else +LIBSAMPLERATE_CONF_OPTS += --disable-alsa endif ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
Commit 5b679d7806767206f2c7bd7ff69b412bebb504f8 forgot to set --{dis,en}able-alsa Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/libsamplerate/libsamplerate.mk | 3 +++ 1 file changed, 3 insertions(+)