| Message ID | 20220627073306.2673751-1-james.hilliard1@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/{webkitgtk, wpewebkit}: select subenc for multimedia | expand |
On Mon, 27 Jun 2022 01:33:06 -0600 James Hilliard <james.hilliard1@gmail.com> wrote: > When using webkit with multimedia support the subenc element may > be needed, as such we should select the subenc plugin. > > Fixes runtime warning: > isGStreamerPluginAvailable: Plugin subenc not found. Please check your GStreamer installation > WebKit wasn't able to find a WebVTT encoder. Subtitles handling will be degraded unless gst-plugins-bad is installed. > > See: > https://github.com/WebKit/WebKit/blob/72b59ad50e079037073722bbdf469c0952e399fa/Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp#L221 > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> Acked-by: Adrian Perez de Castro <aperez@igalia.com> > --- > package/webkitgtk/Config.in | 1 + > package/wpewebkit/Config.in | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in > index 2575108363..2219aa353e 100644 > --- a/package/webkitgtk/Config.in > +++ b/package/webkitgtk/Config.in > @@ -97,6 +97,7 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA > select BR2_PACKAGE_GST1_PLUGINS_BAD > select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS > select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX > + select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SUBENC > select BR2_PACKAGE_GST1_PLUGINS_BASE > select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA > select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP > diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in > index f50e0da21c..fac7672939 100644 > --- a/package/wpewebkit/Config.in > +++ b/package/wpewebkit/Config.in > @@ -90,6 +90,7 @@ config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA > select BR2_PACKAGE_GST1_PLUGINS_BAD > select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS > select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX > + select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SUBENC > select BR2_PACKAGE_GST1_PLUGINS_BASE > select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA > select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot > Cheers, —Adrián
On Mon, 27 Jun 2022 01:33:06 -0600 James Hilliard <james.hilliard1@gmail.com> wrote: > When using webkit with multimedia support the subenc element may > be needed, as such we should select the subenc plugin. > > Fixes runtime warning: > isGStreamerPluginAvailable: Plugin subenc not found. Please check your GStreamer installation > WebKit wasn't able to find a WebVTT encoder. Subtitles handling will be degraded unless gst-plugins-bad is installed. > > See: > https://github.com/WebKit/WebKit/blob/72b59ad50e079037073722bbdf469c0952e399fa/Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp#L221 > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > --- > package/webkitgtk/Config.in | 1 + > package/wpewebkit/Config.in | 1 + > 2 files changed, 2 insertions(+) Applied to master, thanks. Thomas
>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes: > When using webkit with multimedia support the subenc element may > be needed, as such we should select the subenc plugin. > Fixes runtime warning: > isGStreamerPluginAvailable: Plugin subenc not found. Please check your GStreamer installation > WebKit wasn't able to find a WebVTT encoder. Subtitles handling will > be degraded unless gst-plugins-bad is installed. > See: > https://github.com/WebKit/WebKit/blob/72b59ad50e079037073722bbdf469c0952e399fa/Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp#L221 > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> Committed to 2022.05.x and 2022.02.x, thanks.
diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in index 2575108363..2219aa353e 100644 --- a/package/webkitgtk/Config.in +++ b/package/webkitgtk/Config.in @@ -97,6 +97,7 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA select BR2_PACKAGE_GST1_PLUGINS_BAD select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX + select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SUBENC select BR2_PACKAGE_GST1_PLUGINS_BASE select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in index f50e0da21c..fac7672939 100644 --- a/package/wpewebkit/Config.in +++ b/package/wpewebkit/Config.in @@ -90,6 +90,7 @@ config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA select BR2_PACKAGE_GST1_PLUGINS_BAD select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX + select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SUBENC select BR2_PACKAGE_GST1_PLUGINS_BASE select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
When using webkit with multimedia support the subenc element may be needed, as such we should select the subenc plugin. Fixes runtime warning: isGStreamerPluginAvailable: Plugin subenc not found. Please check your GStreamer installation WebKit wasn't able to find a WebVTT encoder. Subtitles handling will be degraded unless gst-plugins-bad is installed. See: https://github.com/WebKit/WebKit/blob/72b59ad50e079037073722bbdf469c0952e399fa/Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp#L221 Signed-off-by: James Hilliard <james.hilliard1@gmail.com> --- package/webkitgtk/Config.in | 1 + package/wpewebkit/Config.in | 1 + 2 files changed, 2 insertions(+)