diff mbox series

[1/1] package/alsa-utils: selects BR2_PACKAGE_ALSA_LIB_{PCM, RAWMIDI}

Message ID 20220615205026.117274-1-fontaine.fabrice@gmail.com
State Superseded
Headers show
Series [1/1] package/alsa-utils: selects BR2_PACKAGE_ALSA_LIB_{PCM, RAWMIDI} | expand

Commit Message

Fabrice Fontaine June 15, 2022, 8:50 p.m. UTC
alsactl (which is unconditionally built) needs
BR2_PACKAGE_ALSA_LIB_RAWMIDI since bump to version 1.2.7 in commit
4dc8563363d639255217ffc59482eaccf93a1b51 and
https://github.com/alsa-project/alsa-utils/commit/bbc74a61ac7c35e506c3d7f76ecf943cb55736a6:

info.c:83:44: error: unknown type name 'snd_rawmidi_stream_t'; did you mean 'snd_pcm_stream_t'?
   83 | static const char *snd_rawmidi_stream_name(snd_rawmidi_stream_t stream)
      |                                            ^~~~~~~~~~~~~~~~~~~~
      |                                            snd_pcm_stream_t

aplay (which is always built as BR2_PACKAGE_ALSA_LIB_PCM is selected by
BR2_PACKAGE_ALSA_LIB) needs BR2_PACKAGE_ALSA_LIB_UCM since bump to
version 1.2.7 in commit 4dc8563363d639255217ffc59482eaccf93a1b51 and
https://github.com/alsa-project/alsa-utils/commit/90f59671784a7e47b40485095cd66892d4840ed7:

aplay.c:44:10: fatal error: alsa/use-case.h: No such file or directory
   44 | #include <alsa/use-case.h>
      |          ^~~~~~~~~~~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/708aecfafccecd99f8a4178412a9dd0cf9123f72
 - http://autobuild.buildroot.org/results/366aa43e82615e2a5a36fcb98b3bdfbc5e99786f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/alsa-utils/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Petazzoni July 20, 2022, 4:43 p.m. UTC | #1
On Wed, 15 Jun 2022 22:50:26 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> alsactl (which is unconditionally built) needs
> BR2_PACKAGE_ALSA_LIB_RAWMIDI since bump to version 1.2.7 in commit
> 4dc8563363d639255217ffc59482eaccf93a1b51 and
> https://github.com/alsa-project/alsa-utils/commit/bbc74a61ac7c35e506c3d7f76ecf943cb55736a6:
> 
> info.c:83:44: error: unknown type name 'snd_rawmidi_stream_t'; did you mean 'snd_pcm_stream_t'?
>    83 | static const char *snd_rawmidi_stream_name(snd_rawmidi_stream_t stream)
>       |                                            ^~~~~~~~~~~~~~~~~~~~
>       |                                            snd_pcm_stream_t
> 
> aplay (which is always built as BR2_PACKAGE_ALSA_LIB_PCM is selected by
> BR2_PACKAGE_ALSA_LIB) needs BR2_PACKAGE_ALSA_LIB_UCM since bump to
> version 1.2.7 in commit 4dc8563363d639255217ffc59482eaccf93a1b51 and
> https://github.com/alsa-project/alsa-utils/commit/90f59671784a7e47b40485095cd66892d4840ed7:
> 
> aplay.c:44:10: fatal error: alsa/use-case.h: No such file or directory
>    44 | #include <alsa/use-case.h>
>       |          ^~~~~~~~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/708aecfafccecd99f8a4178412a9dd0cf9123f72
>  - http://autobuild.buildroot.org/results/366aa43e82615e2a5a36fcb98b3bdfbc5e99786f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

This has been fixed differently in:

  https://git.buildroot.org/buildroot/commit/?id=83bad5e0f00df3b03fd55916f5e03e64946ff177

Best regards,

Thomas
diff mbox series

Patch

diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
index 2d7062b0ca..2358b3f83a 100644
--- a/package/alsa-utils/Config.in
+++ b/package/alsa-utils/Config.in
@@ -7,6 +7,8 @@  menuconfig BR2_PACKAGE_ALSA_UTILS
 	depends on BR2_USE_MMU # fork
 	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
 	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_ALSA_LIB_RAWMIDI
+	select BR2_PACKAGE_ALSA_LIB_UCM
 	help
 	  This package contains the command line utilities for the ALSA
 	  project.