diff mbox series

[v2,4/4] board/zynqmp/post-build.sh: remove unnecessary if

Message ID 20220609140449.210030-4-neal.frager@xilinx.com
State Accepted
Headers show
Series [v2,1/4] board/zynqmp/post-build.sh: auto-generate extlinux.conf | expand

Commit Message

Neal Frager June 9, 2022, 2:04 p.m. UTC 
From: Neal Frager <neal.frager@amd.com>

Now that all of the extlinux.conf files have been removed,
it is no longer necessary to check if the file exists.

Signed-off-by: Neal Frager <neal.frager@amd.com>
---
 board/zynqmp/post-build.sh | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Luca Ceresoli June 15, 2022, 9:01 p.m. UTC | #1 
On 09/06/22 16:04, Neal Frager wrote:
> From: Neal Frager <neal.frager@amd.com>
> 
> Now that all of the extlinux.conf files have been removed,
> it is no longer necessary to check if the file exists.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>


Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
diff mbox series

Patch

diff --git a/board/zynqmp/post-build.sh b/board/zynqmp/post-build.sh
index 7387576414..0713bd1b05 100755
--- a/board/zynqmp/post-build.sh
+++ b/board/zynqmp/post-build.sh
@@ -7,15 +7,10 @@  BOARD_DIR="$(dirname $0)"
 CONSOLE=$2
 ROOT=$3
 
-FILE=${BOARD_DIR}/extlinux.conf
-if test -f "${FILE}"; then
-  install -m 0644 -D "${FILE}" "${BINARIES_DIR}/extlinux.conf"
-else
-  mkdir -p "${BINARIES_DIR}"
-  cat <<-__HEADER_EOF > "${BINARIES_DIR}/extlinux.conf"
+mkdir -p "${BINARIES_DIR}"
+cat <<-__HEADER_EOF > "${BINARIES_DIR}/extlinux.conf"
 	label linux
 	  kernel /Image
 	  devicetree /system.dtb
 	  append console=${CONSOLE} root=/dev/${ROOT} rw rootwait
 	__HEADER_EOF
-fi