diff mbox series

arch/Config.in: armeb no-MMU is not supported

Message ID 20220608094803.3403930-1-thomas.petazzoni@bootlin.com
State Accepted
Headers show
Series arch/Config.in: armeb no-MMU is not supported | expand

Commit Message

Thomas Petazzoni June 8, 2022, 9:48 a.m. UTC
elf2flt does not support ARM big-endian, so supporting Cortex M3/M4/M7
with armeb is not possibly.

Therefore this commit makes:

 - MMU mandatory on armeb
 - Prevents from seeing Cortex M3/M4/M7 on armeb

Fixes:

  http://autobuild.buildroot.net/results/9bca0cbfb6a66c455e74ad194526bca942665978/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 arch/Config.in     | 2 +-
 arch/Config.in.arm | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni June 9, 2022, 8:31 p.m. UTC | #1
On Wed,  8 Jun 2022 11:48:02 +0200
Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:

> elf2flt does not support ARM big-endian, so supporting Cortex M3/M4/M7
> with armeb is not possibly.
> 
> Therefore this commit makes:
> 
>  - MMU mandatory on armeb
>  - Prevents from seeing Cortex M3/M4/M7 on armeb
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/9bca0cbfb6a66c455e74ad194526bca942665978/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  arch/Config.in     | 2 +-
>  arch/Config.in.arm | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)

I have mistakenly pushed my own patch, sorry about this. Hopefully
people are OK with this, if not I can revert. Let me know.

Best regards,

Thomas
Peter Korsgaard June 19, 2022, 1 p.m. UTC | #2
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > elf2flt does not support ARM big-endian, so supporting Cortex M3/M4/M7
 > with armeb is not possibly.

 > Therefore this commit makes:

 >  - MMU mandatory on armeb
 >  - Prevents from seeing Cortex M3/M4/M7 on armeb

 > Fixes:

 >   http://autobuild.buildroot.net/results/9bca0cbfb6a66c455e74ad194526bca942665978/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2022.05.x and 2022.02.x, thanks.
diff mbox series

Patch

diff --git a/arch/Config.in b/arch/Config.in
index 49e16fce38..da499b37ab 100644
--- a/arch/Config.in
+++ b/arch/Config.in
@@ -49,7 +49,7 @@  config BR2_arm
 
 config BR2_armeb
 	bool "ARM (big endian)"
-	# MMU support is set by the subarchitecture file, arch/Config.in.arm
+	select BR2_ARCH_HAS_MMU_MANDATORY
 	help
 	  ARM is a 32-bit reduced instruction set computer (RISC)
 	  instruction set architecture (ISA) developed by ARM Holdings.
diff --git a/arch/Config.in.arm b/arch/Config.in.arm
index fa2e882550..eb71d70430 100644
--- a/arch/Config.in.arm
+++ b/arch/Config.in.arm
@@ -242,6 +242,8 @@  config BR2_pj4
 	select BR2_ARM_CPU_HAS_VFPV3
 	select BR2_ARM_CPU_ARMV7A
 
+# Cortex-M cores are only supported for little endian configurations
+if BR2_arm
 comment "armv7m cores"
 config BR2_cortex_m3
 	bool "cortex-M3"
@@ -258,6 +260,7 @@  config BR2_cortex_m7
 	select BR2_ARM_CPU_MAYBE_HAS_FPV5
 	select BR2_ARM_CPU_ARMV7M
 	select BR2_ARCH_NEEDS_GCC_AT_LEAST_5
+endif # BR2_arm
 endif # !BR2_ARCH_IS_64
 
 comment "armv8 cores"