| Message ID | 20220515193633.180221-1-romain.naour@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/gcc: restrict hs4x_rel31 to arc gcc fork | expand |
On 2022-05-15 21:36 +0200, Romain Naour spake thusly: > ARC hs4x_rel31 cpu is not supported by upstream gcc version. > Only the generic HS48 processor (BR2_archs4x) is supported > by upstream gcc. > > Fixes: > http://autobuild.buildroot.net/results/357a74d53af96d4b868a9d5b9f9ce9432e0c53b5 > http://autobuild.buildroot.net/results/bcdf160a3d5ffcccd4402f65aca153faca4b32c2 > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: ARC Maintainers <arc-buildroot@synopsys.com> > --- > package/gcc/Config.in.host | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host > index f6b9b4fa9d..2b12035c4b 100644 > --- a/package/gcc/Config.in.host > +++ b/package/gcc/Config.in.host > @@ -31,6 +31,8 @@ config BR2_GCC_VERSION_9_X > # upstream gcc. C-SKY gcc upstream support not tested > # with upstream binutils and glibc. > depends on !BR2_csky > + # ARC HS48 rel 31 only supported by gcc arc fork. > + depends on !BR2_archs4x_rel31 So, in the commit log, you say that BR2_archs4x is the only variant supported by upstream gcc, yet this change still allows all the hs38 and the 7x0d variants to use the upstream gcc. Did I misread the commit log, and you really meant: Of the hs48 series, only the generic HS48 processor (BR2_archs4x) is supported by upstream gcc, while the hs48 rel31 (hs4x_rel31) is not, and is only suppoerted by the ARC fork. All the other variants, 7x0d and hs38, are all supported in upstream gcc. Thoughts? Regards, Yann E. MORIN. > select BR2_TOOLCHAIN_GCC_AT_LEAST_9 > > config BR2_GCC_VERSION_10_X > @@ -43,6 +45,8 @@ config BR2_GCC_VERSION_10_X > # upstream gcc. C-SKY gcc upstream support not tested > # with upstream binutils and glibc. > depends on !BR2_csky > + # ARC HS48 rel 31 only supported by gcc arc fork. > + depends on !BR2_archs4x_rel31 > select BR2_TOOLCHAIN_GCC_AT_LEAST_10 > > config BR2_GCC_VERSION_11_X > @@ -54,6 +58,8 @@ config BR2_GCC_VERSION_11_X > # that need to be reverted since gcc 8.4, 9.3 and 10.1. > # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98784 > depends on !BR2_sparc > + # ARC HS48 rel 31 only supported by gcc arc fork. > + depends on !BR2_archs4x_rel31 > select BR2_TOOLCHAIN_GCC_AT_LEAST_11 > > endchoice > -- > 2.35.3 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Yann, Le 16/05/2022 à 23:44, Yann E. MORIN a écrit : > On 2022-05-15 21:36 +0200, Romain Naour spake thusly: >> ARC hs4x_rel31 cpu is not supported by upstream gcc version. >> Only the generic HS48 processor (BR2_archs4x) is supported >> by upstream gcc. >> >> Fixes: >> http://autobuild.buildroot.net/results/357a74d53af96d4b868a9d5b9f9ce9432e0c53b5 >> http://autobuild.buildroot.net/results/bcdf160a3d5ffcccd4402f65aca153faca4b32c2 >> >> Signed-off-by: Romain Naour <romain.naour@gmail.com> >> Cc: ARC Maintainers <arc-buildroot@synopsys.com> >> --- >> package/gcc/Config.in.host | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host >> index f6b9b4fa9d..2b12035c4b 100644 >> --- a/package/gcc/Config.in.host >> +++ b/package/gcc/Config.in.host >> @@ -31,6 +31,8 @@ config BR2_GCC_VERSION_9_X >> # upstream gcc. C-SKY gcc upstream support not tested >> # with upstream binutils and glibc. >> depends on !BR2_csky >> + # ARC HS48 rel 31 only supported by gcc arc fork. >> + depends on !BR2_archs4x_rel31 > > So, in the commit log, you say that BR2_archs4x is the only variant > supported by upstream gcc, yet this change still allows all the hs38 > and the 7x0d variants to use the upstream gcc. I'm only speaking about ARC hs48, not other ARC variant. > > Did I misread the commit log, and you really meant: > > Of the hs48 series, only the generic HS48 processor (BR2_archs4x) is > supported by upstream gcc, while the hs48 rel31 (hs4x_rel31) is not, > and is only suppoerted by the ARC fork. > > All the other variants, 7x0d and hs38, are all supported in upstream > gcc.> > Thoughts? hs4x_rel31 seems the only one not supported by upstream gcc. Best regards, Romain > > Regards, > Yann E. MORIN. > >> select BR2_TOOLCHAIN_GCC_AT_LEAST_9 >> >> config BR2_GCC_VERSION_10_X >> @@ -43,6 +45,8 @@ config BR2_GCC_VERSION_10_X >> # upstream gcc. C-SKY gcc upstream support not tested >> # with upstream binutils and glibc. >> depends on !BR2_csky >> + # ARC HS48 rel 31 only supported by gcc arc fork. >> + depends on !BR2_archs4x_rel31 >> select BR2_TOOLCHAIN_GCC_AT_LEAST_10 >> >> config BR2_GCC_VERSION_11_X >> @@ -54,6 +58,8 @@ config BR2_GCC_VERSION_11_X >> # that need to be reverted since gcc 8.4, 9.3 and 10.1. >> # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98784 >> depends on !BR2_sparc >> + # ARC HS48 rel 31 only supported by gcc arc fork. >> + depends on !BR2_archs4x_rel31 >> select BR2_TOOLCHAIN_GCC_AT_LEAST_11 >> >> endchoice >> -- >> 2.35.3 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot >
Romain, All, On 2022-05-15 21:36 +0200, Romain Naour spake thusly: > ARC hs4x_rel31 cpu is not supported by upstream gcc version. > Only the generic HS48 processor (BR2_archs4x) is supported > by upstream gcc. > > Fixes: > http://autobuild.buildroot.net/results/357a74d53af96d4b868a9d5b9f9ce9432e0c53b5 > http://autobuild.buildroot.net/results/bcdf160a3d5ffcccd4402f65aca153faca4b32c2 > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: ARC Maintainers <arc-buildroot@synopsys.com> Applied to master, after rewording the commit log as we discussed on IRC. Thanks! Regards, Yann E. MORIN. > --- > package/gcc/Config.in.host | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host > index f6b9b4fa9d..2b12035c4b 100644 > --- a/package/gcc/Config.in.host > +++ b/package/gcc/Config.in.host > @@ -31,6 +31,8 @@ config BR2_GCC_VERSION_9_X > # upstream gcc. C-SKY gcc upstream support not tested > # with upstream binutils and glibc. > depends on !BR2_csky > + # ARC HS48 rel 31 only supported by gcc arc fork. > + depends on !BR2_archs4x_rel31 > select BR2_TOOLCHAIN_GCC_AT_LEAST_9 > > config BR2_GCC_VERSION_10_X > @@ -43,6 +45,8 @@ config BR2_GCC_VERSION_10_X > # upstream gcc. C-SKY gcc upstream support not tested > # with upstream binutils and glibc. > depends on !BR2_csky > + # ARC HS48 rel 31 only supported by gcc arc fork. > + depends on !BR2_archs4x_rel31 > select BR2_TOOLCHAIN_GCC_AT_LEAST_10 > > config BR2_GCC_VERSION_11_X > @@ -54,6 +58,8 @@ config BR2_GCC_VERSION_11_X > # that need to be reverted since gcc 8.4, 9.3 and 10.1. > # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98784 > depends on !BR2_sparc > + # ARC HS48 rel 31 only supported by gcc arc fork. > + depends on !BR2_archs4x_rel31 > select BR2_TOOLCHAIN_GCC_AT_LEAST_11 > > endchoice > -- > 2.35.3 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes: > ARC hs4x_rel31 cpu is not supported by upstream gcc version. > Only the generic HS48 processor (BR2_archs4x) is supported > by upstream gcc. > Fixes: > http://autobuild.buildroot.net/results/357a74d53af96d4b868a9d5b9f9ce9432e0c53b5 > http://autobuild.buildroot.net/results/bcdf160a3d5ffcccd4402f65aca153faca4b32c2 > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: ARC Maintainers <arc-buildroot@synopsys.com> Committed to 2022.02.x, thanks.
diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host index f6b9b4fa9d..2b12035c4b 100644 --- a/package/gcc/Config.in.host +++ b/package/gcc/Config.in.host @@ -31,6 +31,8 @@ config BR2_GCC_VERSION_9_X # upstream gcc. C-SKY gcc upstream support not tested # with upstream binutils and glibc. depends on !BR2_csky + # ARC HS48 rel 31 only supported by gcc arc fork. + depends on !BR2_archs4x_rel31 select BR2_TOOLCHAIN_GCC_AT_LEAST_9 config BR2_GCC_VERSION_10_X @@ -43,6 +45,8 @@ config BR2_GCC_VERSION_10_X # upstream gcc. C-SKY gcc upstream support not tested # with upstream binutils and glibc. depends on !BR2_csky + # ARC HS48 rel 31 only supported by gcc arc fork. + depends on !BR2_archs4x_rel31 select BR2_TOOLCHAIN_GCC_AT_LEAST_10 config BR2_GCC_VERSION_11_X @@ -54,6 +58,8 @@ config BR2_GCC_VERSION_11_X # that need to be reverted since gcc 8.4, 9.3 and 10.1. # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98784 depends on !BR2_sparc + # ARC HS48 rel 31 only supported by gcc arc fork. + depends on !BR2_archs4x_rel31 select BR2_TOOLCHAIN_GCC_AT_LEAST_11 endchoice
ARC hs4x_rel31 cpu is not supported by upstream gcc version. Only the generic HS48 processor (BR2_archs4x) is supported by upstream gcc. Fixes: http://autobuild.buildroot.net/results/357a74d53af96d4b868a9d5b9f9ce9432e0c53b5 http://autobuild.buildroot.net/results/bcdf160a3d5ffcccd4402f65aca153faca4b32c2 Signed-off-by: Romain Naour <romain.naour@gmail.com> Cc: ARC Maintainers <arc-buildroot@synopsys.com> --- package/gcc/Config.in.host | 6 ++++++ 1 file changed, 6 insertions(+)