| Message ID | 20220514092152.1625466-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/v4l2loopback: add V4L2LOOPBACK_LINUX_CONFIG_FIXUPS | expand |
Fabrice, All, On 2022-05-14 11:21 +0200, Fabrice Fontaine spake thusly: > Fix the following build failure: > > ERROR: modpost: "video_ioctl2" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "__video_register_device" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "v4l2_ctrl_new_custom" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "v4l2_ctrl_handler_init_class" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "video_device_alloc" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "v4l2_device_register" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "video_device_release" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "v4l2_ctrl_handler_free" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "v4l2_device_unregister" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "video_unregister_device" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > Fixes: > - http://autobuild.buildroot.org/results/640f8f61c7f433ffe5e9a6759eecc9a03f735569 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/v4l2loopback/v4l2loopback.mk | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/package/v4l2loopback/v4l2loopback.mk b/package/v4l2loopback/v4l2loopback.mk > index 7701bc3a30..712088b6b0 100644 > --- a/package/v4l2loopback/v4l2loopback.mk > +++ b/package/v4l2loopback/v4l2loopback.mk > @@ -15,5 +15,10 @@ define V4L2LOOPBACK_INSTALL_TARGET_CMDS > endef > endif > > +define V4L2LOOPBACK_LINUX_CONFIG_FIXUPS > + $(call KCONFIG_ENABLE_OPT,CONFIG_MEDIA_SUPPORT) This one depends on CONFIG_HAS_IOMEM, which is always true, except on s390x (needs PCI) or uml (but we don't support UML). > + $(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV) That one also depends on CONFIG_I2C (which has no dependency). So, maybe: define V4L2LOOPBACK_LINUX_CONFIG_FIXUPS $(if $(BR2_s390x),$(call KCONFIG_ENABLE_OPT,CONFIG_PCI)) $(call KCONFIG_ENABLE_OPT,CONFIG_MEDIA_SUPPORT) $(call KCONFIG_ENABLE_OPT,CONFIG_I2C) $(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV) endef Cordialement, Yann E. MORIN. > +endef > + > $(eval $(kernel-module)) > $(eval $(generic-package)) > -- > 2.35.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Yann, Le sam. 14 mai 2022 à 15:36, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > Fabrice, All, > > On 2022-05-14 11:21 +0200, Fabrice Fontaine spake thusly: > > Fix the following build failure: > > > > ERROR: modpost: "video_ioctl2" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > ERROR: modpost: "__video_register_device" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > ERROR: modpost: "v4l2_ctrl_new_custom" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > ERROR: modpost: "v4l2_ctrl_handler_init_class" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > ERROR: modpost: "video_device_alloc" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > ERROR: modpost: "v4l2_device_register" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > ERROR: modpost: "video_device_release" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > ERROR: modpost: "v4l2_ctrl_handler_free" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > ERROR: modpost: "v4l2_device_unregister" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > ERROR: modpost: "video_unregister_device" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > > > Fixes: > > - http://autobuild.buildroot.org/results/640f8f61c7f433ffe5e9a6759eecc9a03f735569 > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > --- > > package/v4l2loopback/v4l2loopback.mk | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/package/v4l2loopback/v4l2loopback.mk b/package/v4l2loopback/v4l2loopback.mk > > index 7701bc3a30..712088b6b0 100644 > > --- a/package/v4l2loopback/v4l2loopback.mk > > +++ b/package/v4l2loopback/v4l2loopback.mk > > @@ -15,5 +15,10 @@ define V4L2LOOPBACK_INSTALL_TARGET_CMDS > > endef > > endif > > > > +define V4L2LOOPBACK_LINUX_CONFIG_FIXUPS > > + $(call KCONFIG_ENABLE_OPT,CONFIG_MEDIA_SUPPORT) > > This one depends on CONFIG_HAS_IOMEM, which is always true, except on > s390x (needs PCI) or uml (but we don't support UML). > > > + $(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV) > > That one also depends on CONFIG_I2C (which has no dependency). Thanks for your review but I wasn't able to find the CONFIG_I2C dependency in kernel 5.17.7. Here is an extract of drivers/media/Kconfig: config VIDEO_DEV tristate "Video4Linux core" default MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT || MEDIA_PLATFORM_SUPPORT || MEDIA_TEST_SUPPORT > > So, maybe: > > define V4L2LOOPBACK_LINUX_CONFIG_FIXUPS > $(if $(BR2_s390x),$(call KCONFIG_ENABLE_OPT,CONFIG_PCI)) > $(call KCONFIG_ENABLE_OPT,CONFIG_MEDIA_SUPPORT) > $(call KCONFIG_ENABLE_OPT,CONFIG_I2C) > $(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV) > endef > > Cordialement, > Yann E. MORIN. > > > +endef > > + > > $(eval $(kernel-module)) > > $(eval $(generic-package)) > > -- > > 2.35.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' Best Regards, Fabrice
Fabrice, All, On 2022-05-14 15:47 +0200, Fabrice Fontaine spake thusly: > Le sam. 14 mai 2022 à 15:36, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > On 2022-05-14 11:21 +0200, Fabrice Fontaine spake thusly: [--SNIP--] > > > + $(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV) > > That one also depends on CONFIG_I2C (which has no dependency). > > Thanks for your review but I wasn't able to find the CONFIG_I2C > dependency in kernel 5.17.7. > Here is an extract of drivers/media/Kconfig: > > config VIDEO_DEV > tristate "Video4Linux core" > default MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || > MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT || MEDIA_PLATFORM_SUPPORT || > MEDIA_TEST_SUPPORT Ah, that's commit 9958d30f38b96f, which is going to be part of 5.18. Regards, Yann E. MORIN.
On Sat, 14 May 2022 11:21:52 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > Fix the following build failure: > > ERROR: modpost: "video_ioctl2" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "__video_register_device" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "v4l2_ctrl_new_custom" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "v4l2_ctrl_handler_init_class" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "video_device_alloc" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "v4l2_device_register" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "video_device_release" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "v4l2_ctrl_handler_free" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "v4l2_device_unregister" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > ERROR: modpost: "video_unregister_device" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! > > Fixes: > - http://autobuild.buildroot.org/results/640f8f61c7f433ffe5e9a6759eecc9a03f735569 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/v4l2loopback/v4l2loopback.mk | 5 +++++ > 1 file changed, 5 insertions(+) Applied with the fixes suggested by Yann. Thanks! Thomas
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes: > On Sat, 14 May 2022 11:21:52 +0200 > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: >> Fix the following build failure: >> >> ERROR: modpost: "video_ioctl2" >> [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] >> undefined! >> ERROR: modpost: "__video_register_device" >> [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] >> undefined! >> ERROR: modpost: "v4l2_ctrl_new_custom" >> [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] >> undefined! >> ERROR: modpost: "v4l2_ctrl_handler_init_class" >> [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] >> undefined! >> ERROR: modpost: "video_device_alloc" >> [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] >> undefined! >> ERROR: modpost: "v4l2_device_register" >> [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] >> undefined! >> ERROR: modpost: "video_device_release" >> [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] >> undefined! >> ERROR: modpost: "v4l2_ctrl_handler_free" >> [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] >> undefined! >> ERROR: modpost: "v4l2_device_unregister" >> [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] >> undefined! >> ERROR: modpost: "video_unregister_device" >> [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] >> undefined! >> >> Fixes: >> - http://autobuild.buildroot.org/results/640f8f61c7f433ffe5e9a6759eecc9a03f735569 >> >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> >> --- >> package/v4l2loopback/v4l2loopback.mk | 5 +++++ >> 1 file changed, 5 insertions(+) > Applied with the fixes suggested by Yann. Thanks! Committed to 2022.05.x and 2022.02.x, thanks.
diff --git a/package/v4l2loopback/v4l2loopback.mk b/package/v4l2loopback/v4l2loopback.mk index 7701bc3a30..712088b6b0 100644 --- a/package/v4l2loopback/v4l2loopback.mk +++ b/package/v4l2loopback/v4l2loopback.mk @@ -15,5 +15,10 @@ define V4L2LOOPBACK_INSTALL_TARGET_CMDS endef endif +define V4L2LOOPBACK_LINUX_CONFIG_FIXUPS + $(call KCONFIG_ENABLE_OPT,CONFIG_MEDIA_SUPPORT) + $(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV) +endef + $(eval $(kernel-module)) $(eval $(generic-package))
Fix the following build failure: ERROR: modpost: "video_ioctl2" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! ERROR: modpost: "__video_register_device" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! ERROR: modpost: "v4l2_ctrl_new_custom" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! ERROR: modpost: "v4l2_ctrl_handler_init_class" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! ERROR: modpost: "video_device_alloc" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! ERROR: modpost: "v4l2_device_register" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! ERROR: modpost: "video_device_release" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! ERROR: modpost: "v4l2_ctrl_handler_free" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! ERROR: modpost: "v4l2_device_unregister" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! ERROR: modpost: "video_unregister_device" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined! Fixes: - http://autobuild.buildroot.org/results/640f8f61c7f433ffe5e9a6759eecc9a03f735569 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/v4l2loopback/v4l2loopback.mk | 5 +++++ 1 file changed, 5 insertions(+)