diff mbox series

[1/1] package/wpa_supplicant: wired driver needs headers >= 4.6

Message ID 20220511194616.2272499-1-geomatsi@gmail.com
State Accepted
Headers show
Series [1/1] package/wpa_supplicant: wired driver needs headers >= 4.6 | expand

Commit Message

Sergey Matyukevich May 11, 2022, 7:46 p.m. UTC
Wired driver enables macsec support which depends on if_macsec.h.
That header has only been exported since kernel v4.6, see commit:
https://github.com/torvalds/linux/commit/dece8d2b78d19df7fe5e4e965f1f0d1a3e188d1b

Fixes:
- http://autobuild.buildroot.net/results/6bb619eb7fdecf7824fcc549c4ccb8e487665d10/

Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
---
 package/wpa_supplicant/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Yegor Yefremov May 12, 2022, 7:22 a.m. UTC | #1
Hi Sergey,

On Wed, May 11, 2022 at 9:46 PM Sergey Matyukevich <geomatsi@gmail.com> wrote:
>
> Wired driver enables macsec support which depends on if_macsec.h.
> That header has only been exported since kernel v4.6, see commit:
> https://github.com/torvalds/linux/commit/dece8d2b78d19df7fe5e4e965f1f0d1a3e188d1b
>
> Fixes:
> - http://autobuild.buildroot.net/results/6bb619eb7fdecf7824fcc549c4ccb8e487665d10/
>
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

Regards,
Yegor

> ---
>  package/wpa_supplicant/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
> index 7e2432985c..92953f69f0 100644
> --- a/package/wpa_supplicant/Config.in
> +++ b/package/wpa_supplicant/Config.in
> @@ -42,6 +42,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
>  config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
>         bool "Enable wired support"
>         depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
> +       depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
>         select BR2_PACKAGE_LIBNL
>         select BR2_PACKAGE_WPA_SUPPLICANT_EAP
>         help
> @@ -49,6 +50,9 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
>           supplicant can be used with Ethernet.  This also enables
>           support for MACSEC.
>
> +comment "wired macsec support needs a toolchain w/ headers >= 4.6"
> +       depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
> +
>  comment "wired support needs a toolchain w/ threads"
>         depends on !BR2_TOOLCHAIN_HAS_THREADS
>
> --
> 2.35.1
>
Arnout Vandecappelle May 14, 2022, 9:47 a.m. UTC | #2
On 11/05/2022 21:46, Sergey Matyukevich wrote:
> Wired driver enables macsec support which depends on if_macsec.h.
> That header has only been exported since kernel v4.6, see commit:
> https://github.com/torvalds/linux/commit/dece8d2b78d19df7fe5e4e965f1f0d1a3e188d1b
> 
> Fixes:
> - http://autobuild.buildroot.net/results/6bb619eb7fdecf7824fcc549c4ccb8e487665d10/
> 
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/wpa_supplicant/Config.in | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
> index 7e2432985c..92953f69f0 100644
> --- a/package/wpa_supplicant/Config.in
> +++ b/package/wpa_supplicant/Config.in
> @@ -42,6 +42,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
>   config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
>   	bool "Enable wired support"
>   	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
>   	select BR2_PACKAGE_LIBNL
>   	select BR2_PACKAGE_WPA_SUPPLICANT_EAP
>   	help
> @@ -49,6 +50,9 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
>   	  supplicant can be used with Ethernet.  This also enables
>   	  support for MACSEC.
>   
> +comment "wired macsec support needs a toolchain w/ headers >= 4.6"
> +	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
> +
>   comment "wired support needs a toolchain w/ threads"
>   	depends on !BR2_TOOLCHAIN_HAS_THREADS
>
diff mbox series

Patch

diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
index 7e2432985c..92953f69f0 100644
--- a/package/wpa_supplicant/Config.in
+++ b/package/wpa_supplicant/Config.in
@@ -42,6 +42,7 @@  config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
 config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
 	bool "Enable wired support"
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
 	select BR2_PACKAGE_LIBNL
 	select BR2_PACKAGE_WPA_SUPPLICANT_EAP
 	help
@@ -49,6 +50,9 @@  config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
 	  supplicant can be used with Ethernet.  This also enables
 	  support for MACSEC.
 
+comment "wired macsec support needs a toolchain w/ headers >= 4.6"
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
+
 comment "wired support needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS