| Message ID | 20220511110619.1610327-1-foss+buildroot@0leil.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] manual: add _TARGET_FINALIZE_HOOKS in the list of hooks | expand |
Hi all, Any feedback to offer on this patch series? Cheers, Quentin On 5/11/22 13:06, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > While reading the docs to find hooks, I completely missed the > LIBFOO_TARGET_FINALIZE_HOOKS one which was actually matching my > use-case. > > Though it is documented in a subsection a few lines below, let's also > have it in the list of supported hooks so it's not hidden away. > > Cc: Quentin Schulz <foss+buildroot@0leil.net> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> > --- > docs/manual/adding-packages-hooks.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/manual/adding-packages-hooks.txt b/docs/manual/adding-packages-hooks.txt > index 0ce79f8907..741b71ca29 100644 > --- a/docs/manual/adding-packages-hooks.txt > +++ b/docs/manual/adding-packages-hooks.txt > @@ -46,6 +46,8 @@ The following hook points are available: > * +LIBFOO_PRE_LEGAL_INFO_HOOKS+ > * +LIBFOO_POST_LEGAL_INFO_HOOKS+ > > +* +LIBFOO_TARGET_FINALIZE_HOOKS+ > + > These variables are 'lists' of variable names containing actions to be > performed at this hook point. This allows several hooks to be > registered at a given hook point. Here is an example:
Quentin, All, On 2022-05-11 13:06 +0200, Quentin Schulz spake thusly: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > While reading the docs to find hooks, I completely missed the > LIBFOO_TARGET_FINALIZE_HOOKS one which was actually matching my > use-case. > > Though it is documented in a subsection a few lines below, let's also > have it in the list of supported hooks so it's not hidden away. > > Cc: Quentin Schulz <foss+buildroot@0leil.net> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > docs/manual/adding-packages-hooks.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/manual/adding-packages-hooks.txt b/docs/manual/adding-packages-hooks.txt > index 0ce79f8907..741b71ca29 100644 > --- a/docs/manual/adding-packages-hooks.txt > +++ b/docs/manual/adding-packages-hooks.txt > @@ -46,6 +46,8 @@ The following hook points are available: > * +LIBFOO_PRE_LEGAL_INFO_HOOKS+ > * +LIBFOO_POST_LEGAL_INFO_HOOKS+ > > +* +LIBFOO_TARGET_FINALIZE_HOOKS+ > + > These variables are 'lists' of variable names containing actions to be > performed at this hook point. This allows several hooks to be > registered at a given hook point. Here is an example: > -- > 2.35.3 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Quentin" == Quentin Schulz <foss+buildroot@0leil.net> writes: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > While reading the docs to find hooks, I completely missed the > LIBFOO_TARGET_FINALIZE_HOOKS one which was actually matching my > use-case. > Though it is documented in a subsection a few lines below, let's also > have it in the list of supported hooks so it's not hidden away. > Cc: Quentin Schulz <foss+buildroot@0leil.net> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> Committed to 2022.02.x, thanks.
diff --git a/docs/manual/adding-packages-hooks.txt b/docs/manual/adding-packages-hooks.txt index 0ce79f8907..741b71ca29 100644 --- a/docs/manual/adding-packages-hooks.txt +++ b/docs/manual/adding-packages-hooks.txt @@ -46,6 +46,8 @@ The following hook points are available: * +LIBFOO_PRE_LEGAL_INFO_HOOKS+ * +LIBFOO_POST_LEGAL_INFO_HOOKS+ +* +LIBFOO_TARGET_FINALIZE_HOOKS+ + These variables are 'lists' of variable names containing actions to be performed at this hook point. This allows several hooks to be registered at a given hook point. Here is an example: