| Message ID | 20220507202905.397732-4-geomatsi@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xr819-xradio: fixes for autobuild failures | expand |
On 07/05/2022 22:29, Sergey Matyukevich wrote: > The xradio driver is broken for kernel configurations with disabled > power management core functionality (CONFIG_PM). The xradio package > makefile attempts to enable all the required kernel configuration > options, including CONFIG_PM. However certain architectures have > no support for CONFIG_PM. Those are or1k, nios2, csky, and more. > > One possible fix would be to exclude those architectures in the > package Config.in. On the other hand, the xradio driver is rarely > used: orangepi_zero is the only such board in Buildroot. So it > makes sense to keep it simple and enable xradio only for ARM. > Any new xradio users will be considered on a case by case basis. > > Fixes: > - http://autobuild.buildroot.net/results/2ad11cd7a9ca6b694854730e46260a944e8c4bac/ > > Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com> I've applied this one as well, so forget my remark in the previous patch about s390 :-) > --- > package/xr819-xradio/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/xr819-xradio/Config.in b/package/xr819-xradio/Config.in > index 9d7fa4b0f1..351ea95c79 100644 > --- a/package/xr819-xradio/Config.in > +++ b/package/xr819-xradio/Config.in > @@ -1,6 +1,7 @@ > config BR2_PACKAGE_XR819_XRADIO > bool "xr819-xradio" > depends on BR2_LINUX_KERNEL > + depends on BR2_arm aarch64 is likely as well, and why not add the BE variants too... So I added those and applied to master, thanks. Regards, Arnout > help > Wireless driver for SDIO WiFi chip XR819 >
diff --git a/package/xr819-xradio/Config.in b/package/xr819-xradio/Config.in index 9d7fa4b0f1..351ea95c79 100644 --- a/package/xr819-xradio/Config.in +++ b/package/xr819-xradio/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_XR819_XRADIO bool "xr819-xradio" depends on BR2_LINUX_KERNEL + depends on BR2_arm help Wireless driver for SDIO WiFi chip XR819
The xradio driver is broken for kernel configurations with disabled power management core functionality (CONFIG_PM). The xradio package makefile attempts to enable all the required kernel configuration options, including CONFIG_PM. However certain architectures have no support for CONFIG_PM. Those are or1k, nios2, csky, and more. One possible fix would be to exclude those architectures in the package Config.in. On the other hand, the xradio driver is rarely used: orangepi_zero is the only such board in Buildroot. So it makes sense to keep it simple and enable xradio only for ARM. Any new xradio users will be considered on a case by case basis. Fixes: - http://autobuild.buildroot.net/results/2ad11cd7a9ca6b694854730e46260a944e8c4bac/ Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com> --- package/xr819-xradio/Config.in | 1 + 1 file changed, 1 insertion(+)