diff mbox series

package/rtl8188eu: bump to 903b6fc (v5.2.2.4 branch HEAD)

Message ID 20220418142855.3489541-1-tianyuanhao3@163.com
State Accepted
Headers show
Series package/rtl8188eu: bump to 903b6fc (v5.2.2.4 branch HEAD) | expand

Commit Message

TIAN Yuanhao April 18, 2022, 2:28 p.m. UTC
This allows to build against newer kernels (up to 5.18).
Tested on kernel v5.15.

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
---
 package/rtl8188eu/rtl8188eu.hash | 2 +-
 package/rtl8188eu/rtl8188eu.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Petr Vorel April 18, 2022, 4:59 p.m. UTC | #1
Hi TIAN,

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Good point. But maybe instead of 903b6fc a previous commit
13531f3 ("rtl8188eu: Fix build for kernel 5.18")
would be enough, because 903b6fc just vendors hostapd-2.9,
which we don't need atm.

Kind regards,
Petr
Arnout Vandecappelle April 19, 2022, 8:35 p.m. UTC | #2
On 18/04/2022 16:28, TIAN Yuanhao wrote:
> This allows to build against newer kernels (up to 5.18).
> Tested on kernel v5.15.
> 
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/rtl8188eu/rtl8188eu.hash | 2 +-
>   package/rtl8188eu/rtl8188eu.mk   | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/rtl8188eu/rtl8188eu.hash b/package/rtl8188eu/rtl8188eu.hash
> index 37767f5d16..9c7f2de4b6 100644
> --- a/package/rtl8188eu/rtl8188eu.hash
> +++ b/package/rtl8188eu/rtl8188eu.hash
> @@ -1,3 +1,3 @@
>   # Locally computed
> -sha256  b2b06c842bccd730d68a26b1c1b5a24f18373401e907147bf5e775fa42a36bbb  rtl8188eu-60cb0b5a3cfc95e3f2e6fc294a28d987096b0559.tar.gz
> +sha256  6bc46a13b20a2ed121844e51fd690216b2ab3b1faa1af8d9501090026ca9bd22  rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90.tar.gz
>   sha256  af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7  COPYING
> diff --git a/package/rtl8188eu/rtl8188eu.mk b/package/rtl8188eu/rtl8188eu.mk
> index b2066080f3..fa420b0d57 100644
> --- a/package/rtl8188eu/rtl8188eu.mk
> +++ b/package/rtl8188eu/rtl8188eu.mk
> @@ -4,7 +4,7 @@
>   #
>   ################################################################################
>   
> -RTL8188EU_VERSION = 60cb0b5a3cfc95e3f2e6fc294a28d987096b0559
> +RTL8188EU_VERSION = 903b6fcb821465fe9c63e83416080df70c1c3c90
>   RTL8188EU_SITE = $(call github,lwfinger,rtl8188eu,$(RTL8188EU_VERSION))
>   RTL8188EU_LICENSE = GPL-2.0, proprietary (rtl8188eufw.bin firmware blob)
>   RTL8188EU_LICENSE_FILES = COPYING
Luca Ceresoli May 4, 2022, 9:44 a.m. UTC | #3
Hi TIAN,

On 19/04/22 22:35, Arnout Vandecappelle wrote:
> 
> 
> On 18/04/2022 16:28, TIAN Yuanhao wrote:
>> This allows to build against newer kernels (up to 5.18).
>> Tested on kernel v5.15.
>>
>> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> 
>  Applied to master, thanks.

We are seeing new build failures since this patch has been applied. Can
you have a look?

The full list:

http://autobuild.buildroot.org/index.php?reason=rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90

Some examples:

http://autobuild.buildroot.org/results/951/9514704d6d44fc1b5dd188eac06b269427d3dee2//

http://autobuild.buildroot.org/results/9ea/9ea060cc35e859ebc73c65fe2d1f7478f9b4fa8d/

http://autobuild.buildroot.org/results/658/658c06f8125613b56511d3351cdfd3d8e19d48da//

FYI, at the end of the http://autobuild.buildroot.org/ page there is a
link to a "Script to reproduce a build" that is quite handy to reproduce
the problem locally in order to debug it.

Thank you!
TIAN Yuanhao May 6, 2022, 3:14 p.m. UTC | #4
Hi Luca,

On 5/4/22 02:44, Luca Ceresoli wrote:
> Hi TIAN,
>
> On 19/04/22 22:35, Arnout Vandecappelle wrote:
>>
>> On 18/04/2022 16:28, TIAN Yuanhao wrote:
>>> This allows to build against newer kernels (up to 5.18).
>>> Tested on kernel v5.15.
>>>
>>> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
>>   Applied to master, thanks.
> We are seeing new build failures since this patch has been applied. Can
> you have a look?
>
Confirmed, the build failed because the kernel config was missing 
CONFIG_CFG80211.

> The full list:
>
> http://autobuild.buildroot.org/index.php?reason=rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90
>
> Some examples:
>
> http://autobuild.buildroot.org/results/951/9514704d6d44fc1b5dd188eac06b269427d3dee2//
>
> http://autobuild.buildroot.org/results/9ea/9ea060cc35e859ebc73c65fe2d1f7478f9b4fa8d/
>
> http://autobuild.buildroot.org/results/658/658c06f8125613b56511d3351cdfd3d8e19d48da//
>
> FYI, at the end of the http://autobuild.buildroot.org/ page there is a
> link to a "Script to reproduce a build" that is quite handy to reproduce
> the problem locally in order to debug it.
>
> Thank you!
Luca Ceresoli May 8, 2022, 2:43 p.m. UTC | #5
Hi Tian,

On 06/05/22 17:14, TIAN Yuanhao wrote:
> Hi Luca,
> 
> On 5/4/22 02:44, Luca Ceresoli wrote:
>> Hi TIAN,
>>
>> On 19/04/22 22:35, Arnout Vandecappelle wrote:
>>>
>>> On 18/04/2022 16:28, TIAN Yuanhao wrote:
>>>> This allows to build against newer kernels (up to 5.18).
>>>> Tested on kernel v5.15.
>>>>
>>>> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
>>>   Applied to master, thanks.
>> We are seeing new build failures since this patch has been applied. Can
>> you have a look?
>>
> Confirmed, the build failed because the kernel config was missing
> CONFIG_CFG80211.

Oh, sure. Then it should be fixed by adding "CONFIG_CFG80211=y" to
RTL8188EU_MODULE_MAKE_OPTS. Can you try that please, and send a fix
patch. if it works?

Thank you!
diff mbox series

Patch

diff --git a/package/rtl8188eu/rtl8188eu.hash b/package/rtl8188eu/rtl8188eu.hash
index 37767f5d16..9c7f2de4b6 100644
--- a/package/rtl8188eu/rtl8188eu.hash
+++ b/package/rtl8188eu/rtl8188eu.hash
@@ -1,3 +1,3 @@ 
 # Locally computed
-sha256  b2b06c842bccd730d68a26b1c1b5a24f18373401e907147bf5e775fa42a36bbb  rtl8188eu-60cb0b5a3cfc95e3f2e6fc294a28d987096b0559.tar.gz
+sha256  6bc46a13b20a2ed121844e51fd690216b2ab3b1faa1af8d9501090026ca9bd22  rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90.tar.gz
 sha256  af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7  COPYING
diff --git a/package/rtl8188eu/rtl8188eu.mk b/package/rtl8188eu/rtl8188eu.mk
index b2066080f3..fa420b0d57 100644
--- a/package/rtl8188eu/rtl8188eu.mk
+++ b/package/rtl8188eu/rtl8188eu.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-RTL8188EU_VERSION = 60cb0b5a3cfc95e3f2e6fc294a28d987096b0559
+RTL8188EU_VERSION = 903b6fcb821465fe9c63e83416080df70c1c3c90
 RTL8188EU_SITE = $(call github,lwfinger,rtl8188eu,$(RTL8188EU_VERSION))
 RTL8188EU_LICENSE = GPL-2.0, proprietary (rtl8188eufw.bin firmware blob)
 RTL8188EU_LICENSE_FILES = COPYING