diff mbox series

[v1] package/qt5base: fix eglconvenience compile (missing QList include)

Message ID 20220316182440.17393-1-ps.report@gmx.net
State Accepted
Headers show
Series [v1] package/qt5base: fix eglconvenience compile (missing QList include) | expand

Commit Message

Peter Seiderer March 16, 2022, 6:24 p.m. UTC
- add 0008-eglconvenience-add-missing-QList-include.patch to fix
  eglconvenience compile (missing QList include)

Fixes:

  qeglconvenience.cpp:418:23: error: variable ‘QList<QByteArray> extensions’ has initializer but incomplete type
    418 |     QList<QByteArray> extensions =
        |                       ^~~~~~~~~~
  qeglconvenience.cpp:420:65: error: invalid use of incomplete type ‘class QList<QByteArray>’
    420 |             (eglQueryString(display, EGL_EXTENSIONS))).split(' ');
        |                                                                 ^

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 ...onvenience-add-missing-QList-include.patch | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch

Comments

Arnout Vandecappelle March 24, 2022, 9:43 p.m. UTC | #1
On 16/03/2022 19:24, Peter Seiderer wrote:
> - add 0008-eglconvenience-add-missing-QList-include.patch to fix
>    eglconvenience compile (missing QList include)
> 
> Fixes:
> 
>    qeglconvenience.cpp:418:23: error: variable ‘QList<QByteArray> extensions’ has initializer but incomplete type
>      418 |     QList<QByteArray> extensions =
>          |                       ^~~~~~~~~~
>    qeglconvenience.cpp:420:65: error: invalid use of incomplete type ‘class QList<QByteArray>’
>      420 |             (eglQueryString(display, EGL_EXTENSIONS))).split(' ');
>          |                                                                 ^
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>   ...onvenience-add-missing-QList-include.patch | 37 +++++++++++++++++++
>   1 file changed, 37 insertions(+)
>   create mode 100644 package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch
> 
> diff --git a/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch b/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch
> new file mode 100644
> index 0000000000..c7127291e4
> --- /dev/null
> +++ b/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch

  There was already a patch 0008. However, I merged another commit that removed 
patch 0006, and renumbered them, so no your patch is 0008 :-)

  Applied to master, thanks.

  Regards,
  Arnout


> @@ -0,0 +1,37 @@
> +From f681f428477812e54484f631b0da332cc2e00eaa Mon Sep 17 00:00:00 2001
> +From: Peter Seiderer <ps.report@gmx.net>
> +Date: Wed, 16 Mar 2022 19:08:55 +0100
> +Subject: [PATCH] eglconvenience: add missing QList include
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Fixes:
> +
> +  qeglconvenience.cpp:418:23: error: variable ‘QList<QByteArray> extensions’ has initializer but incomplete type
> +    418 |     QList<QByteArray> extensions =
> +        |                       ^~~~~~~~~~
> +  qeglconvenience.cpp:420:65: error: invalid use of incomplete type ‘class QList<QByteArray>’
> +    420 |             (eglQueryString(display, EGL_EXTENSIONS))).split(' ');
> +        |                                                                 ^
> +
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +---
> + src/platformsupport/eglconvenience/qeglconvenience.cpp | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/src/platformsupport/eglconvenience/qeglconvenience.cpp b/src/platformsupport/eglconvenience/qeglconvenience.cpp
> +index 5303d37c..daceeb8b 100644
> +--- a/src/platformsupport/eglconvenience/qeglconvenience.cpp
> ++++ b/src/platformsupport/eglconvenience/qeglconvenience.cpp
> +@@ -38,6 +38,7 @@
> + ****************************************************************************/
> +
> + #include <QByteArray>
> ++#include <QList>
> + #include <QOpenGLContext>
> +
> + #ifdef Q_OS_LINUX
> +--
> +2.35.1
> +
Peter Korsgaard March 30, 2022, 7:13 a.m. UTC | #2
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > - add 0008-eglconvenience-add-missing-QList-include.patch to fix
 >   eglconvenience compile (missing QList include)

 > Fixes:

 >   qeglconvenience.cpp:418:23: error: variable ‘QList<QByteArray> extensions’ has initializer but incomplete type
 >     418 |     QList<QByteArray> extensions =
 >         |                       ^~~~~~~~~~
 >   qeglconvenience.cpp:420:65: error: invalid use of incomplete type ‘class QList<QByteArray>’
 >     420 |             (eglQueryString(display, EGL_EXTENSIONS))).split(' ');
 >         |                                                                 ^

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Committed to 2022.02.x, thanks.
diff mbox series

Patch

diff --git a/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch b/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch
new file mode 100644
index 0000000000..c7127291e4
--- /dev/null
+++ b/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch
@@ -0,0 +1,37 @@ 
+From f681f428477812e54484f631b0da332cc2e00eaa Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Wed, 16 Mar 2022 19:08:55 +0100
+Subject: [PATCH] eglconvenience: add missing QList include
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes:
+
+  qeglconvenience.cpp:418:23: error: variable ‘QList<QByteArray> extensions’ has initializer but incomplete type
+    418 |     QList<QByteArray> extensions =
+        |                       ^~~~~~~~~~
+  qeglconvenience.cpp:420:65: error: invalid use of incomplete type ‘class QList<QByteArray>’
+    420 |             (eglQueryString(display, EGL_EXTENSIONS))).split(' ');
+        |                                                                 ^
+
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ src/platformsupport/eglconvenience/qeglconvenience.cpp | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/platformsupport/eglconvenience/qeglconvenience.cpp b/src/platformsupport/eglconvenience/qeglconvenience.cpp
+index 5303d37c..daceeb8b 100644
+--- a/src/platformsupport/eglconvenience/qeglconvenience.cpp
++++ b/src/platformsupport/eglconvenience/qeglconvenience.cpp
+@@ -38,6 +38,7 @@
+ ****************************************************************************/
+ 
+ #include <QByteArray>
++#include <QList>
+ #include <QOpenGLContext>
+ 
+ #ifdef Q_OS_LINUX
+-- 
+2.35.1
+