| Message ID | 20220221140628.2295-1-abrodkin@synopsys.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/qt5: enable for ARC | expand |
On 21/02/2022 15:06, Alexey Brodkin via buildroot wrote: > Double-conversion got pulled-in Qt's sources from the upstream project > quite some time ago [1], so now Qt5 is buildable for ARC perfectly fine. > > This reverts the last part of [2], > commit e453fb9e3280 (qt5: disable qt-5.8.0 support for arc, nios2 and xtensa). > > [1] https://invent.kde.org/qt/qt/qtbase/-/commit/425df43d7fed19866fc7ceb3d26b6cc4190523f5 > [2] https://git.buildroot.net/buildroot/commit/?id=e453fb9e3280a1a1ce6180e165aab9c4f1642555 > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Cc: Peter Seiderer <ps.report@gmx.net> Applied to master, thanks. There may be some qt5 packages that still don't build on ARC, but I guess the autobuilders will tell us. Also without JS support, half of qt5 is still not available... Regards, Arnout > --- > package/qt5/Config.in | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/package/qt5/Config.in b/package/qt5/Config.in > index 8557fd1000..cbb2e06a21 100644 > --- a/package/qt5/Config.in > +++ b/package/qt5/Config.in > @@ -13,7 +13,6 @@ config BR2_PACKAGE_QT5_JSCORE_AVAILABLE > > comment "Qt5 needs host g++ >= 5.0, and a toolchain w/ gcc >= 5.0, wchar, NPTL, C++, dynamic library" > depends on !BR2_ARM_CPU_ARMV4 > - depends on !BR2_arc > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ > !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS || \ > !BR2_HOST_GCC_AT_LEAST_5 || !BR2_TOOLCHAIN_GCC_AT_LEAST_5 > @@ -26,8 +25,6 @@ menuconfig BR2_PACKAGE_QT5 > depends on BR2_HOST_GCC_AT_LEAST_5 # Full C++11 > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++11, GCC_BUG_57694 > depends on !BR2_ARM_CPU_ARMV4 # needs ARMv5+ > - # no built-in double-conversion support > - depends on !BR2_arc > depends on !BR2_STATIC_LIBS > select BR2_PACKAGE_QT5BASE > help
diff --git a/package/qt5/Config.in b/package/qt5/Config.in index 8557fd1000..cbb2e06a21 100644 --- a/package/qt5/Config.in +++ b/package/qt5/Config.in @@ -13,7 +13,6 @@ config BR2_PACKAGE_QT5_JSCORE_AVAILABLE comment "Qt5 needs host g++ >= 5.0, and a toolchain w/ gcc >= 5.0, wchar, NPTL, C++, dynamic library" depends on !BR2_ARM_CPU_ARMV4 - depends on !BR2_arc depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS || \ !BR2_HOST_GCC_AT_LEAST_5 || !BR2_TOOLCHAIN_GCC_AT_LEAST_5 @@ -26,8 +25,6 @@ menuconfig BR2_PACKAGE_QT5 depends on BR2_HOST_GCC_AT_LEAST_5 # Full C++11 depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++11, GCC_BUG_57694 depends on !BR2_ARM_CPU_ARMV4 # needs ARMv5+ - # no built-in double-conversion support - depends on !BR2_arc depends on !BR2_STATIC_LIBS select BR2_PACKAGE_QT5BASE help
Double-conversion got pulled-in Qt's sources from the upstream project quite some time ago [1], so now Qt5 is buildable for ARC perfectly fine. This reverts the last part of [2], commit e453fb9e3280 (qt5: disable qt-5.8.0 support for arc, nios2 and xtensa). [1] https://invent.kde.org/qt/qt/qtbase/-/commit/425df43d7fed19866fc7ceb3d26b6cc4190523f5 [2] https://git.buildroot.net/buildroot/commit/?id=e453fb9e3280a1a1ce6180e165aab9c4f1642555 Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Cc: Peter Seiderer <ps.report@gmx.net> --- package/qt5/Config.in | 3 --- 1 file changed, 3 deletions(-)