| Message ID | 20220129111731.736265-1-peron.clem@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v2,1/2] configs/beelink_gs1: increase rootfs size to 120M | expand |
On Sat, 29 Jan 2022 12:17:30 +0100 Clément Péron <peron.clem@gmail.com> wrote: > For the moment Beelink GS1 use a default rootfs size of 60M, > which is a bit low if you want to add some packages like a > graphic stack. > > Increase the rootfs size to 120M. > > Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > Signed-off-by: Clément Péron <peron.clem@gmail.com> > --- > configs/beelink_gs1_defconfig | 1 + > 1 file changed, 1 insertion(+) I have not applied this one. Indeed, any defconfig that uses the default rootfs size of 60M would have the problem of "if I add more packages, it doesn't fit in the image". The defconfigs are meant to be minimal, so it doesn't make sense to increase the size to 120M to accommodate some possible package additions. Maybe even 120M is not going to be enough depending on how many packages you add (and how large they are). So I've marked this patch as Rejected. Thomas
Hi Thomas, On Sun, 30 Jan 2022 at 18:18, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Sat, 29 Jan 2022 12:17:30 +0100 > Clément Péron <peron.clem@gmail.com> wrote: > > > For the moment Beelink GS1 use a default rootfs size of 60M, > > which is a bit low if you want to add some packages like a > > graphic stack. > > > > Increase the rootfs size to 120M. > > > > Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > configs/beelink_gs1_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > I have not applied this one. Indeed, any defconfig that uses the > default rootfs size of 60M would have the problem of "if I add more > packages, it doesn't fit in the image". The defconfigs are meant to be > minimal, so it doesn't make sense to increase the size to 120M to > accommodate some possible package additions. Maybe even 120M is not > going to be enough depending on how many packages you add (and how > large they are). Ok, Thanks for the explanation > > So I've marked this patch as Rejected. > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
diff --git a/configs/beelink_gs1_defconfig b/configs/beelink_gs1_defconfig index e88f3e3b69..1872aabdf0 100644 --- a/configs/beelink_gs1_defconfig +++ b/configs/beelink_gs1_defconfig @@ -24,6 +24,7 @@ BR2_PACKAGE_AUTOSSH=y BR2_PACKAGE_DROPBEAR=y BR2_TARGET_ROOTFS_EXT2=y BR2_TARGET_ROOTFS_EXT2_4=y +BR2_TARGET_ROOTFS_EXT2_SIZE="120M" # Firmware BR2_TARGET_ARM_TRUSTED_FIRMWARE=y