| Message ID | 20220124100920.3005564-1-giulio.benetti@benettiengineering.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | package/efl: fix build failure with eeze disabled | expand |
On 24/01/2022 11:09, Giulio Benetti wrote: > Elput depends on eeze, so if we disable eeze we also need to disable elput > by setting the option "input" to false. > > Fixes: > https://bugs.busybox.net/show_bug.cgi?id=14531 There are two other patches that somehow deal with this issue [1][2] in addition to this one [3]. Could someone choose between the and mark the rest as Superseded in patchwork? Regards, Arnout [1] https://patchwork.ozlabs.org/project/buildroot/patch/20211230221904.3064022-1-fontaine.fabrice@gmail.com/ [2] https://patchwork.ozlabs.org/project/buildroot/patch/20220129224651.1282263-4-romain.naour@gmail.com/ [3] https://patchwork.ozlabs.org/project/buildroot/patch/20220124100920.3005564-1-giulio.benetti@benettiengineering.com/ > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/efl/efl.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/efl/efl.mk b/package/efl/efl.mk > index ed0a8acc1d..c93961475d 100644 > --- a/package/efl/efl.mk > +++ b/package/efl/efl.mk > @@ -65,6 +65,8 @@ EFL_DEPENDENCIES += udev > EFL_CONF_OPTS += -Deeze=true > else > EFL_CONF_OPTS += -Deeze=false > +# input(elput) requires eeze, so disable it accordingly > +EFL_CONF_OPTS += -Dinput=false > endif > > ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y)
Hi Arnout, > Il giorno 1 feb 2022, alle ore 22:53, Arnout Vandecappelle <arnout@mind.be> ha scritto: > > > >> On 24/01/2022 11:09, Giulio Benetti wrote: >> Elput depends on eeze, so if we disable eeze we also need to disable elput >> by setting the option "input" to false. >> Fixes: >> https://bugs.busybox.net/show_bug.cgi?id=14531 > > There are two other patches that somehow deal with this issue [1][2] in addition to this one [3]. > > Could someone choose between the and mark the rest as Superseded in patchwork? Fabrice commented on mine that mine was better. Then the Romain one came out few days ago and I can tell his one is better. So I would go for the Romain patch. I set mine as superseded and Fabrice can do the before. Best regards Giulio > > > Regards, > Arnout > > [1] https://patchwork.ozlabs.org/project/buildroot/patch/20211230221904.3064022-1-fontaine.fabrice@gmail.com/ > [2] https://patchwork.ozlabs.org/project/buildroot/patch/20220129224651.1282263-4-romain.naour@gmail.com/ > [3] https://patchwork.ozlabs.org/project/buildroot/patch/20220124100920.3005564-1-giulio.benetti@benettiengineering.com/ > > >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- >> package/efl/efl.mk | 2 ++ >> 1 file changed, 2 insertions(+) >> diff --git a/package/efl/efl.mk b/package/efl/efl.mk >> index ed0a8acc1d..c93961475d 100644 >> --- a/package/efl/efl.mk >> +++ b/package/efl/efl.mk >> @@ -65,6 +65,8 @@ EFL_DEPENDENCIES += udev >> EFL_CONF_OPTS += -Deeze=true >> else >> EFL_CONF_OPTS += -Deeze=false >> +# input(elput) requires eeze, so disable it accordingly >> +EFL_CONF_OPTS += -Dinput=false >> endif >> ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y) > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Hi, Le mar. 1 févr. 2022 à 23:02, Giulio Benetti <giulio.benetti@benettiengineering.com> a écrit : > > Hi Arnout, > > > Il giorno 1 feb 2022, alle ore 22:53, Arnout Vandecappelle <arnout@mind.be> ha scritto: > > > > > > > >> On 24/01/2022 11:09, Giulio Benetti wrote: > >> Elput depends on eeze, so if we disable eeze we also need to disable elput > >> by setting the option "input" to false. > >> Fixes: > >> https://bugs.busybox.net/show_bug.cgi?id=14531 > > > > There are two other patches that somehow deal with this issue [1][2] in addition to this one [3]. > > > > Could someone choose between the and mark the rest as Superseded in patchwork? > > Fabrice commented on mine that mine was better. > Then the Romain one came out few days ago and I can tell his one is better. > > So I would go for the Romain patch. > > I set mine as superseded and Fabrice can do the before. I also set mine as superseded. > > Best regards > Giulio > > > > > > > Regards, > > Arnout > > > > [1] https://patchwork.ozlabs.org/project/buildroot/patch/20211230221904.3064022-1-fontaine.fabrice@gmail.com/ > > [2] https://patchwork.ozlabs.org/project/buildroot/patch/20220129224651.1282263-4-romain.naour@gmail.com/ > > [3] https://patchwork.ozlabs.org/project/buildroot/patch/20220124100920.3005564-1-giulio.benetti@benettiengineering.com/ > > > > > >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > >> --- > >> package/efl/efl.mk | 2 ++ > >> 1 file changed, 2 insertions(+) > >> diff --git a/package/efl/efl.mk b/package/efl/efl.mk > >> index ed0a8acc1d..c93961475d 100644 > >> --- a/package/efl/efl.mk > >> +++ b/package/efl/efl.mk > >> @@ -65,6 +65,8 @@ EFL_DEPENDENCIES += udev > >> EFL_CONF_OPTS += -Deeze=true > >> else > >> EFL_CONF_OPTS += -Deeze=false > >> +# input(elput) requires eeze, so disable it accordingly > >> +EFL_CONF_OPTS += -Dinput=false > >> endif > >> ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y) > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot > Best Regards, Fabrice
diff --git a/package/efl/efl.mk b/package/efl/efl.mk index ed0a8acc1d..c93961475d 100644 --- a/package/efl/efl.mk +++ b/package/efl/efl.mk @@ -65,6 +65,8 @@ EFL_DEPENDENCIES += udev EFL_CONF_OPTS += -Deeze=true else EFL_CONF_OPTS += -Deeze=false +# input(elput) requires eeze, so disable it accordingly +EFL_CONF_OPTS += -Dinput=false endif ifeq ($(BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT),y)
Elput depends on eeze, so if we disable eeze we also need to disable elput by setting the option "input" to false. Fixes: https://bugs.busybox.net/show_bug.cgi?id=14531 Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/efl/efl.mk | 2 ++ 1 file changed, 2 insertions(+)