| Message ID | 20211226184919.2753591-5-ricardo.martincoski@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | check-package for SysV init scripts (including shellcheck) | expand |
Hello Ricardo, Acked-by: Romain Naour <romain.naour@smile.fr> Best regards, Romain Le 26/12/2021 à 19:49, Ricardo Martincoski a écrit : > Allow developers to run check-package for init scripts, that call > shellcheck, without having to install the tool. > > Since the docker have a fixed version of the tool, there will be no > difference between runs in different machines. > > One can call: > $ utils/docker-run utils/check-package package/package/S* > $ utils/docker-run shellcheck package/package/S* > > This change also allows to eventually run check-package for init scripts > in the GitLab CI. > > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> > --- > Please read the cover letter before applying. > --- > support/docker/Dockerfile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile > index 792e70e292..2b14f0f7a7 100644 > --- a/support/docker/Dockerfile > +++ b/support/docker/Dockerfile > @@ -44,6 +44,7 @@ RUN apt-get install -y --no-install-recommends \ > qemu-system-arm \ > qemu-system-x86 \ > rsync \ > + shellcheck \ > subversion \ > unzip \ > wget \ >
diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile index 792e70e292..2b14f0f7a7 100644 --- a/support/docker/Dockerfile +++ b/support/docker/Dockerfile @@ -44,6 +44,7 @@ RUN apt-get install -y --no-install-recommends \ qemu-system-arm \ qemu-system-x86 \ rsync \ + shellcheck \ subversion \ unzip \ wget \
Allow developers to run check-package for init scripts, that call shellcheck, without having to install the tool. Since the docker have a fixed version of the tool, there will be no difference between runs in different machines. One can call: $ utils/docker-run utils/check-package package/package/S* $ utils/docker-run shellcheck package/package/S* This change also allows to eventually run check-package for init scripts in the GitLab CI. Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> --- Please read the cover letter before applying. --- support/docker/Dockerfile | 1 + 1 file changed, 1 insertion(+)