Message ID | 20211125155040.90840-1-kory.maincent@bootlin.com |
---|---|
State | Changes Requested |
Headers | show |
Series | package/rkdeveloptool: add new package | expand |
Hi Köry, On Thu, Nov 25, 2021 at 04:50:40PM +0100, Kory Maincent wrote: > This package is a tool from Rockchip to communicate with Rockusb devices. > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > --- > DEVELOPERS | 3 +++ > package/Config.in.host | 1 + > package/rkdeveloptool/Config.in.host | 7 +++++++ > package/rkdeveloptool/rkdeveloptool.mk | 15 +++++++++++++++ > 4 files changed, 26 insertions(+) > create mode 100644 package/rkdeveloptool/Config.in.host > create mode 100644 package/rkdeveloptool/rkdeveloptool.mk > > diff --git a/DEVELOPERS b/DEVELOPERS > index b190c0f356..b92727a3f5 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -1562,6 +1562,9 @@ N: Koen Martens <gmc@sonologic.nl> > F: package/capnproto/ > F: package/linuxconsoletools/ > > +N: Köry Maincent <kory.maincent@bootlin.com> > +F: package/rkdeveloptool/ > + > N: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> > F: package/bcusdk/ > F: package/libpthsem/ > diff --git a/package/Config.in.host b/package/Config.in.host > index 6e5a5c5fc5..dfdd4c3eb1 100644 > --- a/package/Config.in.host > +++ b/package/Config.in.host > @@ -76,6 +76,7 @@ menu "Host utilities" > source "package/qoriq-rcw/Config.in.host" > source "package/raspberrypi-usbboot/Config.in.host" > source "package/rauc/Config.in.host" > + source "package/rkdeveloptool/Config.in.host" > source "package/rustc/Config.in.host" > source "package/s6-rc/Config.in.host" > source "package/sam-ba/Config.in.host" > diff --git a/package/rkdeveloptool/Config.in.host b/package/rkdeveloptool/Config.in.host > new file mode 100644 > index 0000000000..c5af34510d > --- /dev/null > +++ b/package/rkdeveloptool/Config.in.host > @@ -0,0 +1,7 @@ > +config BR2_PACKAGE_HOST_RKDEVELOPTOOL > + bool "host rkdeveloptool" > + help > + rkdeveloptool gives you a simple way to read/write rockusb > + devices. > + > + https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rockchip-2Dlinux_rkdeveloptool&d=DwIGaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=n5eBBRFXU6Fd9z7euAAt8lQcSXD_gx0NejtlfudGc6ABGfTrEYVwVjfWd7jqfDDo&s=SOxg93OG8XbLFuec6FWRdGDRNly00jjChoJL1CWYCPE&e= > diff --git a/package/rkdeveloptool/rkdeveloptool.mk b/package/rkdeveloptool/rkdeveloptool.mk > new file mode 100644 > index 0000000000..2345dcefc0 > --- /dev/null > +++ b/package/rkdeveloptool/rkdeveloptool.mk > @@ -0,0 +1,15 @@ > +################################################################################ > +# > +# rkdeveloptool > +# > +################################################################################ > + > +RKDEVELOPTOOL_VERSION = 46bb4c073624226c3f05b37b9ecc50bbcf543f5a > +RKDEVELOPTOOL_SITE = $(call github,rockchip-linux,rkdeveloptool,$(RKDEVELOPTOOL_VERSION)) > +RKDEVELOPTOOL_LICENSE = GPL2 > +RKDEVELOPTOOL_LICENSE_FILES = license.txt > +HOST_RKDEVELOPTOOL_DEPENDENCIES = host-libusb > + Isn't it missing the host-eudev? I had it in my local package that I forgot to upstream. I assume building it in a minimal container would give us the answer. c.f. https://github.com/rockchip-linux/rkdeveloptool/blob/master/Readme.txt#L4-L5 Otherwise, I had the same for everything else. By the way, no .hash in this patch.. Is this expected/okay? Otherwise, looks good :) Cheers, Quentin
Hello Quentin, Thanks for the review! On Mon, 29 Nov 2021 11:03:58 +0100 Quentin Schulz <quentin.schulz@theobroma-systems.com> wrote: > > +RKDEVELOPTOOL_VERSION = 46bb4c073624226c3f05b37b9ecc50bbcf543f5a > > +RKDEVELOPTOOL_SITE = $(call > > github,rockchip-linux,rkdeveloptool,$(RKDEVELOPTOOL_VERSION)) > > +RKDEVELOPTOOL_LICENSE = GPL2 +RKDEVELOPTOOL_LICENSE_FILES = license.txt > > +HOST_RKDEVELOPTOOL_DEPENDENCIES = host-libusb > > + > > Isn't it missing the host-eudev? I had it in my local package that I > forgot to upstream. I assume building it in a minimal container would > give us the answer. > > c.f. > https://github.com/rockchip-linux/rkdeveloptool/blob/master/Readme.txt#L4-L5 It built in a minimal Ubuntu docker without libudev-dev. Maybe a runtime dependency, but libudev is installed in most of desktop distribution, right? > > Otherwise, I had the same for everything else. > > By the way, no .hash in this patch.. Is this expected/okay? Oops, a mere oversight! Regards, Köry
Hello Köry, On Thu, 25 Nov 2021 16:50:40 +0100 Kory Maincent <kory.maincent@bootlin.com> wrote: > This package is a tool from Rockchip to communicate with Rockusb devices. > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> Thanks for this tool. I confirm that it builds fine with a container that doesn't have udev development files installed. However, when I run it, nothing happens: $ ./host/bin/rkdeveloptool $ ./host/bin/rkdeveloptool --help $ ./host/bin/rkdeveloptool -h $ ./host/bin/rkdeveloptool -v Also, another problem is that it doesn't build with gcc 11.x: main.cpp: In function ‘bool _Z9mergeBootv.part.0()’: main.cpp:1493:43: error: ‘%s’ directive output may be truncated writing up to 557 bytes into a region of size 5 [-Werror=format-truncation=] 1493 | snprintf(buffer, sizeof(buffer), "%s", chip); | ^~ ...... 1534 | chipType = convertChipType(chip + 2); | ~~~~~~~~~~~~~~~~~~~~~~~~~ main.cpp:1493:17: note: ‘snprintf’ output between 1 and 558 bytes into a destination of size 5 1493 | snprintf(buffer, sizeof(buffer), "%s", chip); | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors make[2]: *** [Makefile:495: main.o] Error 1 Could you fix these issues, as well as add the license file hash as spotted by Quentin ? Thanks! Thomas
diff --git a/DEVELOPERS b/DEVELOPERS index b190c0f356..b92727a3f5 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -1562,6 +1562,9 @@ N: Koen Martens <gmc@sonologic.nl> F: package/capnproto/ F: package/linuxconsoletools/ +N: Köry Maincent <kory.maincent@bootlin.com> +F: package/rkdeveloptool/ + N: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> F: package/bcusdk/ F: package/libpthsem/ diff --git a/package/Config.in.host b/package/Config.in.host index 6e5a5c5fc5..dfdd4c3eb1 100644 --- a/package/Config.in.host +++ b/package/Config.in.host @@ -76,6 +76,7 @@ menu "Host utilities" source "package/qoriq-rcw/Config.in.host" source "package/raspberrypi-usbboot/Config.in.host" source "package/rauc/Config.in.host" + source "package/rkdeveloptool/Config.in.host" source "package/rustc/Config.in.host" source "package/s6-rc/Config.in.host" source "package/sam-ba/Config.in.host" diff --git a/package/rkdeveloptool/Config.in.host b/package/rkdeveloptool/Config.in.host new file mode 100644 index 0000000000..c5af34510d --- /dev/null +++ b/package/rkdeveloptool/Config.in.host @@ -0,0 +1,7 @@ +config BR2_PACKAGE_HOST_RKDEVELOPTOOL + bool "host rkdeveloptool" + help + rkdeveloptool gives you a simple way to read/write rockusb + devices. + + https://github.com/rockchip-linux/rkdeveloptool diff --git a/package/rkdeveloptool/rkdeveloptool.mk b/package/rkdeveloptool/rkdeveloptool.mk new file mode 100644 index 0000000000..2345dcefc0 --- /dev/null +++ b/package/rkdeveloptool/rkdeveloptool.mk @@ -0,0 +1,15 @@ +################################################################################ +# +# rkdeveloptool +# +################################################################################ + +RKDEVELOPTOOL_VERSION = 46bb4c073624226c3f05b37b9ecc50bbcf543f5a +RKDEVELOPTOOL_SITE = $(call github,rockchip-linux,rkdeveloptool,$(RKDEVELOPTOOL_VERSION)) +RKDEVELOPTOOL_LICENSE = GPL2 +RKDEVELOPTOOL_LICENSE_FILES = license.txt +HOST_RKDEVELOPTOOL_DEPENDENCIES = host-libusb + +HOST_RKDEVELOPTOOL_AUTORECONF = YES + +$(eval $(host-autotools-package))
This package is a tool from Rockchip to communicate with Rockusb devices. Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> --- DEVELOPERS | 3 +++ package/Config.in.host | 1 + package/rkdeveloptool/Config.in.host | 7 +++++++ package/rkdeveloptool/rkdeveloptool.mk | 15 +++++++++++++++ 4 files changed, 26 insertions(+) create mode 100644 package/rkdeveloptool/Config.in.host create mode 100644 package/rkdeveloptool/rkdeveloptool.mk