diff mbox series

[1/1] package/libtasn1: do not package tasn1 programs and tests for target

Message ID 20211019063914.58884-1-moritz@h6t.eu
State Accepted
Headers show
Series [1/1] package/libtasn1: do not package tasn1 programs and tests for target | expand

Commit Message

Moritz Bitsch Oct. 19, 2021, 6:39 a.m. UTC 
From: Moritz Bitsch <moritz@h6t.eu>

no included package depends on the tests or programs

Signed-off-by: Moritz Bitsch <moritz@h6t.eu>
---
 package/libtasn1/libtasn1.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Petazzoni Dec. 30, 2021, 5:12 p.m. UTC | #1 
Hello Moritz,

On Tue, 19 Oct 2021 08:39:14 +0200
Moritz Bitsch via buildroot <buildroot@buildroot.org> wrote:

> From: Moritz Bitsch <moritz@h6t.eu>
> 
> no included package depends on the tests or programs
> 
> Signed-off-by: Moritz Bitsch <moritz@h6t.eu>
> ---
>  package/libtasn1/libtasn1.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Sorry for the long delay in getting back to you. I have applied your
patch, but after changing the approach to remove after installation the
3 programs from TARGET_DIR/usr/bin. There are pros and cons to both
approaches, I think the approach of removing an explicit list of files
is what we more commonly use.

Best regards,

Thomas
diff mbox series

Patch

diff --git a/package/libtasn1/libtasn1.mk b/package/libtasn1/libtasn1.mk
index d9d14fde83..da7f885fe5 100644
--- a/package/libtasn1/libtasn1.mk
+++ b/package/libtasn1/libtasn1.mk
@@ -20,4 +20,8 @@  LIBTASN1_CONF_ENV = MAKEINFO="true"
 
 LIBTASN1_CONF_OPTS = CFLAGS="$(TARGET_CFLAGS) -std=gnu99"
 
+define LIBTASN1_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/lib DESTDIR=$(TARGET_DIR) install
+endef
+
 $(eval $(autotools-package))