| Message ID | 20210924124525.168298-1-james.hilliard1@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/wpewebkit: remove gst1-plugins-good from dependencies | expand |
On Fri, 24 Sep 2021 06:45:25 -0600 James Hilliard <james.hilliard1@gmail.com> wrote: > This is only a runtime dependency not a build dependency. > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> Reviewed-by: Adrian perez de Castro <aperez@igalia.com> > --- > package/wpewebkit/wpewebkit.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk > index 5c5e6625f8..50714b4366 100644 > --- a/package/wpewebkit/wpewebkit.mk > +++ b/package/wpewebkit/wpewebkit.mk > @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y) > WPEWEBKIT_CONF_OPTS += \ > -DENABLE_VIDEO=ON \ > -DENABLE_WEB_AUDIO=ON > -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good > +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base > else > WPEWEBKIT_CONF_OPTS += \ > -DENABLE_VIDEO=OFF \ > -- > 2.25.1 > We should do the same edit in package/webkitgtk/webkitgtk.mk :) Cheers, —Adrián
On Fri, 01 Oct 2021 13:25:59 +0300 Adrian Perez de Castro <aperez@igalia.com> wrote: > On Fri, 24 Sep 2021 06:45:25 -0600 James Hilliard <james.hilliard1@gmail.com> wrote: > > This is only a runtime dependency not a build dependency. > > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > > Reviewed-by: Adrian perez de Castro <aperez@igalia.com> > > > --- > > package/wpewebkit/wpewebkit.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk > > index 5c5e6625f8..50714b4366 100644 > > --- a/package/wpewebkit/wpewebkit.mk > > +++ b/package/wpewebkit/wpewebkit.mk > > @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y) > > WPEWEBKIT_CONF_OPTS += \ > > -DENABLE_VIDEO=ON \ > > -DENABLE_WEB_AUDIO=ON > > -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good > > +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base > > else > > WPEWEBKIT_CONF_OPTS += \ > > -DENABLE_VIDEO=OFF \ > > -- > > 2.25.1 > > > > We should do the same edit in package/webkitgtk/webkitgtk.mk :) Done in https://patchwork.ozlabs.org/project/buildroot/patch/20211001103417.1078082-1-aperez@igalia.com/ Cheers, —Adrián
James, All, On 2021-09-24 06:45 -0600, James Hilliard spake thusly: > This is only a runtime dependency not a build dependency. > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/wpewebkit/wpewebkit.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk > index 5c5e6625f8..50714b4366 100644 > --- a/package/wpewebkit/wpewebkit.mk > +++ b/package/wpewebkit/wpewebkit.mk > @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y) > WPEWEBKIT_CONF_OPTS += \ > -DENABLE_VIDEO=ON \ > -DENABLE_WEB_AUDIO=ON > -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good > +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base > else > WPEWEBKIT_CONF_OPTS += \ > -DENABLE_VIDEO=OFF \ > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot@lists.buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > James, All, > On 2021-09-24 06:45 -0600, James Hilliard spake thusly: >> This is only a runtime dependency not a build dependency. >> >> Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > Applied to master, thanks. > Regards, > Yann E. MORIN. >> --- >> package/wpewebkit/wpewebkit.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk >> index 5c5e6625f8..50714b4366 100644 >> --- a/package/wpewebkit/wpewebkit.mk >> +++ b/package/wpewebkit/wpewebkit.mk >> @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y) >> WPEWEBKIT_CONF_OPTS += \ >> -DENABLE_VIDEO=ON \ >> -DENABLE_WEB_AUDIO=ON >> -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good >> +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base NIT: we normally add a # runtime comment to the select line in Config.in then to make it clear why it isn't listed in _DEPENDENCIES.
diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk index 5c5e6625f8..50714b4366 100644 --- a/package/wpewebkit/wpewebkit.mk +++ b/package/wpewebkit/wpewebkit.mk @@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y) WPEWEBKIT_CONF_OPTS += \ -DENABLE_VIDEO=ON \ -DENABLE_WEB_AUDIO=ON -WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base else WPEWEBKIT_CONF_OPTS += \ -DENABLE_VIDEO=OFF \
This is only a runtime dependency not a build dependency. Signed-off-by: James Hilliard <james.hilliard1@gmail.com> --- package/wpewebkit/wpewebkit.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)