diff mbox series

.gitlab-ci.yml: update docker image to 20210922.2200

Message ID 20210922201027.934860-1-arnout@mind.be
State Accepted
Headers show
Series .gitlab-ci.yml: update docker image to 20210922.2200 | expand

Commit Message

Arnout Vandecappelle Sept. 22, 2021, 8:10 p.m. UTC
Commit 71b83227128be62c169313e85bb8f339f977ad67 updated the Dockerfile
to be used in CI tests. In order to actually use this new docker image,
update .gitlab-ci.yml to point to the docker image that was created with
the updated Dockerfile.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Romain Naour Sept. 22, 2021, 9:45 p.m. UTC | #1
Hi Arnout,

Le 22/09/2021 à 22:10, Arnout Vandecappelle (Essensium/Mind) a écrit :
> Commit 71b83227128be62c169313e85bb8f339f977ad67 updated the Dockerfile
> to be used in CI tests. In order to actually use this new docker image,
> update .gitlab-ci.yml to point to the docker image that was created with
> the updated Dockerfile.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

There are some new issues since last time I tested:

Without python installed, syslinux doesn't build.

TestSysLinuxX86EFI/build/syslinux-6.03/com32/cmenu/menugen.py [...]
make[6]: python: No such file or directory

https://gitlab.com/kubu93/buildroot/-/jobs/1614446766


There is a new issue with python-attrs test when python2 is not installed:
https://gitlab.com/kubu93/buildroot/-/jobs/1614446943
https://gitlab.com/kubu93/buildroot/-/jobs/1614446939


Strange python issue with refpolicy-2.20210908 build:
https://gitlab.com/kubu93/buildroot/-/jobs/1614446826/


But the issue I had with TestCheckPackage is fixed with the recent switch to
python3.

https://gitlab.com/kubu93/buildroot/-/jobs/1614447236

With all issues fixed:
  Acked-by: Romain Naour <romain.naour@gmail.com>
  Tested-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain

> ---
>  .gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index bf9f2dca6c..150b8eac1a 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -1,7 +1,7 @@
>  # Configuration for Gitlab-CI.
>  # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines
>  
> -image: buildroot/base:20200814.2228
> +image: buildroot/base:20210922.2200
>  
>  stages:
>    - generate-gitlab-ci
>
Arnout Vandecappelle Sept. 23, 2021, 6:25 p.m. UTC | #2
On 22/09/2021 23:45, Romain Naour wrote:
> Hi Arnout,
> 
> Le 22/09/2021 à 22:10, Arnout Vandecappelle (Essensium/Mind) a écrit :
>> Commit 71b83227128be62c169313e85bb8f339f977ad67 updated the Dockerfile
>> to be used in CI tests. In order to actually use this new docker image,
>> update .gitlab-ci.yml to point to the docker image that was created with
>> the updated Dockerfile.
>>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> 
> There are some new issues since last time I tested:
> 
> Without python installed, syslinux doesn't build.
> 
> TestSysLinuxX86EFI/build/syslinux-6.03/com32/cmenu/menugen.py [...]
> make[6]: python: No such file or directory
> 
> https://gitlab.com/kubu93/buildroot/-/jobs/1614446766

  For that, we just need the python-is-python3 package (or whatever it's 
called). Or, better yet, let syslinux depend on host-python3.


> There is a new issue with python-attrs test when python2 is not installed:
> https://gitlab.com/kubu93/buildroot/-/jobs/1614446943
> https://gitlab.com/kubu93/buildroot/-/jobs/1614446939

  I suspect that that's just because python-attrs no longer supports python2. It 
happens on the autobuilders as well:

http://autobuild.buildroot.net/results/175/175c2dd82dd305ed88b4d1780bd8c52e4f651de5/

  And I have the same failure when I build on my laptop, which does have python2 
installed (though /usr/bin/python is python3).


> Strange python issue with refpolicy-2.20210908 build:
> https://gitlab.com/kubu93/buildroot/-/jobs/1614446826/

  Are you sure it is related to python? I also get the same error when I build 
it locally on my laptop.


  Regards,
  Arnout

> 
> 
> But the issue I had with TestCheckPackage is fixed with the recent switch to
> python3.
> 
> https://gitlab.com/kubu93/buildroot/-/jobs/1614447236
> 
> With all issues fixed:
>    Acked-by: Romain Naour <romain.naour@gmail.com>
>    Tested-by: Romain Naour <romain.naour@gmail.com>
> 
> Best regards,
> Romain
> 
>> ---
>>   .gitlab-ci.yml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index bf9f2dca6c..150b8eac1a 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -1,7 +1,7 @@
>>   # Configuration for Gitlab-CI.
>>   # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines
>>   
>> -image: buildroot/base:20200814.2228
>> +image: buildroot/base:20210922.2200
>>   
>>   stages:
>>     - generate-gitlab-ci
>>
>
Romain Naour Sept. 23, 2021, 8:52 p.m. UTC | #3
Hello Arnout,

On 23/09/2021 20:25, Arnout Vandecappelle wrote:
> 
> 
> On 22/09/2021 23:45, Romain Naour wrote:
>> Hi Arnout,
>>
>> Le 22/09/2021 à 22:10, Arnout Vandecappelle (Essensium/Mind) a écrit :
>>> Commit 71b83227128be62c169313e85bb8f339f977ad67 updated the Dockerfile
>>> to be used in CI tests. In order to actually use this new docker image,
>>> update .gitlab-ci.yml to point to the docker image that was created with
>>> the updated Dockerfile.
>>>
>>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>>
>> There are some new issues since last time I tested:
>>
>> Without python installed, syslinux doesn't build.
>>
>> TestSysLinuxX86EFI/build/syslinux-6.03/com32/cmenu/menugen.py [...]
>> make[6]: python: No such file or directory
>>
>> https://gitlab.com/kubu93/buildroot/-/jobs/1614446766
> 
>  For that, we just need the python-is-python3 package (or whatever it's called).
> Or, better yet, let syslinux depend on host-python3.

Actually python is not a mandatory dependency of Buildroot.
With python-is-python3 installed it doesn't fix the dependency issue for good.

It seems we can override the python interpreter:
https://repo.or.cz/syslinux.git/commitdiff/4dec62ce9c2c0d170f21b3ae2d7c618eb7a30c05

So we can force syslinux using the python3 interpreter provided by host-python3.

> 
> 
>> There is a new issue with python-attrs test when python2 is not installed:
>> https://gitlab.com/kubu93/buildroot/-/jobs/1614446943
>> https://gitlab.com/kubu93/buildroot/-/jobs/1614446939
> 
>  I suspect that that's just because python-attrs no longer supports python2. It
> happens on the autobuilders as well:
> 
> http://autobuild.buildroot.net/results/175/175c2dd82dd305ed88b4d1780bd8c52e4f651de5/
> 

It seems a fix is now available:
http://patchwork.ozlabs.org/project/buildroot/patch/20210923183751.361386-1-asafka7@gmail.com/

> 
>  And I have the same failure when I build on my laptop, which does have python2
> installed (though /usr/bin/python is python3).
> 
> 
>> Strange python issue with refpolicy-2.20210908 build:
>> https://gitlab.com/kubu93/buildroot/-/jobs/1614446826/
> 
>  Are you sure it is related to python? I also get the same error when I build it
> locally on my laptop.

No, I reverted the last version bump of refpolicy and the test succeed.
It seems a refpolicy issue.

Best regards,
Romain


> 
> 
>  Regards,
>  Arnout
> 
>>
>>
>> But the issue I had with TestCheckPackage is fixed with the recent switch to
>> python3.
>>
>> https://gitlab.com/kubu93/buildroot/-/jobs/1614447236
>>
>> With all issues fixed:
>>    Acked-by: Romain Naour <romain.naour@gmail.com>
>>    Tested-by: Romain Naour <romain.naour@gmail.com>
>>
>> Best regards,
>> Romain
>>
>>> ---
>>>   .gitlab-ci.yml | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>>> index bf9f2dca6c..150b8eac1a 100644
>>> --- a/.gitlab-ci.yml
>>> +++ b/.gitlab-ci.yml
>>> @@ -1,7 +1,7 @@
>>>   # Configuration for Gitlab-CI.
>>>   # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines
>>>   -image: buildroot/base:20200814.2228
>>> +image: buildroot/base:20210922.2200
>>>     stages:
>>>     - generate-gitlab-ci
>>>
>>
Romain Naour Oct. 7, 2021, 8:31 p.m. UTC | #4
Hello Arnout,

Le 23/09/2021 à 22:52, Romain Naour a écrit :
> Hello Arnout,
> 
> On 23/09/2021 20:25, Arnout Vandecappelle wrote:
>>
>>
>> On 22/09/2021 23:45, Romain Naour wrote:
>>> Hi Arnout,
>>>
>>> Le 22/09/2021 à 22:10, Arnout Vandecappelle (Essensium/Mind) a écrit :
>>>> Commit 71b83227128be62c169313e85bb8f339f977ad67 updated the Dockerfile
>>>> to be used in CI tests. In order to actually use this new docker image,
>>>> update .gitlab-ci.yml to point to the docker image that was created with
>>>> the updated Dockerfile.
>>>>
>>>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>>>
>>> There are some new issues since last time I tested:
>>>
>>> Without python installed, syslinux doesn't build.
>>>
>>> TestSysLinuxX86EFI/build/syslinux-6.03/com32/cmenu/menugen.py [...]
>>> make[6]: python: No such file or directory
>>>
>>> https://gitlab.com/kubu93/buildroot/-/jobs/1614446766
>>
>>  For that, we just need the python-is-python3 package (or whatever it's called).
>> Or, better yet, let syslinux depend on host-python3.
> 
> Actually python is not a mandatory dependency of Buildroot.
> With python-is-python3 installed it doesn't fix the dependency issue for good.
> 
> It seems we can override the python interpreter:
> https://repo.or.cz/syslinux.git/commitdiff/4dec62ce9c2c0d170f21b3ae2d7c618eb7a30c05
> 
> So we can force syslinux using the python3 interpreter provided by host-python3.

Fixed by:
https://git.buildroot.net/buildroot/commit/?id=6ccfd40711e122c720145044eb4d145a8bacd9db

> 
>>
>>
>>> There is a new issue with python-attrs test when python2 is not installed:
>>> https://gitlab.com/kubu93/buildroot/-/jobs/1614446943
>>> https://gitlab.com/kubu93/buildroot/-/jobs/1614446939
>>
>>  I suspect that that's just because python-attrs no longer supports python2. It
>> happens on the autobuilders as well:
>>
>> http://autobuild.buildroot.net/results/175/175c2dd82dd305ed88b4d1780bd8c52e4f651de5/
>>
> 
> It seems a fix is now available:
> http://patchwork.ozlabs.org/project/buildroot/patch/20210923183751.361386-1-asafka7@gmail.com/

Fixed by:
https://git.buildroot.net/buildroot/commit/?id=ef5c8be25ab373866b5a92d3d9f31bf36b7a8abf

> 
>>
>>  And I have the same failure when I build on my laptop, which does have python2
>> installed (though /usr/bin/python is python3).
>>
>>
>>> Strange python issue with refpolicy-2.20210908 build:
>>> https://gitlab.com/kubu93/buildroot/-/jobs/1614446826/
>>
>>  Are you sure it is related to python? I also get the same error when I build it
>> locally on my laptop.
> 
> No, I reverted the last version bump of refpolicy and the test succeed.
> It seems a refpolicy issue.

Fixed by:
https://git.buildroot.net/buildroot/commit/?id=60f991e68cac30c3e9912e73258f7804e7021d5e

So all the runtest issues has been fixed.

Reviewed-by: Romain Naour <romain.naour@gmail.com>
Tested-by: Romain Naour <romain.naour@gmail.com>

Before merging this patch we can merge the csky toolchain removal:

http://lists.busybox.net/pipermail/buildroot/2021-October/624866.html

Best regards,
Romain


> 
> Best regards,
> Romain
> 
> 
>>
>>
>>  Regards,
>>  Arnout
>>
>>>
>>>
>>> But the issue I had with TestCheckPackage is fixed with the recent switch to
>>> python3.
>>>
>>> https://gitlab.com/kubu93/buildroot/-/jobs/1614447236
>>>
>>> With all issues fixed:
>>>    Acked-by: Romain Naour <romain.naour@gmail.com>
>>>    Tested-by: Romain Naour <romain.naour@gmail.com>
>>>
>>> Best regards,
>>> Romain
>>>
>>>> ---
>>>>   .gitlab-ci.yml | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>>>> index bf9f2dca6c..150b8eac1a 100644
>>>> --- a/.gitlab-ci.yml
>>>> +++ b/.gitlab-ci.yml
>>>> @@ -1,7 +1,7 @@
>>>>   # Configuration for Gitlab-CI.
>>>>   # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines
>>>>   -image: buildroot/base:20200814.2228
>>>> +image: buildroot/base:20210922.2200
>>>>     stages:
>>>>     - generate-gitlab-ci
>>>>
>>>
>
Yann E. MORIN Oct. 17, 2021, 5:05 p.m. UTC | #5
Arnout, All,

On 2021-09-22 22:10 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> Commit 71b83227128be62c169313e85bb8f339f977ad67 updated the Dockerfile
> to be used in CI tests. In order to actually use this new docker image,
> update .gitlab-ci.yml to point to the docker image that was created with
> the updated Dockerfile.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  .gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index bf9f2dca6c..150b8eac1a 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -1,7 +1,7 @@
>  # Configuration for Gitlab-CI.
>  # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines
>  
> -image: buildroot/base:20200814.2228
> +image: buildroot/base:20210922.2200
>  
>  stages:
>    - generate-gitlab-ci
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index bf9f2dca6c..150b8eac1a 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,7 +1,7 @@ 
 # Configuration for Gitlab-CI.
 # Builds appear on https://gitlab.com/buildroot.org/buildroot/pipelines
 
-image: buildroot/base:20200814.2228
+image: buildroot/base:20210922.2200
 
 stages:
   - generate-gitlab-ci