Message ID | 20210914113130.267141-1-takumiiinn@gmail.com |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | [1/1] board/qemu/aarch64-virt/linux.config: Support QEMU Virt UEFI Boot | expand |
On 14/09/2021 13:31, Takumi Takahashi wrote: > QEMU Virt machine type requires ACPI support. > > Example: > > ``` > qemu-system-aarch64 \ > -nographic \ > -M virt \ > -cpu cortex-a57 \ > -m 512 \ > -bios QEMU_EFI.fd \ I wanted to apply and update board/qemu/aarch64-virt/readme.txt with this EFI option. However, when I run with it, it reports "Could not find ROM image 'QEMU_EFI.fd'". I've tried with edk2-aarch64-code.fd instead, and that indeed worked and gave a few ACPI variables. However, the kernel booted just as well without CONFIG_ACPI (but then of course can't access the ACPI variables). So now I'm not sure what the point is really of this patch. I'm not against it per se - but I'd like to understand the reasoning. Therefore, could you resubmit this patch with: - and update to readme.txt that explains how to boot with EFI; - an explanation why CONFIG_ACPI is needed. The latter can be as simple as: "It is possible to run QEMU with UEFI boot, which exposes ACPI variables. To be able to access them from Linux, CONFIG_ACPI must be set." - in the end, we *do* want a kernel config that exposes all features that qemu has to offer. Regards, Arnout > -kernel Image > ``` > > Signed-off-by: Takumi Takahashi <takumiiinn@gmail.com> > --- > board/qemu/aarch64-virt/linux.config | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/board/qemu/aarch64-virt/linux.config b/board/qemu/aarch64-virt/linux.config > index e3a4a92913..20e8367fc6 100644 > --- a/board/qemu/aarch64-virt/linux.config > +++ b/board/qemu/aarch64-virt/linux.config > @@ -14,6 +14,7 @@ CONFIG_ARCH_VEXPRESS=y > CONFIG_COMPAT=y > CONFIG_FW_CFG_SYSFS=y > CONFIG_FW_CFG_SYSFS_CMDLINE=y > +CONFIG_ACPI=y > CONFIG_MODULES=y > CONFIG_MODULE_UNLOAD=y > CONFIG_BLK_DEV_BSGLIB=y >
diff --git a/board/qemu/aarch64-virt/linux.config b/board/qemu/aarch64-virt/linux.config index e3a4a92913..20e8367fc6 100644 --- a/board/qemu/aarch64-virt/linux.config +++ b/board/qemu/aarch64-virt/linux.config @@ -14,6 +14,7 @@ CONFIG_ARCH_VEXPRESS=y CONFIG_COMPAT=y CONFIG_FW_CFG_SYSFS=y CONFIG_FW_CFG_SYSFS_CMDLINE=y +CONFIG_ACPI=y CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y CONFIG_BLK_DEV_BSGLIB=y
QEMU Virt machine type requires ACPI support. Example: ``` qemu-system-aarch64 \ -nographic \ -M virt \ -cpu cortex-a57 \ -m 512 \ -bios QEMU_EFI.fd \ -kernel Image ``` Signed-off-by: Takumi Takahashi <takumiiinn@gmail.com> --- board/qemu/aarch64-virt/linux.config | 1 + 1 file changed, 1 insertion(+)