| Message ID | 20210913142652.942533-1-martin.elshuber@theobroma-systems.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] package/strongswan: fix broken dependency relation | expand |
Martin, All, On 2021-09-13 16:26 +0200, Martin Elshuber spake thusly: > The AKA backend for 3GPP2 requires libgmp (see > https://wiki.strongswan.org/projects/strongswan/wiki/Autoconf). Since > the AKA backend for 3GPP2 is included by BR2_PACKAGE_STRONGSWAN_EAP, > when selecting a crypto backend different from > BR2_PACKAGE_STRONGSWAN_GMP, there is no guarantee the gmp package is > selected as well. When doing so, make fails since the package is in the > dependency chain but not selected: > > $ make > Makefile:585: *** gmp is in the dependency chain of strongswan that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop. > make: *** [Makefile:23: _all] Error 2 > > To fix this, select BR2_PACKAGE_GMP when selecting BR2_PACKAGE_STRONGSWAN_EAP. > > Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com> Applied to master, thanks. I was a bit confused as to what would happen if both gmp and other crypto backend were used to gether, but there are explicitl options to select each of them at ./configure time, so it seems it should be OK, I guess... Regards, Yann E. MORIN. > --- > package/strongswan/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in > index 47c7107f59..368cd1ecc0 100644 > --- a/package/strongswan/Config.in > +++ b/package/strongswan/Config.in > @@ -75,6 +75,7 @@ config BR2_PACKAGE_STRONGSWAN_TNCCS_DYNAMIC > > config BR2_PACKAGE_STRONGSWAN_EAP > bool "Enable EAP protocols" > + select BR2_PACKAGE_GMP > help > Enable various EAP protocols: > - mschapv2 > -- > 2.30.2 > > _______________________________________________ > buildroot mailing list > buildroot@lists.buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Martin" == Martin Elshuber <martin.elshuber@theobroma-systems.com> writes: > The AKA backend for 3GPP2 requires libgmp (see > https://wiki.strongswan.org/projects/strongswan/wiki/Autoconf). Since > the AKA backend for 3GPP2 is included by BR2_PACKAGE_STRONGSWAN_EAP, > when selecting a crypto backend different from > BR2_PACKAGE_STRONGSWAN_GMP, there is no guarantee the gmp package is > selected as well. When doing so, make fails since the package is in the > dependency chain but not selected: > $ make > Makefile:585: *** gmp is in the dependency chain of strongswan that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop. > make: *** [Makefile:23: _all] Error 2 > To fix this, select BR2_PACKAGE_GMP when selecting BR2_PACKAGE_STRONGSWAN_EAP. > Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com> Committed to 2021.02.x, 2021.05.x and 2021.08.x, thanks.
diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in index 47c7107f59..368cd1ecc0 100644 --- a/package/strongswan/Config.in +++ b/package/strongswan/Config.in @@ -75,6 +75,7 @@ config BR2_PACKAGE_STRONGSWAN_TNCCS_DYNAMIC config BR2_PACKAGE_STRONGSWAN_EAP bool "Enable EAP protocols" + select BR2_PACKAGE_GMP help Enable various EAP protocols: - mschapv2
The AKA backend for 3GPP2 requires libgmp (see https://wiki.strongswan.org/projects/strongswan/wiki/Autoconf). Since the AKA backend for 3GPP2 is included by BR2_PACKAGE_STRONGSWAN_EAP, when selecting a crypto backend different from BR2_PACKAGE_STRONGSWAN_GMP, there is no guarantee the gmp package is selected as well. When doing so, make fails since the package is in the dependency chain but not selected: $ make Makefile:585: *** gmp is in the dependency chain of strongswan that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop. make: *** [Makefile:23: _all] Error 2 To fix this, select BR2_PACKAGE_GMP when selecting BR2_PACKAGE_STRONGSWAN_EAP. Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com> --- package/strongswan/Config.in | 1 + 1 file changed, 1 insertion(+)