| Message ID | 20210901141029.892409-1-francois.perrad@gadz.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] support/scripts/pkg-stats: prefers stable version from release-monitoring.org | expand |
ping Le mer. 1 sept. 2021 à 16:10, Francois Perrad <fperrad@gmail.com> a écrit : > for example with libpng: 1.6.37 instead of 1.7.0beta89 > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > --- > support/scripts/pkg-stats | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats > index cc91d1316..249cc6afe 100755 > --- a/support/scripts/pkg-stats > +++ b/support/scripts/pkg-stats > @@ -485,6 +485,7 @@ async def > check_package_get_latest_version_by_distro(session, pkg, retry=True): > > data = await resp.json() > version = data['version'] if 'version' in data else None > + version = data['stable_versions'][0] if 'stable_versions' in > data else version > check_package_latest_version_set_status(pkg, > > RM_API_STATUS_FOUND_BY_DISTRO, > version, > -- > 2.30.2 > >
François, All, On 2021-09-01 16:10 +0200, Francois Perrad spake thusly: > for example with libpng: 1.6.37 instead of 1.7.0beta89 > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > --- > support/scripts/pkg-stats | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats > index cc91d1316..249cc6afe 100755 > --- a/support/scripts/pkg-stats > +++ b/support/scripts/pkg-stats > @@ -485,6 +485,7 @@ async def check_package_get_latest_version_by_distro(session, pkg, retry=True): > > data = await resp.json() > version = data['version'] if 'version' in data else None > + version = data['stable_versions'][0] if 'stable_versions' in data else version I've changed that to fit all in a single line: version = data['stable_versions'][0] if 'stable_versions' in data else data['version'] if 'version' in data else None And it all fits in the allowed 132-char limit! :-) Applied to master, thanks. Regards, Yann E. MORIN. > check_package_latest_version_set_status(pkg, > RM_API_STATUS_FOUND_BY_DISTRO, > version, > -- > 2.30.2 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > François, All, > On 2021-09-01 16:10 +0200, Francois Perrad spake thusly: >> for example with libpng: 1.6.37 instead of 1.7.0beta89 >> >> Signed-off-by: Francois Perrad <francois.perrad@gadz.org> >> --- >> support/scripts/pkg-stats | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats >> index cc91d1316..249cc6afe 100755 >> --- a/support/scripts/pkg-stats >> +++ b/support/scripts/pkg-stats >> @@ -485,6 +485,7 @@ async def check_package_get_latest_version_by_distro(session, pkg, retry=True): >> >> data = await resp.json() >> version = data['version'] if 'version' in data else None >> + version = data['stable_versions'][0] if 'stable_versions' in data else version > I've changed that to fit all in a single line: > version = data['stable_versions'][0] if 'stable_versions' in data else data['version'] if 'version' in data else None > And it all fits in the allowed 132-char limit! :-) ;) NIT: dict.get is handy for such use cases, E.G. version = data.get('version') is equivalent but quite a bit easier to read than: version = data['version'] if 'version' in data else None For this change I guess we could look at versions instead of version and do something like: # first element is the latest version version = data.get('stable_versions', data.get('versions', [None]))[0]
diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats index cc91d1316..249cc6afe 100755 --- a/support/scripts/pkg-stats +++ b/support/scripts/pkg-stats @@ -485,6 +485,7 @@ async def check_package_get_latest_version_by_distro(session, pkg, retry=True): data = await resp.json() version = data['version'] if 'version' in data else None + version = data['stable_versions'][0] if 'stable_versions' in data else version check_package_latest_version_set_status(pkg, RM_API_STATUS_FOUND_BY_DISTRO, version,
for example with libpng: 1.6.37 instead of 1.7.0beta89 Signed-off-by: Francois Perrad <francois.perrad@gadz.org> --- support/scripts/pkg-stats | 1 + 1 file changed, 1 insertion(+)