| Message ID | 20210813073634.389426-1-asafka7@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/python-pymupdf: depend on python3 | expand |
On Fri, 13 Aug 2021 10:36:34 +0300 Asaf Kahlon <asafka7@gmail.com> wrote: > According to the package documentation, python 3.6 or newer > is needed. > > Fixes: > - http://autobuild.buildroot.net/results/f857986b8c9b6d4a843f3694cae8527760540ed0/ > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > --- > package/python-pymupdf/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/python-pymupdf/Config.in b/package/python-pymupdf/Config.in > index 54714eb3bf..64a81895ea 100644 > --- a/package/python-pymupdf/Config.in > +++ b/package/python-pymupdf/Config.in > @@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_PYMUPDF > depends on BR2_TOOLCHAIN_HAS_SYNC_4 # mupdf -> harfbuzz > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # mupdf -> harfbuzz > depends on BR2_PACKAGE_XORG7 > + depends on BR2_PACKAGE_PYTHON3 This dependency should have been propagated to the two Config.in comments in that file, so that they don't appear if Python3 is not used. I fixed that up and applied to master. Thanks! Thomas
Hello, On Fri, Aug 13, 2021 at 4:04 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Fri, 13 Aug 2021 10:36:34 +0300 > Asaf Kahlon <asafka7@gmail.com> wrote: > > > According to the package documentation, python 3.6 or newer > > is needed. > > > > Fixes: > > - http://autobuild.buildroot.net/results/f857986b8c9b6d4a843f3694cae8527760540ed0/ > > > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > > --- > > package/python-pymupdf/Config.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/python-pymupdf/Config.in b/package/python-pymupdf/Config.in > > index 54714eb3bf..64a81895ea 100644 > > --- a/package/python-pymupdf/Config.in > > +++ b/package/python-pymupdf/Config.in > > @@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_PYMUPDF > > depends on BR2_TOOLCHAIN_HAS_SYNC_4 # mupdf -> harfbuzz > > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # mupdf -> harfbuzz > > depends on BR2_PACKAGE_XORG7 > > + depends on BR2_PACKAGE_PYTHON3 > > This dependency should have been propagated to the two Config.in > comments in that file, so that they don't appear if Python3 is not > used. I fixed that up and applied to master. Thanks! Hmm that's interesting... I agree it's needed but from a quick look I think we have packages which don't do that (for example - txtorcon. If the toolchain doesn't support C++, we will see the "comment" part under the python2 external modules menu although python3 is needed). Do I miss something or is it a real mistake? > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Thanks, Asaf.
Hello Asaf, On Sat, 14 Aug 2021 09:04:39 +0300 Asaf Kahlon <asafka7@gmail.com> wrote: > > This dependency should have been propagated to the two Config.in > > comments in that file, so that they don't appear if Python3 is not > > used. I fixed that up and applied to master. Thanks! > > Hmm that's interesting... > I agree it's needed but from a quick look I think we have packages > which don't do that (for example - txtorcon. If the toolchain doesn't > support C++, we will see the "comment" part under the python2 external > modules menu although python3 is needed). > Do I miss something or is it a real mistake? Indeed, python-txtorcon/Config.in is also wrong. Imagine the user: he has python2 enabled, and see "python-XYZ needs a toolchain w/ C++", so he goes ahead and enables C++. Back to the Python menu.. the comment has disappeared, but there is still no option to enable python-XYZ because the option depends on Python 3.x. It would be very confusing, so we definitely want to hide the Config.in comment with a "depends on BR2_PACKAGE_PYTHON3" in this case. Thanks! Thomas
diff --git a/package/python-pymupdf/Config.in b/package/python-pymupdf/Config.in index 54714eb3bf..64a81895ea 100644 --- a/package/python-pymupdf/Config.in +++ b/package/python-pymupdf/Config.in @@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_PYMUPDF depends on BR2_TOOLCHAIN_HAS_SYNC_4 # mupdf -> harfbuzz depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # mupdf -> harfbuzz depends on BR2_PACKAGE_XORG7 + depends on BR2_PACKAGE_PYTHON3 select BR2_PACKAGE_FREETYPE select BR2_PACKAGE_MUPDF select BR2_PACKAGE_ZLIB
According to the package documentation, python 3.6 or newer is needed. Fixes: - http://autobuild.buildroot.net/results/f857986b8c9b6d4a843f3694cae8527760540ed0/ Signed-off-by: Asaf Kahlon <asafka7@gmail.com> --- package/python-pymupdf/Config.in | 1 + 1 file changed, 1 insertion(+)