diff mbox series

[v2,2/3] package/protobuf: fix build failure due to missing -mcmodel=large

Message ID 20210726223435.2906458-3-giulio.benetti@benettiengineering.com
State Accepted
Headers show
Series Fix binutils bug 21464 and remove it | expand

Commit Message

Giulio Benetti July 26, 2021, 10:34 p.m. UTC
When building protobuf for or1k -mcmodel=large is needed to link, so let's
add that gcc option in case we're building for or1k.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/protobuf/protobuf.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Maxim Kochetkov July 27, 2021, 4:26 a.m. UTC | #1
27.07.2021 01:34, Giulio Benetti wrote:
> When building protobuf for or1k -mcmodel=large is needed to link, so let's
> add that gcc option in case we're building for or1k.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   package/protobuf/protobuf.mk | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
> index 492917c5e8..75791fade2 100644
> --- a/package/protobuf/protobuf.mk
> +++ b/package/protobuf/protobuf.mk
> @@ -24,6 +24,10 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
>   PROTOBUF_CXXFLAGS += -O0
>   endif
>   
> +ifeq ($(BR2_or1k),y)
> +PROTOBUF_CXXFLAGS += -mcmodel=large
> +endif
> +
>   PROTOBUF_CONF_ENV = CXXFLAGS="$(PROTOBUF_CXXFLAGS)"
>   
>   ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> 
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
diff mbox series

Patch

diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
index 492917c5e8..75791fade2 100644
--- a/package/protobuf/protobuf.mk
+++ b/package/protobuf/protobuf.mk
@@ -24,6 +24,10 @@  ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
 PROTOBUF_CXXFLAGS += -O0
 endif
 
+ifeq ($(BR2_or1k),y)
+PROTOBUF_CXXFLAGS += -mcmodel=large
+endif
+
 PROTOBUF_CONF_ENV = CXXFLAGS="$(PROTOBUF_CXXFLAGS)"
 
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)