From patchwork Thu Jun 17 09:14:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Norbert Lange X-Patchwork-Id: 1493278 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=cBfG+eY4; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G5GcH3FFPz9s1l for ; Thu, 17 Jun 2021 19:15:27 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BFAD741625; Thu, 17 Jun 2021 09:15:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k_bnVVqTNiLv; Thu, 17 Jun 2021 09:15:23 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id C02954161A; Thu, 17 Jun 2021 09:15:22 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id DCDB41BF30F for ; Thu, 17 Jun 2021 09:15:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C7D8741616 for ; Thu, 17 Jun 2021 09:15:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t15wKofTDflo for ; Thu, 17 Jun 2021 09:15:08 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8EF23415AC for ; Thu, 17 Jun 2021 09:15:08 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id l9so2945699wms.1 for ; Thu, 17 Jun 2021 02:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iP229RPO7fVbCU7pR1oNYTbx8smpbm/6M0EfGVqDUo0=; b=cBfG+eY4RJkonaZSGMy0BJkPW5knWHPihxmFw9UD3LVdDztI8ofg8H6DZJzJTn72Z9 k1Ee+s2d/JNvZ6WQLFL1qEiYXWvdiYZaCXPh1g2QWG6vyqk8EZDGfiQxuUsI4LKflcD4 OZk3kNoARf9vjAzku766yzKhGx+Dl8x2MZtA7KHnSmw20LrVvhnfBhydjxvl4R7q0zrO zj+eSrmAKCZOJy5bebKPhK7pCqKSGBFUo6SNR+5ejtlcOr/gAKLzOGdTxFQ8z//Bdzs7 gDf7O5ziHpK5oGs+DJGFBahuhFQQh9MK+K1dQ+M2qLPaP0dUgddM3D52N5Vq4pimzgiN MSUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iP229RPO7fVbCU7pR1oNYTbx8smpbm/6M0EfGVqDUo0=; b=agZGAbVpdT0g7cciPknUjTST+VXQ7+eOPdS3A9qmqdKkPPg7JxpuAtLy8Cd6nrtM3P T6qwxUshPIkVRDyfcUkLzqdicy+ai7Nnl0Mzc67gbSoG4VtMV7fe5ulR9RSRwFJbUFD6 IWkD6d4FJOcQIUIBXuLJxA2Yc6x5daaXOJDzCeAPXAe3/bPmB0Oyo0kO4ugOB/405nnX 7nOt3/XxHYHa3ODFZ3yVjD64hOL9PaJ2YJFhqpERoofxjcyN/J7JKg6q1JrpVLA4A/ux OwN+P4xg+4EQHCsC4il//iof2neg1hnRXCws7h+NcxSSKVWLmci40ThcsZUJsn4AHcZe FCag== X-Gm-Message-State: AOAM532uSx/V+GJWbLy9ONXB6qPWCVEEDE+bwEi4+C/zy+bAGv4QV7no ZJWuj6+dyLYliPldgWV9cEL3oHn6Xwio6A== X-Google-Smtp-Source: ABdhPJyNKAuN8HkEURr5SxPA6HtaMbtbcqqpoDctsX1BsEfCGJqg1Y0ZNNDT15xNc5O6Rl91nVx3EQ== X-Received: by 2002:a05:600c:4ba1:: with SMTP id e33mr3940512wmp.39.1623921306836; Thu, 17 Jun 2021 02:15:06 -0700 (PDT) Received: from debian-noppl.. (84-114-45-16.cable.dynamic.surfer.at. [84.114.45.16]) by smtp.gmail.com with ESMTPSA id r6sm4752767wrt.21.2021.06.17.02.15.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 02:15:06 -0700 (PDT) From: Norbert Lange To: buildroot@buildroot.org Date: Thu, 17 Jun 2021 11:14:51 +0200 Message-Id: <20210617091456.272611-2-nolange79@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210617091456.272611-1-nolange79@gmail.com> References: <20210617091456.272611-1-nolange79@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCH v3 2/3] package/zstd: Change Build options X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Norbert Lange Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Disable the legacy format, these are just needed for decompressing files created with pre-release version. Use Buildroot's setting for optimization, zstd's build system overrides CFLAGS, but MOREFLAGS can override again. Quick tests show that using -O2 (like buildroot) is actually a little faster than -O3 on x86_64 Atoms. Signed-off-by: Norbert Lange --- v2->v3: * Remove ZSTD_OPTS_MOREFLAGS variable --- package/zstd/zstd.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/zstd/zstd.mk b/package/zstd/zstd.mk index 95f25ebfa4..54ce4133fe 100644 --- a/package/zstd/zstd.mk +++ b/package/zstd/zstd.mk @@ -13,6 +13,7 @@ ZSTD_CPE_ID_VENDOR = facebook ZSTD_CPE_ID_PRODUCT = zstandard ZSTD_OPTS += PREFIX=/usr +ZSTD_OPTS += ZSTD_LEGACY_SUPPORT=0 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) ZSTD_OPTS += HAVE_THREAD=1 @@ -41,6 +42,9 @@ else ZSTD_OPTS += HAVE_LZ4=0 endif +# zstd will append -O3 after $(CFLAGS), use MOREFLAGS to override again +ZSTD_OPTS += MOREFLAGS="$(TARGET_OPTIMIZATION)" + ZSTD_BUILD_PROG_TARGET = zstd-release # Since v1.5.0 the dynamic library is built for