| Message ID | 20210616173303.2234867-1-arnout@mind.be |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/lvm2: default standard install to y | expand |
Arnout, All, On 2021-06-16 19:33 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly: > Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8 > BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the > default read: > > default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11 > > Since the legacy symbol is normally not selected, this defaults to y. > > Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the > entire line instead of just the condition. > > Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846 > For-stable: 2021.02, 2021.05 > Cc: dominique.tronche@atos.net > Cc: Yann E. MORIN <yann.morin.1998@free.fr> > Cc: Peter Korsgaard <peter@korsgaard.com> > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Applied to master, thanks. Regards, Yann E. MORIN. > -- > As an experiment, I added the For-stable tag (which I invented myself). > Peter, is this useful? Should we propose this in the documentation? > --- > package/lvm2/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/lvm2/Config.in b/package/lvm2/Config.in > index 317027929e..cc740dd40c 100644 > --- a/package/lvm2/Config.in > +++ b/package/lvm2/Config.in > @@ -26,6 +26,7 @@ if BR2_PACKAGE_LVM2 > > config BR2_PACKAGE_LVM2_STANDARD_INSTALL > bool "standard install instead of only dmsetup" > + default y > # http://lists.busybox.net/pipermail/buildroot/2016-August/170592.html > depends on !BR2_TOOLCHAIN_USES_MUSL > help > -- > 2.31.1 >
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes: > Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8 > BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the > default read: > default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11 > Since the legacy symbol is normally not selected, this defaults to y. > Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the > entire line instead of just the condition. > Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846 > For-stable: 2021.02, 2021.05 > Cc: dominique.tronche@atos.net > Cc: Yann E. MORIN <yann.morin.1998@free.fr> > Cc: Peter Korsgaard <peter@korsgaard.com> > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > -- > As an experiment, I added the For-stable tag (which I invented myself). > Peter, is this useful? Should we propose this in the documentation? It could be. Typically just mentioning that this is a fix and/or CC me is enough, but it cannot hurt certainly.
On 17/06/2021 14:43, Peter Korsgaard wrote: >>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes: > > > Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8 > > BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the > > default read: > > > default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11 > > > Since the legacy symbol is normally not selected, this defaults to y. > > > Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the > > entire line instead of just the condition. > > > Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846 > > For-stable: 2021.02, 2021.05 > > Cc: dominique.tronche@atos.net > > Cc: Yann E. MORIN <yann.morin.1998@free.fr> > > Cc: Peter Korsgaard <peter@korsgaard.com> > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > > -- > > As an experiment, I added the For-stable tag (which I invented myself). > > Peter, is this useful? Should we propose this in the documentation? > > It could be. Typically just mentioning that this is a fix and/or CC me > is enough, but it cannot hurt certainly. I'm mostly thinking about finding out to which stable branches it applies. Currently, contributors rarely go through the effort of checking that. So the question is: is it worth your while to ask contributors to check to which stable branches a fix is applicable? I've added "Fixes: <sha1>" tags a few times, but then I realized it doesn't actually help a lot. Regards, Arnout
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes: >>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes: >> Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8 >> BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the >> default read: >> default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11 >> Since the legacy symbol is normally not selected, this defaults to y. >> Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the >> entire line instead of just the condition. >> Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846 >> For-stable: 2021.02, 2021.05 >> Cc: dominique.tronche@atos.net >> Cc: Yann E. MORIN <yann.morin.1998@free.fr> >> Cc: Peter Korsgaard <peter@korsgaard.com> >> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> >> -- >> As an experiment, I added the For-stable tag (which I invented myself). >> Peter, is this useful? Should we propose this in the documentation? > It could be. Typically just mentioning that this is a fix and/or CC me > is enough, but it cannot hurt certainly. Committed to 2021.02.x and 2021.05.x, thanks.
diff --git a/package/lvm2/Config.in b/package/lvm2/Config.in index 317027929e..cc740dd40c 100644 --- a/package/lvm2/Config.in +++ b/package/lvm2/Config.in @@ -26,6 +26,7 @@ if BR2_PACKAGE_LVM2 config BR2_PACKAGE_LVM2_STANDARD_INSTALL bool "standard install instead of only dmsetup" + default y # http://lists.busybox.net/pipermail/buildroot/2016-August/170592.html depends on !BR2_TOOLCHAIN_USES_MUSL help
Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8 BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the default read: default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11 Since the legacy symbol is normally not selected, this defaults to y. Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the entire line instead of just the condition. Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846 For-stable: 2021.02, 2021.05 Cc: dominique.tronche@atos.net Cc: Yann E. MORIN <yann.morin.1998@free.fr> Cc: Peter Korsgaard <peter@korsgaard.com> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> -- As an experiment, I added the For-stable tag (which I invented myself). Peter, is this useful? Should we propose this in the documentation? --- package/lvm2/Config.in | 1 + 1 file changed, 1 insertion(+)