diff mbox series

[1/1] package/perl-crypt-openssl-rsa: requires RMD160 support in openssl

Message ID 20210612205835.546667-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/perl-crypt-openssl-rsa: requires RMD160 support in openssl | expand

Commit Message

Fabrice Fontaine June 12, 2021, 8:58 p.m. UTC
Enable RMD160 in openssl to fix build failure raised since commit
a83d41867c8d69a77d5cd0a665aa216af5340359

Fixes:
 - http://autobuild.buildroot.org/results/e61d2f06812ce171e20bac96b3573d57927030d0

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/perl-crypt-openssl-rsa/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN June 12, 2021, 9:40 p.m. UTC | #1
Fabrice, All,

On 2021-06-12 22:58 +0200, Fabrice Fontaine spake thusly:
> Enable RMD160 in openssl to fix build failure raised since commit
> a83d41867c8d69a77d5cd0a665aa216af5340359
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e61d2f06812ce171e20bac96b3573d57927030d0
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/perl-crypt-openssl-rsa/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/perl-crypt-openssl-rsa/Config.in b/package/perl-crypt-openssl-rsa/Config.in
> index e58a921bcb..7c0c3acf17 100644
> --- a/package/perl-crypt-openssl-rsa/Config.in
> +++ b/package/perl-crypt-openssl-rsa/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_PERL_CRYPT_OPENSSL_RSA
>  	bool "perl-crypt-openssl-rsa"
>  	depends on !BR2_STATIC_LIBS
>  	select BR2_PACKAGE_PERL_CRYPT_OPENSSL_RANDOM # runtime
> +	select BR2_PACKAGE_LIBOPENSSL_ENABLE_RMD160 if BR2_PACKAGE_LIBOPENSSL

This is confusing, because perl-crypt-openssl-rsa does not depend,
conditionally or unconditionally, on openssl: it is not in its
dependencies...

However, the dependency is indirect via perl-crypt-openssl-random, so
this is really going to confuse people.

I've fixed that by pushing an extra preliminary fix to ad openssl to the
dependencies of perl-crypt-openssl-rsa.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  	help
>  	  RSA encoding and decoding, using the openSSL libraries.
>  
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/perl-crypt-openssl-rsa/Config.in b/package/perl-crypt-openssl-rsa/Config.in
index e58a921bcb..7c0c3acf17 100644
--- a/package/perl-crypt-openssl-rsa/Config.in
+++ b/package/perl-crypt-openssl-rsa/Config.in
@@ -2,6 +2,7 @@  config BR2_PACKAGE_PERL_CRYPT_OPENSSL_RSA
 	bool "perl-crypt-openssl-rsa"
 	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_PERL_CRYPT_OPENSSL_RANDOM # runtime
+	select BR2_PACKAGE_LIBOPENSSL_ENABLE_RMD160 if BR2_PACKAGE_LIBOPENSSL
 	help
 	  RSA encoding and decoding, using the openSSL libraries.