Message ID | 20210608194926.14477-2-ps.report@gmx.net |
---|---|
State | Accepted |
Headers | show |
Series | [v1,1/2] package/libinput: bump version to 1.17.3 | expand |
On 08/06/2021 21:49, Peter Seiderer wrote: > For details see [1]. > > [1] https://lists.freedesktop.org/archives/wayland-devel/2021-June/041849.html > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> Why is this bump in two separate patches? If it's because 1.17.3 should be applied to the 2021.05 branch, then it's better to make two distinct patches, one for master that bumps directly to 1.18.0, and another for stable that is marked explicitly as such with --subject-prefix. Regards, Arnout > --- > package/libinput/libinput.hash | 6 +++--- > package/libinput/libinput.mk | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/package/libinput/libinput.hash b/package/libinput/libinput.hash > index 038859289a..de8e94f9fa 100644 > --- a/package/libinput/libinput.hash > +++ b/package/libinput/libinput.hash > @@ -1,6 +1,6 @@ > -# From https://lists.freedesktop.org/archives/wayland-devel/2021-May/041834.html > -sha256 0d010e0bf601b5d3a06b3c4d77d67751cf554f3e6448e57aa046ea9ee8f818ac libinput-1.17.3.tar.xz > -sha512 3d1ab4362ede886996795d700a938d20e04cd922e8f9598fe9346f9f93e149119526fb324a096787b4b8a47bf3e5613130bcd874f10df86761031710d2acc792 libinput-1.17.3.tar.xz > +# From https://lists.freedesktop.org/archives/wayland-devel/2021-June/041849.html > +sha256 18c6a286583268d39841348e561fbb4713bde0c643b360f5d8a3f27800afdb9a libinput-1.18.0.tar.xz > +sha512 9a834f075d7a1f892416bb6b241eb052f749d3aa883c4b39c0f1c9616c115d6b9a541b587508646fddaf0d3fe57af92fe4629b522d1d51196499e7b523e0aa90 libinput-1.18.0.tar.xz > > # License files > sha256 70d5b1dfe5a9c50a1f2ea91b1c2b1c85d876c5c92339585edbb85cf69e945e14 COPYING > diff --git a/package/libinput/libinput.mk b/package/libinput/libinput.mk > index 8ce60c8639..32b822edb7 100644 > --- a/package/libinput/libinput.mk > +++ b/package/libinput/libinput.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -LIBINPUT_VERSION = 1.17.3 > +LIBINPUT_VERSION = 1.18.0 > LIBINPUT_SOURCE = libinput-$(LIBINPUT_VERSION).tar.xz > LIBINPUT_SITE = http://www.freedesktop.org/software/libinput > LIBINPUT_DEPENDENCIES = host-pkgconf libevdev mtdev udev >
On Thu, 22 Jul 2021 23:18:56 +0200 Arnout Vandecappelle <arnout@mind.be> wrote: > On 08/06/2021 21:49, Peter Seiderer wrote: > > For details see [1]. > > > > [1] https://lists.freedesktop.org/archives/wayland-devel/2021-June/041849.html > > > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > > Why is this bump in two separate patches? If it's because 1.17.3 should be > applied to the 2021.05 branch, then it's better to make two distinct patches, > one for master that bumps directly to 1.18.0, and another for stable that is > marked explicitly as such with --subject-prefix. Gah sorry, I'm only seeing this now after having applied the patches. Peter also did the same (bump in several steps) libxmlrpc, so I was not too concerned about this. Though I agree that your question makes sense. Best regards, Thomas
Hello Arnout, Thomas, On Sat, 24 Jul 2021 09:49:31 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > On Thu, 22 Jul 2021 23:18:56 +0200 > Arnout Vandecappelle <arnout@mind.be> wrote: > > > On 08/06/2021 21:49, Peter Seiderer wrote: > > > For details see [1]. > > > > > > [1] https://lists.freedesktop.org/archives/wayland-devel/2021-June/041849.html > > > > > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > > > > Why is this bump in two separate patches? If it's because 1.17.3 should be > > applied to the 2021.05 branch, then it's better to make two distinct patches, > > one for master that bumps directly to 1.18.0, and another for stable that is > > marked explicitly as such with --subject-prefix. Yes, this was the intention of the split..., will mark it more explicitly next time... > > Gah sorry, I'm only seeing this now after having applied the patches. > Peter also did the same (bump in several steps) libxmlrpc, so I was not > too concerned about this. Though I agree that your question makes sense. For libxmlrpc the same applies for the first patch..., the other two where split because they where tagged with code/stable and code/advanced, was not sure about the whole/complete bump but did not find a downside for the code/advanced one... Regards, Peter > > Best regards, > > Thomas
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes: > Hello Arnout, Thomas, > On Sat, 24 Jul 2021 09:49:31 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: >> On Thu, 22 Jul 2021 23:18:56 +0200 >> Arnout Vandecappelle <arnout@mind.be> wrote: >> >> > On 08/06/2021 21:49, Peter Seiderer wrote: >> > > For details see [1]. >> > > >> > > [1] https://lists.freedesktop.org/archives/wayland-devel/2021-June/041849.html >> > > >> > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> >> > >> > Why is this bump in two separate patches? If it's because 1.17.3 should be >> > applied to the 2021.05 branch, then it's better to make two distinct patches, >> > one for master that bumps directly to 1.18.0, and another for stable that is >> > marked explicitly as such with --subject-prefix. > Yes, this was the intention of the split..., will mark it more explicitly next > time... >> >> Gah sorry, I'm only seeing this now after having applied the patches. >> Peter also did the same (bump in several steps) libxmlrpc, so I was not >> too concerned about this. Though I agree that your question makes sense. > For libxmlrpc the same applies for the first patch..., the other two where > split because they where tagged with code/stable and code/advanced, was not > sure about the whole/complete bump but did not find a downside for the > code/advanced one... In general I think this is fine, and I indeed backported the first libxmlrpc to 2021.02.x and 2021.05.x, but for libinput we are on 1.16.4 on 2021.02.x, so the 1.17.3 bump is not applicable (unless 1.17.x fix some important issues?)
diff --git a/package/libinput/libinput.hash b/package/libinput/libinput.hash index 038859289a..de8e94f9fa 100644 --- a/package/libinput/libinput.hash +++ b/package/libinput/libinput.hash @@ -1,6 +1,6 @@ -# From https://lists.freedesktop.org/archives/wayland-devel/2021-May/041834.html -sha256 0d010e0bf601b5d3a06b3c4d77d67751cf554f3e6448e57aa046ea9ee8f818ac libinput-1.17.3.tar.xz -sha512 3d1ab4362ede886996795d700a938d20e04cd922e8f9598fe9346f9f93e149119526fb324a096787b4b8a47bf3e5613130bcd874f10df86761031710d2acc792 libinput-1.17.3.tar.xz +# From https://lists.freedesktop.org/archives/wayland-devel/2021-June/041849.html +sha256 18c6a286583268d39841348e561fbb4713bde0c643b360f5d8a3f27800afdb9a libinput-1.18.0.tar.xz +sha512 9a834f075d7a1f892416bb6b241eb052f749d3aa883c4b39c0f1c9616c115d6b9a541b587508646fddaf0d3fe57af92fe4629b522d1d51196499e7b523e0aa90 libinput-1.18.0.tar.xz # License files sha256 70d5b1dfe5a9c50a1f2ea91b1c2b1c85d876c5c92339585edbb85cf69e945e14 COPYING diff --git a/package/libinput/libinput.mk b/package/libinput/libinput.mk index 8ce60c8639..32b822edb7 100644 --- a/package/libinput/libinput.mk +++ b/package/libinput/libinput.mk @@ -4,7 +4,7 @@ # ################################################################################ -LIBINPUT_VERSION = 1.17.3 +LIBINPUT_VERSION = 1.18.0 LIBINPUT_SOURCE = libinput-$(LIBINPUT_VERSION).tar.xz LIBINPUT_SITE = http://www.freedesktop.org/software/libinput LIBINPUT_DEPENDENCIES = host-pkgconf libevdev mtdev udev
For details see [1]. [1] https://lists.freedesktop.org/archives/wayland-devel/2021-June/041849.html Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- package/libinput/libinput.hash | 6 +++--- package/libinput/libinput.mk | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)