From patchwork Tue May 25 17:26:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Norbert Lange X-Patchwork-Id: 1483669 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=thpSq2+b; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqLcx70mpz9sRf for ; Wed, 26 May 2021 03:27:45 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7BF0540538; Tue, 25 May 2021 17:27:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GOCWFkfDmgwg; Tue, 25 May 2021 17:27:43 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id A860D4052A; Tue, 25 May 2021 17:27:42 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 4375B1BF57B for ; Tue, 25 May 2021 17:27:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 312D060B21 for ; Tue, 25 May 2021 17:27:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yGviZldQuuwH for ; Tue, 25 May 2021 17:27:05 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by smtp3.osuosl.org (Postfix) with ESMTPS id 67A8760B1E for ; Tue, 25 May 2021 17:27:05 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id s22so48359485ejv.12 for ; Tue, 25 May 2021 10:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8McsL1907ews49QI0oplpZ4Ds397CKcztUftDiWCXCQ=; b=thpSq2+bgX5ribYAbBicoRFZ/VegEKhmRaJeP6w4T+jBBnYx6rslSR2ZVt8voWsI2e g4ER5Jo2cTUVrl/MTrbvKaa8Xh7wjneRzxtk0uwDYP2Hnm/u4CUonemql5iH277/WpkA F6nxzkM/OJoeYI4VElmZtmVv76Qcj4S/YFJwUtVg4bRa+yhWKt4pDRzDsIMzdvps974x gSb0QDVg/CAH4LqO2V5PV9fcI936HYcJvNitImQ//o4ZzlONlAMwktoMiNw0K027M9Va Ew6bDZPcmV1ukyvRuPwY7jJl2mmMIawoO066x4EZTTz8AC3ZS4qQw12UOkPyIFOrxag2 IspQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8McsL1907ews49QI0oplpZ4Ds397CKcztUftDiWCXCQ=; b=K/uWyNRg2rPOjj+MLfLDO/fL9wO+tWQsrtiKSvgBbwdYWghEdaoCpA4suqU+KRC3C5 LwF1rL20FyW8tMFfw74/un0p8dQtRs+wnHgpUzwVFtLMzS8LIN4SUfouzmHzIua64sHp SMtqF7Drt/3DpbdEW6CWKaBx7lzRbY8ZifZnJRrtt867WyztmDi/zr6/5v2mRE87Ulr3 LnBLqq4mVaw6Qc2E3UPZMCwTCIX1U819+YkOrIQ8YYJs1NgMdZjgekFx+4urjjiaMCq+ 23IteJWeXxPHW4ZpPXYNyht3qvoQ5F5Cqo56ig4ErGJJuuFZdnokU321sS0M2P/VNuER cIUA== X-Gm-Message-State: AOAM532woQ9GfHsBIEphvwnGY4MVMojK1idAOHKZ6Er8rN+R6GuIF92D +yg7DjmqiH7YsWZ+s1ieX+c3L+YieguQIg== X-Google-Smtp-Source: ABdhPJzI7NCvZzCaAAwhFs8XKN9xrGwYHTlyhZNT29dXs+TTcQZZu7Jt+CkmTq6Evqi3xGdTa1H/KQ== X-Received: by 2002:a17:907:2056:: with SMTP id pg22mr29855962ejb.19.1621963623718; Tue, 25 May 2021 10:27:03 -0700 (PDT) Received: from debian-noppl.. (84-114-45-16.cable.dynamic.surfer.at. [84.114.45.16]) by smtp.gmail.com with ESMTPSA id w10sm9333204ejq.48.2021.05.25.10.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 10:27:03 -0700 (PDT) From: Norbert Lange To: buildroot@buildroot.org Date: Tue, 25 May 2021 19:26:50 +0200 Message-Id: <20210525172652.821351-4-nolange79@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210525172652.821351-1-nolange79@gmail.com> References: <20210525172652.821351-1-nolange79@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCH v2 4/5] package/zstd: Change Build options X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Norbert Lange Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Disable the legacy format, these are just needed for decompressing files created with pre-release version. Use Buildroot's setting for optimization, zstd's build system overrides CFLAGS, but MOREFLAGS can override again. Quick tests show that using -O2 (like buildroot) is actually a little faster than -O3 on x86_64 Atoms. Signed-off-by: Norbert Lange --- package/zstd/zstd.mk | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/package/zstd/zstd.mk b/package/zstd/zstd.mk index a7a5ba4e50..a9499df4d0 100644 --- a/package/zstd/zstd.mk +++ b/package/zstd/zstd.mk @@ -13,6 +13,10 @@ ZSTD_CPE_ID_VENDOR = facebook ZSTD_CPE_ID_PRODUCT = zstandard ZSTD_OPTS += PREFIX=/usr +ZSTD_OPTS += ZSTD_LEGACY_SUPPORT=0 + +# zstd will append -O3 after $(CFLAGS), use MOREFLAGS to override again +ZSTD_OPTS_MOREFLAGS += $(TARGET_OPTIMIZATION) ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) ZSTD_OPTS += HAVE_THREAD=1 @@ -41,6 +45,8 @@ else ZSTD_OPTS += HAVE_LZ4=0 endif +ZSTD_OPTS += "MOREFLAGS=$(ZSTD_OPTS_MOREFLAGS)" + ZSTD_BUILD_PROG_TARGET := zstd-release # Since v1.5.0 the dynamic library is built for