From patchwork Tue May 25 12:27:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1483364 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=rcFl/aEB; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FqD0y11Szz9sCD for ; Tue, 25 May 2021 22:29:38 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9A27760ACB; Tue, 25 May 2021 12:29:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L_q9JdOuh32l; Tue, 25 May 2021 12:29:35 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id E3F4A60AD1; Tue, 25 May 2021 12:29:34 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 575661BF396 for ; Tue, 25 May 2021 12:28:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 542D360AE1 for ; Tue, 25 May 2021 12:28:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uWSzNRpg4ayz for ; Tue, 25 May 2021 12:28:10 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by smtp3.osuosl.org (Postfix) with ESMTPS id 8030660A64 for ; Tue, 25 May 2021 12:28:10 +0000 (UTC) Received: by mail-ed1-x52f.google.com with SMTP id i13so35970754edb.9 for ; Tue, 25 May 2021 05:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o6ZuqCZU0d6g9B1S/C59O5l0KkSJjkUNPS7EFoKUvJE=; b=rcFl/aEBgeyGNXl/1IgpyZu2otZSMDagaTtPVMCTqYhwVOr28qsB2kPAlxLqfjzYUi 97mvJfbymkTy36hsbPkwFdmfZhukzzcNYN2+o4XVkA/YbXjMkTgcyNIXcOIG9RpxQCvu +9il2GP39OotEGTq+huI5dld0ukRgdh5xhShvqakS6lL2LddjEnXafmOP26NYyHa1WMM KpukjTwzy3YrNax0VTHr7JNG3avZ85QK2PcZ0H5Q4OMo47IK5v24yA6d3zgTHQUSNLEM uBHzw/WKErxzhIRzTugBeHjT1mMc4yrQsWapsYYEJmnGzFDfRdP+1Qk6BwEQ7QOYrGk+ 4urQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o6ZuqCZU0d6g9B1S/C59O5l0KkSJjkUNPS7EFoKUvJE=; b=o3/eC8TKD41DeJLkZQuslCXEAseL6TBBju1zst2HQhQ6CrOKoRbObkNFmtCjZ5OfCE 3kP9g/6+lbil6jg0aMW4tteokbcIRUAvkFrIbHfB2Az/LG6dYgBdOkj/SgWXi5HJLaLg wSP7RvFPLIZ3o27FB8NP7Pf5LhvfW/ex0xnG7l5bsqP5Zcv8oZWsKIAMwFVcLoijb/K5 xsRYKvr1E4s1e/QdVkwtw0y4uUgvFu+GVmuBWUBMu3xby17aV9LK/y9TXRGzJJB5qW+2 sbU/IdsbvZDiHXUcererOmlTHSn67mIqT4eYGbZCdGQ8xABzIAdrV209dUcpcTYbTvzf So+g== X-Gm-Message-State: AOAM531TlWPOORldJSIW5n1KLygcZHNZeQD8ynL7O2pmaTvlK5KprY0u 8quluG718KCZ4FoLlNvWH9rP5U5iWOgapg== X-Google-Smtp-Source: ABdhPJzYgEYcV8NWJOp92Ny/Ph5rhWLGR3vuKwljUjSdxv2m4cybDmamnH/tCdMfizCiKMm0Cj5TPw== X-Received: by 2002:a50:eb47:: with SMTP id z7mr32125995edp.68.1621945688734; Tue, 25 May 2021 05:28:08 -0700 (PDT) Received: from localhost (ptr-5gw9txf6g5tndjqqqz.18120a2.ip6.access.telenet.be. [2a02:1810:510:3800:1b15:18e4:57d1:eb]) by smtp.gmail.com with ESMTPSA id d11sm8844278ejr.58.2021.05.25.05.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:28:08 -0700 (PDT) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 25 May 2021 14:27:41 +0200 Message-Id: <20210525122750.5022-7-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210525122750.5022-1-patrickdepinguin@gmail.com> References: <20210525122750.5022-1-patrickdepinguin@gmail.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 06/15] package/sysrepo: remove explicit setting of CMAKE_BUILD_TYPE X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Thiery , =?utf-8?q?Jan_Kundr=C3=A1t?= , Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire sysrepo explicitly sets CMAKE_BUILD_TYPE=Release, ignoring any possible value of BR2_ENABLE_DEBUG (previously) or BR2_ENABLE_RUNTIME_DEBUG (now). With the introduction of BR2_ENABLE_RUNTIME_DEBUG, this change should no longer be necessary. Users that do not wish to have additional runtime debugging just keep BR2_ENABLE_RUNTIME_DEBUG disabled (default value). As the 'Debug' build type enables tests, disable them explicitly. As the 'Debug' build type uses a custom REPO_PATH which does not exist on target, force /etc/sysrepo like in the 'Release' build type. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) Acked-by: Heiko Thiery --- package/sysrepo/sysrepo.mk | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/package/sysrepo/sysrepo.mk b/package/sysrepo/sysrepo.mk index f5be29d2c9..c0db05e52c 100644 --- a/package/sysrepo/sysrepo.mk +++ b/package/sysrepo/sysrepo.mk @@ -13,8 +13,10 @@ SYSREPO_DEPENDENCIES = libyang pcre host-sysrepo HOST_SYSREPO_DEPENDENCIES = host-libyang host-pcre SYSREPO_CONF_OPTS = \ - -DCMAKE_BUILD_TYPE=Release \ - -DBUILD_EXAMPLES=$(if $(BR2_PACKAGE_SYSREPO_EXAMPLES),ON,OFF) + -DBUILD_EXAMPLES=$(if $(BR2_PACKAGE_SYSREPO_EXAMPLES),ON,OFF) \ + -DENABLE_TESTS=OFF \ + -DENABLE_VALGRIND_TESTS=OFF \ + -DREPO_PATH=/etc/sysrepo ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) SYSREPO_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic