diff mbox series

[RFC/next,1/1] package/hostapd: enable MD4 in openssl

Message ID 20210522194845.593676-1-geomatsi@gmail.com
State Accepted
Headers show
Series [RFC/next,1/1] package/hostapd: enable MD4 in openssl | expand

Commit Message

Sergey Matyukevich May 22, 2021, 7:48 p.m. UTC
Hostapd assumes that openssl always provides MD4 support. However MD4
support in openssl has become optional since  commit a83d41867c8d
("package/libopenssl: add option to enable some features").

Select openssl MD4 support in hostapd Kconfig to avoid build failures.

Fixes:
http://autobuild.buildroot.net/results/09ce1d8009da98cd2a3f2c8488abaa9f060a9d6b/

Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
---
 package/hostapd/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN May 22, 2021, 7:59 p.m. UTC | #1
Sergey, All,

On 2021-05-22 22:48 +0300, Sergey Matyukevich spake thusly:
> Hostapd assumes that openssl always provides MD4 support. However MD4
> support in openssl has become optional since  commit a83d41867c8d
> ("package/libopenssl: add option to enable some features").
> 
> Select openssl MD4 support in hostapd Kconfig to avoid build failures.
> 
> Fixes:
> http://autobuild.buildroot.net/results/09ce1d8009da98cd2a3f2c8488abaa9f060a9d6b/
> 
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>

Applied to next, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/hostapd/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in
> index 54d2086c09..1ac7f6cd5a 100644
> --- a/package/hostapd/Config.in
> +++ b/package/hostapd/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_HOSTAPD
>  	bool "hostapd"
>  	depends on BR2_USE_MMU # fork()
> +	select BR2_PACKAGE_LIBOPENSSL_ENABLE_MD4 if BR2_PACKAGE_LIBOPENSSL
>  	help
>  	  User space daemon for wireless access points.
>  
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Sergey Matyukevich May 22, 2021, 8:07 p.m. UTC | #2
Hello Yann,

> > Hostapd assumes that openssl always provides MD4 support. However MD4
> > support in openssl has become optional since  commit a83d41867c8d
> > ("package/libopenssl: add option to enable some features").
> > 
> > Select openssl MD4 support in hostapd Kconfig to avoid build failures.
> > 
> > Fixes:
> > http://autobuild.buildroot.net/results/09ce1d8009da98cd2a3f2c8488abaa9f060a9d6b/
> > 
> > Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> 
> Applied to next, thanks.

Once again I forgot about wpa_supplicant. It has the same issue, though
not yet in autobuilder. I will double-check build and send another fix.

Regards,
Sergey
Yann E. MORIN May 22, 2021, 8:09 p.m. UTC | #3
Sergey, All,

On 2021-05-22 23:07 +0300, Sergey Matyukevich spake thusly:
> > > Hostapd assumes that openssl always provides MD4 support. However MD4
> > > support in openssl has become optional since  commit a83d41867c8d
> > > ("package/libopenssl: add option to enable some features").
> > > 
> > > Select openssl MD4 support in hostapd Kconfig to avoid build failures.
> > > 
> > > Fixes:
> > > http://autobuild.buildroot.net/results/09ce1d8009da98cd2a3f2c8488abaa9f060a9d6b/
> > > 
> > > Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> > Applied to next, thanks.
> Once again I forgot about wpa_supplicant. It has the same issue, though
> not yet in autobuilder. I will double-check build and send another fix.

Ah, yes, damn, I forgot too. :-)

Thanks, I'll keep an eye for your patch, then. Thanks! :-)

Regards,
Yann E. MORIN.
diff mbox series

Patch

diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in
index 54d2086c09..1ac7f6cd5a 100644
--- a/package/hostapd/Config.in
+++ b/package/hostapd/Config.in
@@ -1,6 +1,7 @@ 
 config BR2_PACKAGE_HOSTAPD
 	bool "hostapd"
 	depends on BR2_USE_MMU # fork()
+	select BR2_PACKAGE_LIBOPENSSL_ENABLE_MD4 if BR2_PACKAGE_LIBOPENSSL
 	help
 	  User space daemon for wireless access points.