diff mbox series

package/waylandpp: add dependency to BR2_INSTALL_LIBSTDCPP

Message ID 20210521091403.29209-1-heiko.thiery@gmail.com
State Accepted
Headers show
Series package/waylandpp: add dependency to BR2_INSTALL_LIBSTDCPP | expand

Commit Message

Heiko Thiery May 21, 2021, 9:14 a.m. UTC
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 package/waylandpp/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN May 21, 2021, 9:35 a.m. UTC | #1
Heiko, All,

On 2021-05-21 11:14 +0200, Heiko Thiery spake thusly:
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
>  package/waylandpp/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/waylandpp/Config.in b/package/waylandpp/Config.in
> index 3d7362b3c0..86ca965056 100644
> --- a/package/waylandpp/Config.in
> +++ b/package/waylandpp/Config.in
> @@ -3,14 +3,16 @@ config BR2_PACKAGE_WAYLANDPP
>  	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND
>  	depends on BR2_HOST_GCC_AT_LEAST_4_9
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +	depends on BR2_INSTALL_LIBSTDCPP

You forgot to propagate that dependency to packages that select
waylandpp, namely kodi, so I've done that and applied to master,
thanks.

Regards,
Yann E. MORIN.

>  	depends on BR2_PACKAGE_WAYLAND
>  	help
>  	  Wayland C++ bindings
>  
>  	  https://github.com/NilsBrause/waylandpp
>  
> -comment "waylandpp needs an OpenGL-EGL/wayland backend, a toolchain w/ gcc >= 4.9, host gcc >= 4.9"
> +comment "waylandpp needs an OpenGL-EGL/wayland backend, a toolchain w/ gcc >= 4.9, host gcc >= 4.9, C++ support"
>  	depends on BR2_PACKAGE_WAYLAND
>  	depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
>  		!BR2_HOST_GCC_AT_LEAST_4_9 || \
> -		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
> +		!BR2_INSTALL_LIBSTDCPP
> -- 
> 2.30.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard June 7, 2021, 9:19 p.m. UTC | #2
>>>>> "Heiko" == Heiko Thiery <heiko.thiery@gmail.com> writes:

 > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

Committed to 2021.02.x, thanks.
diff mbox series

Patch

diff --git a/package/waylandpp/Config.in b/package/waylandpp/Config.in
index 3d7362b3c0..86ca965056 100644
--- a/package/waylandpp/Config.in
+++ b/package/waylandpp/Config.in
@@ -3,14 +3,16 @@  config BR2_PACKAGE_WAYLANDPP
 	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND
 	depends on BR2_HOST_GCC_AT_LEAST_4_9
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_WAYLAND
 	help
 	  Wayland C++ bindings
 
 	  https://github.com/NilsBrause/waylandpp
 
-comment "waylandpp needs an OpenGL-EGL/wayland backend, a toolchain w/ gcc >= 4.9, host gcc >= 4.9"
+comment "waylandpp needs an OpenGL-EGL/wayland backend, a toolchain w/ gcc >= 4.9, host gcc >= 4.9, C++ support"
 	depends on BR2_PACKAGE_WAYLAND
 	depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
 		!BR2_HOST_GCC_AT_LEAST_4_9 || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
+		!BR2_INSTALL_LIBSTDCPP