| Message ID | 20210514220316.1942381-2-thomas.petazzoni@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Add jh71xx-tools package | expand |
On Sat, May 15, 2021 at 6:03 AM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Add jh71xx-tools as a new host package, it includes a tool that allows > to recover the bootloader of JH71xx-based platforms, such as the > BeagleV. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > --- > DEVELOPERS | 1 + > package/Config.in.host | 1 + > package/jh71xx-tools/Config.in.host | 7 +++++++ > package/jh71xx-tools/jh71xx-tools.hash | 3 +++ > package/jh71xx-tools/jh71xx-tools.mk | 20 ++++++++++++++++++++ > 5 files changed, 32 insertions(+) > create mode 100644 package/jh71xx-tools/Config.in.host > create mode 100644 package/jh71xx-tools/jh71xx-tools.hash > create mode 100644 package/jh71xx-tools/jh71xx-tools.mk > > diff --git a/DEVELOPERS b/DEVELOPERS > index ed86dc82ba..a90ad1c354 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -2633,6 +2633,7 @@ F: package/heirloom-mailx/ > F: package/hiawatha/ > F: package/igh-ethercat/ > F: package/intltool/ > +F: package/jh71xx-tools/ > F: package/libcap/ > F: package/libffi/ > F: package/libsha1/ > diff --git a/package/Config.in.host b/package/Config.in.host > index ba6a68c728..cef36cebc1 100644 > --- a/package/Config.in.host > +++ b/package/Config.in.host > @@ -40,6 +40,7 @@ menu "Host utilities" > source "package/imx-mkimage/Config.in.host" > source "package/imx-usb-loader/Config.in.host" > source "package/jq/Config.in.host" > + source "package/jh71xx-tools/Config.in.host" nits: this should put be before "jq" per alphabetical order > source "package/jsmin/Config.in.host" > source "package/kmod/Config.in.host" > source "package/libp11/Config.in.host" > diff --git a/package/jh71xx-tools/Config.in.host b/package/jh71xx-tools/Config.in.host > new file mode 100644 > index 0000000000..08872f295c > --- /dev/null > +++ b/package/jh71xx-tools/Config.in.host > @@ -0,0 +1,7 @@ > +config BR2_PACKAGE_HOST_JH71XX_TOOLS > + bool "host jh71xx-tools" > + depends on BR2_riscv > + help > + Bootloader recovery and updater tool for StarFive JH7100 SoCs. > + > + https://github.com/kprasadvnsi/JH71xx-tools > diff --git a/package/jh71xx-tools/jh71xx-tools.hash b/package/jh71xx-tools/jh71xx-tools.hash > new file mode 100644 > index 0000000000..d8a88dcb22 > --- /dev/null > +++ b/package/jh71xx-tools/jh71xx-tools.hash > @@ -0,0 +1,3 @@ > +# Locally calculated > +sha256 0f16ea896164f6e8bfe0a03bbbd95ff14d474445ba6f045f9377d01282c9364f jh71xx-tools-7a29f4b9d2355aa39afa8680680909bb74e4991d.tar.gz > +sha256 3ef425421620cd815709f3ede736bb83dbfc47201897b66731606dc699e98460 jh7100-recover.c > diff --git a/package/jh71xx-tools/jh71xx-tools.mk b/package/jh71xx-tools/jh71xx-tools.mk > new file mode 100644 > index 0000000000..b9f3974931 > --- /dev/null > +++ b/package/jh71xx-tools/jh71xx-tools.mk > @@ -0,0 +1,20 @@ > +################################################################################ > +# > +# jh71xx-tools > +# > +################################################################################ > + > +JH71XX_TOOLS_VERSION = 7a29f4b9d2355aa39afa8680680909bb74e4991d > +JH71XX_TOOLS_SITE = $(call github,kprasadvnsi,JH71xx-tools,$(JH71XX_TOOLS_VERSION)) > +JH71XX_TOOLS_LICENSE = MIT > +JH71XX_TOOLS_LICENSE_FILES = jh7100-recover.c > + > +define HOST_JH71XX_TOOLS_BUILD_CMDS > + $(HOSTCC) -o $(@D)/jh7100-recover $(@D)/jh7100-recover.c > +endef > + > +define HOST_JH71XX_TOOLS_INSTALL_CMDS > + $(INSTALL) -D -m 0755 $(@D)/jh7100-recover $(HOST_DIR)/bin/jh7100-recover > +endef > + > +$(eval $(host-generic-package)) Otherwise, Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Thomas, All, On 2021-05-15 00:03 +0200, Thomas Petazzoni spake thusly: > Add jh71xx-tools as a new host package, it includes a tool that allows > to recover the bootloader of JH71xx-based platforms, such as the > BeagleV. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Applied to master, thanks. But see below... [--SNIP--] > diff --git a/package/Config.in.host b/package/Config.in.host > index ba6a68c728..cef36cebc1 100644 > --- a/package/Config.in.host > +++ b/package/Config.in.host > @@ -40,6 +40,7 @@ menu "Host utilities" > source "package/imx-mkimage/Config.in.host" > source "package/imx-usb-loader/Config.in.host" > source "package/jq/Config.in.host" > + source "package/jh71xx-tools/Config.in.host" Alphabetical order fixed, as spotted by Bin. [--SNIP--] > diff --git a/package/jh71xx-tools/jh71xx-tools.mk b/package/jh71xx-tools/jh71xx-tools.mk > new file mode 100644 > index 0000000000..b9f3974931 > --- /dev/null > +++ b/package/jh71xx-tools/jh71xx-tools.mk > @@ -0,0 +1,20 @@ > +################################################################################ > +# > +# jh71xx-tools > +# > +################################################################################ > + > +JH71XX_TOOLS_VERSION = 7a29f4b9d2355aa39afa8680680909bb74e4991d > +JH71XX_TOOLS_SITE = $(call github,kprasadvnsi,JH71xx-tools,$(JH71XX_TOOLS_VERSION)) > +JH71XX_TOOLS_LICENSE = MIT > +JH71XX_TOOLS_LICENSE_FILES = jh7100-recover.c Not sure why you choose to use the source file as license file, when there is an actual LICENSE file in the tree. So I've switched to using that. Regards, Yann E. MORIN. > +define HOST_JH71XX_TOOLS_BUILD_CMDS > + $(HOSTCC) -o $(@D)/jh7100-recover $(@D)/jh7100-recover.c > +endef > + > +define HOST_JH71XX_TOOLS_INSTALL_CMDS > + $(INSTALL) -D -m 0755 $(@D)/jh7100-recover $(HOST_DIR)/bin/jh7100-recover > +endef > + > +$(eval $(host-generic-package)) > -- > 2.31.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello, On Sat, 15 May 2021 14:15:34 +0200 "Yann E. MORIN" <yann.morin.1998@free.fr> wrote: > > + source "package/jh71xx-tools/Config.in.host" > > Alphabetical order fixed, as spotted by Bin. Thanks! It is interesting that this was not spotted by check-package. > > +JH71XX_TOOLS_VERSION = 7a29f4b9d2355aa39afa8680680909bb74e4991d > > +JH71XX_TOOLS_SITE = $(call github,kprasadvnsi,JH71xx-tools,$(JH71XX_TOOLS_VERSION)) > > +JH71XX_TOOLS_LICENSE = MIT > > +JH71XX_TOOLS_LICENSE_FILES = jh7100-recover.c > > Not sure why you choose to use the source file as license file, when > there is an actual LICENSE file in the tree. So I've switched to using > that. I'm not sure how I missed that, because I remember I looked at the code base and thought "meh, there is no license file, I should file a github issue about this". Anyway, you fixed it, so thanks for that! Best regards, Thomas
diff --git a/DEVELOPERS b/DEVELOPERS index ed86dc82ba..a90ad1c354 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -2633,6 +2633,7 @@ F: package/heirloom-mailx/ F: package/hiawatha/ F: package/igh-ethercat/ F: package/intltool/ +F: package/jh71xx-tools/ F: package/libcap/ F: package/libffi/ F: package/libsha1/ diff --git a/package/Config.in.host b/package/Config.in.host index ba6a68c728..cef36cebc1 100644 --- a/package/Config.in.host +++ b/package/Config.in.host @@ -40,6 +40,7 @@ menu "Host utilities" source "package/imx-mkimage/Config.in.host" source "package/imx-usb-loader/Config.in.host" source "package/jq/Config.in.host" + source "package/jh71xx-tools/Config.in.host" source "package/jsmin/Config.in.host" source "package/kmod/Config.in.host" source "package/libp11/Config.in.host" diff --git a/package/jh71xx-tools/Config.in.host b/package/jh71xx-tools/Config.in.host new file mode 100644 index 0000000000..08872f295c --- /dev/null +++ b/package/jh71xx-tools/Config.in.host @@ -0,0 +1,7 @@ +config BR2_PACKAGE_HOST_JH71XX_TOOLS + bool "host jh71xx-tools" + depends on BR2_riscv + help + Bootloader recovery and updater tool for StarFive JH7100 SoCs. + + https://github.com/kprasadvnsi/JH71xx-tools diff --git a/package/jh71xx-tools/jh71xx-tools.hash b/package/jh71xx-tools/jh71xx-tools.hash new file mode 100644 index 0000000000..d8a88dcb22 --- /dev/null +++ b/package/jh71xx-tools/jh71xx-tools.hash @@ -0,0 +1,3 @@ +# Locally calculated +sha256 0f16ea896164f6e8bfe0a03bbbd95ff14d474445ba6f045f9377d01282c9364f jh71xx-tools-7a29f4b9d2355aa39afa8680680909bb74e4991d.tar.gz +sha256 3ef425421620cd815709f3ede736bb83dbfc47201897b66731606dc699e98460 jh7100-recover.c diff --git a/package/jh71xx-tools/jh71xx-tools.mk b/package/jh71xx-tools/jh71xx-tools.mk new file mode 100644 index 0000000000..b9f3974931 --- /dev/null +++ b/package/jh71xx-tools/jh71xx-tools.mk @@ -0,0 +1,20 @@ +################################################################################ +# +# jh71xx-tools +# +################################################################################ + +JH71XX_TOOLS_VERSION = 7a29f4b9d2355aa39afa8680680909bb74e4991d +JH71XX_TOOLS_SITE = $(call github,kprasadvnsi,JH71xx-tools,$(JH71XX_TOOLS_VERSION)) +JH71XX_TOOLS_LICENSE = MIT +JH71XX_TOOLS_LICENSE_FILES = jh7100-recover.c + +define HOST_JH71XX_TOOLS_BUILD_CMDS + $(HOSTCC) -o $(@D)/jh7100-recover $(@D)/jh7100-recover.c +endef + +define HOST_JH71XX_TOOLS_INSTALL_CMDS + $(INSTALL) -D -m 0755 $(@D)/jh7100-recover $(HOST_DIR)/bin/jh7100-recover +endef + +$(eval $(host-generic-package))
Add jh71xx-tools as a new host package, it includes a tool that allows to recover the bootloader of JH71xx-based platforms, such as the BeagleV. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- DEVELOPERS | 1 + package/Config.in.host | 1 + package/jh71xx-tools/Config.in.host | 7 +++++++ package/jh71xx-tools/jh71xx-tools.hash | 3 +++ package/jh71xx-tools/jh71xx-tools.mk | 20 ++++++++++++++++++++ 5 files changed, 32 insertions(+) create mode 100644 package/jh71xx-tools/Config.in.host create mode 100644 package/jh71xx-tools/jh71xx-tools.hash create mode 100644 package/jh71xx-tools/jh71xx-tools.mk