diff mbox series

[1/1] package/weston: add configuration options for weston shells

Message ID 20210511154006.630376-1-martin.elshuber@theobroma-systems.com
State New
Headers show
Series [1/1] package/weston: add configuration options for weston shells | expand

Commit Message

Martin Elshuber May 11, 2021, 3:40 p.m. UTC
Enable selection of used weston shells. By default all available
shells are enabled to keep the old behavior. The new configuration
options enable the user to select them individually.

Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com>
---
 package/weston/Config.in | 16 ++++++++++++++++
 package/weston/weston.mk | 24 ++++++++++++++++++++++++
 2 files changed, 40 insertions(+)

Comments

Yann E. MORIN May 19, 2021, 10:14 a.m. UTC | #1
Martin, All,

On 2021-05-11 17:40 +0200, Martin Elshuber spake thusly:
> Enable selection of used weston shells. By default all available
> shells are enabled to keep the old behavior. The new configuration
> options enable the user to select them individually.

Don't we have to ensure that at least one is enabled, or is it valid to
disable all of them?

Regards,
Yann E. MORIN.

> Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com>
> ---
>  package/weston/Config.in | 16 ++++++++++++++++
>  package/weston/weston.mk | 24 ++++++++++++++++++++++++
>  2 files changed, 40 insertions(+)
> 
> diff --git a/package/weston/Config.in b/package/weston/Config.in
> index d07eba4c9d..60351ff09d 100644
> --- a/package/weston/Config.in
> +++ b/package/weston/Config.in
> @@ -119,6 +119,22 @@ config BR2_PACKAGE_WESTON_XWAYLAND
>  comment "XWayland support needs libepoxy and X.org enabled"
>  	depends on !BR2_PACKAGE_XORG7 || !BR2_PACKAGE_LIBEPOXY
>  
> +config BR2_PACKAGE_WESTON_SHELL_DESKTOP
> +	bool "desktop shell"
> +	default y
> +
> +config BR2_PACKAGE_WESTON_SHELL_FULLSCREEN
> +	bool "fullscreen shell"
> +	default y
> +
> +config BR2_PACKAGE_WESTON_SHELL_IVI
> +	bool "ivi shell"
> +	default y
> +
> +config BR2_PACKAGE_WESTON_SHELL_KIOSK
> +	bool "kiosk shell"
> +	default y
> +
>  config BR2_PACKAGE_WESTON_DEMO_CLIENTS
>  	bool "demo clients"
>  	depends on BR2_USE_MMU # pango
> diff --git a/package/weston/weston.mk b/package/weston/weston.mk
> index f59963bf2e..6953132c57 100644
> --- a/package/weston/weston.mk
> +++ b/package/weston/weston.mk
> @@ -132,6 +132,30 @@ else
>  WESTON_CONF_OPTS += -Dtest-junit-xml=false
>  endif
>  
> +ifeq ($(BR2_PACKAGE_WESTON_SHELL_DESKTOP),y)
> +WESTON_CONF_OPTS += -Dshell-desktop=true
> +else
> +WESTON_CONF_OPTS += -Dshell-desktop=false
> +endif
> +
> +ifeq ($(BR2_PACKAGE_WESTON_SHELL_FULLSCREEN),y)
> +WESTON_CONF_OPTS += -Dshell-fullscreen=true
> +else
> +WESTON_CONF_OPTS += -Dshell-fullscreen=false
> +endif
> +
> +ifeq ($(BR2_PACKAGE_WESTON_SHELL_IVI),y)
> +WESTON_CONF_OPTS += -Dshell-ivi=true
> +else
> +WESTON_CONF_OPTS += -Dshell-ivi=false
> +endif
> +
> +ifeq ($(BR2_PACKAGE_WESTON_SHELL_KIOSK),y)
> +WESTON_CONF_OPTS += -Dshell-kiosk=true
> +else
> +WESTON_CONF_OPTS += -Dshell-kiosk=false
> +endif
> +
>  ifeq ($(BR2_PACKAGE_WESTON_DEMO_CLIENTS),y)
>  WESTON_CONF_OPTS += -Ddemo-clients=true
>  WESTON_DEPENDENCIES += pango
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Martin Elshuber May 28, 2021, 10:54 a.m. UTC | #2
On 19/05/2021 12:14, Yann E. MORIN wrote:
> Martin, All,
>
> On 2021-05-11 17:40 +0200, Martin Elshuber spake thusly:
>> Enable selection of used weston shells. By default all available
>> shells are enabled to keep the old behavior. The new configuration
>> options enable the user to select them individually.
> Don't we have to ensure that at least one is enabled, or is it valid to
> disable all of them?
I think it makes sense to allow disabling all shells, since one might
want to add its own, non default, implementaion.
I this case the user might want disable all shells that are included in
the weston package.

I suggest to add a help comment:

help
  if unsure say yes

>
> Regards,
> Yann E. MORIN.
>
>> Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com>
>> ---
>>  package/weston/Config.in | 16 ++++++++++++++++
>>  package/weston/weston.mk | 24 ++++++++++++++++++++++++
>>  2 files changed, 40 insertions(+)
>>
>> diff --git a/package/weston/Config.in b/package/weston/Config.in
>> index d07eba4c9d..60351ff09d 100644
>> --- a/package/weston/Config.in
>> +++ b/package/weston/Config.in
>> @@ -119,6 +119,22 @@ config BR2_PACKAGE_WESTON_XWAYLAND
>>  comment "XWayland support needs libepoxy and X.org enabled"
>>  	depends on !BR2_PACKAGE_XORG7 || !BR2_PACKAGE_LIBEPOXY
>>  
>> +config BR2_PACKAGE_WESTON_SHELL_DESKTOP
>> +	bool "desktop shell"
>> +	default y
>> +
>> +config BR2_PACKAGE_WESTON_SHELL_FULLSCREEN
>> +	bool "fullscreen shell"
>> +	default y
>> +
>> +config BR2_PACKAGE_WESTON_SHELL_IVI
>> +	bool "ivi shell"
>> +	default y
>> +
>> +config BR2_PACKAGE_WESTON_SHELL_KIOSK
>> +	bool "kiosk shell"
>> +	default y
>> +
>>  config BR2_PACKAGE_WESTON_DEMO_CLIENTS
>>  	bool "demo clients"
>>  	depends on BR2_USE_MMU # pango
>> diff --git a/package/weston/weston.mk b/package/weston/weston.mk
>> index f59963bf2e..6953132c57 100644
>> --- a/package/weston/weston.mk
>> +++ b/package/weston/weston.mk
>> @@ -132,6 +132,30 @@ else
>>  WESTON_CONF_OPTS += -Dtest-junit-xml=false
>>  endif
>>  
>> +ifeq ($(BR2_PACKAGE_WESTON_SHELL_DESKTOP),y)
>> +WESTON_CONF_OPTS += -Dshell-desktop=true
>> +else
>> +WESTON_CONF_OPTS += -Dshell-desktop=false
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_WESTON_SHELL_FULLSCREEN),y)
>> +WESTON_CONF_OPTS += -Dshell-fullscreen=true
>> +else
>> +WESTON_CONF_OPTS += -Dshell-fullscreen=false
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_WESTON_SHELL_IVI),y)
>> +WESTON_CONF_OPTS += -Dshell-ivi=true
>> +else
>> +WESTON_CONF_OPTS += -Dshell-ivi=false
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_WESTON_SHELL_KIOSK),y)
>> +WESTON_CONF_OPTS += -Dshell-kiosk=true
>> +else
>> +WESTON_CONF_OPTS += -Dshell-kiosk=false
>> +endif
>> +
>>  ifeq ($(BR2_PACKAGE_WESTON_DEMO_CLIENTS),y)
>>  WESTON_CONF_OPTS += -Ddemo-clients=true
>>  WESTON_DEPENDENCIES += pango
>> -- 
>> 2.30.2
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
Yann E. MORIN May 28, 2021, 12:01 p.m. UTC | #3
Martin, All,

On 2021-05-28 12:54 +0200, Martin Elshuber spake thusly:
> On 19/05/2021 12:14, Yann E. MORIN wrote:
> > On 2021-05-11 17:40 +0200, Martin Elshuber spake thusly:
> >> Enable selection of used weston shells. By default all available
> >> shells are enabled to keep the old behavior. The new configuration
> >> options enable the user to select them individually.
> > Don't we have to ensure that at least one is enabled, or is it valid to
> > disable all of them?
> I think it makes sense to allow disabling all shells, since one might
> want to add its own, non default, implementaion.
> I this case the user might want disable all shells that are included in
> the weston package.

I see your point. But then, people writting their own are also probably
be writteing their entire compositor too, probably...

But otherwise, you have a point anyway.

> I suggest to add a help comment:
> help
>   if unsure say yes

That has never prevented people from saying 'n' even when they don't
know. You can't prevent anyone from shooting themselves in the foot. ;-)

Regards,
Yann E. MORIN.
diff mbox series

Patch

diff --git a/package/weston/Config.in b/package/weston/Config.in
index d07eba4c9d..60351ff09d 100644
--- a/package/weston/Config.in
+++ b/package/weston/Config.in
@@ -119,6 +119,22 @@  config BR2_PACKAGE_WESTON_XWAYLAND
 comment "XWayland support needs libepoxy and X.org enabled"
 	depends on !BR2_PACKAGE_XORG7 || !BR2_PACKAGE_LIBEPOXY
 
+config BR2_PACKAGE_WESTON_SHELL_DESKTOP
+	bool "desktop shell"
+	default y
+
+config BR2_PACKAGE_WESTON_SHELL_FULLSCREEN
+	bool "fullscreen shell"
+	default y
+
+config BR2_PACKAGE_WESTON_SHELL_IVI
+	bool "ivi shell"
+	default y
+
+config BR2_PACKAGE_WESTON_SHELL_KIOSK
+	bool "kiosk shell"
+	default y
+
 config BR2_PACKAGE_WESTON_DEMO_CLIENTS
 	bool "demo clients"
 	depends on BR2_USE_MMU # pango
diff --git a/package/weston/weston.mk b/package/weston/weston.mk
index f59963bf2e..6953132c57 100644
--- a/package/weston/weston.mk
+++ b/package/weston/weston.mk
@@ -132,6 +132,30 @@  else
 WESTON_CONF_OPTS += -Dtest-junit-xml=false
 endif
 
+ifeq ($(BR2_PACKAGE_WESTON_SHELL_DESKTOP),y)
+WESTON_CONF_OPTS += -Dshell-desktop=true
+else
+WESTON_CONF_OPTS += -Dshell-desktop=false
+endif
+
+ifeq ($(BR2_PACKAGE_WESTON_SHELL_FULLSCREEN),y)
+WESTON_CONF_OPTS += -Dshell-fullscreen=true
+else
+WESTON_CONF_OPTS += -Dshell-fullscreen=false
+endif
+
+ifeq ($(BR2_PACKAGE_WESTON_SHELL_IVI),y)
+WESTON_CONF_OPTS += -Dshell-ivi=true
+else
+WESTON_CONF_OPTS += -Dshell-ivi=false
+endif
+
+ifeq ($(BR2_PACKAGE_WESTON_SHELL_KIOSK),y)
+WESTON_CONF_OPTS += -Dshell-kiosk=true
+else
+WESTON_CONF_OPTS += -Dshell-kiosk=false
+endif
+
 ifeq ($(BR2_PACKAGE_WESTON_DEMO_CLIENTS),y)
 WESTON_CONF_OPTS += -Ddemo-clients=true
 WESTON_DEPENDENCIES += pango